CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-11 02:47:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fix bug that could caused variable map to be left in an inconsistent state. (#9339)

Browse Source
This commit is contained in:
Aaron Dodson
2025-09-02 12:39:16 -07:00
committed by GitHub
parent 55f5d648a8
commit 9b60088d4b
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/variable_map.ts
View File

@@ -112,7 +112,11 @@ export class VariableMap
const oldType = variable.getType();
if (oldType === newType) return variable;
this.variableMap.get(variable.getType())?.delete(variable.getId());
const oldTypeVariables = this.variableMap.get(oldType);
oldTypeVariables?.delete(variable.getId());
if (oldTypeVariables?.size === 0) {
this.variableMap.delete(oldType);
}
variable.setType(newType);
const newTypeVariables =
this.variableMap.get(newType) ??

7
tests/mocha/variable_map_test.js
View File

@@ -258,6 +258,13 @@ suite('Variable Map', function () {
assert.deepEqual(newTypeVariables, [variable]);
assert.equal(variable.getType(), '');
});
test('removes the type from the map when the last instance is changed', function () {
const var1 = this.variableMap.createVariable('name1', 'type1');
const var2 = this.variableMap.createVariable('name2', 'type2');
this.variableMap.changeVariableType(var1, 'type2');
assert.deepEqual(this.variableMap.getTypes(), ['type2']);
});
},
);