Clean up todos.

This commit is contained in:
Rachel Fenichel
2019-10-07 13:25:47 -07:00
parent bc4cb542e8
commit 9ce41598c0
6 changed files with 2 additions and 8 deletions

View File

@@ -288,7 +288,6 @@ Blockly.blockRendering.ConstantProvider.prototype.makeNotch = function() {
Blockly.utils.svgPaths.point(dir * outerWidth, -height)
]);
}
// TODO: Find a relationship between width and path
var pathLeft = makeMainPath(1);
var pathRight = makeMainPath(-1);

View File

@@ -457,7 +457,6 @@ Blockly.blockRendering.RenderInfo.prototype.getInRowSpacing_ = function(prev, ne
/**
* Figure out where the right edge of the block and right edge of statement inputs
* should be placed.
* TODO: More cleanup.
* @protected
*/
Blockly.blockRendering.RenderInfo.prototype.computeBounds_ = function() {
@@ -476,9 +475,7 @@ Blockly.blockRendering.RenderInfo.prototype.computeBounds_ = function() {
Math.max(widestRowWithConnectedBlocks, row.widthWithConnectedBlocks);
}
this.statementEdge = widestStatementRowFields;
this.width = blockWidth;
for (var i = 0, row; (row = this.rows[i]); i++) {

View File

@@ -237,7 +237,6 @@ Blockly.geras.Highlighter.prototype.drawInlineInput = function(input) {
var startY = yPos + offset;
if (this.RTL_) {
// TODO: Check if this is different when the inline input is populated.
var aboveTabHeight = input.connectionOffsetY - offset;
var belowTabHeight = input.height -
(input.connectionOffsetY + input.connectionHeight) + offset;

View File

@@ -61,7 +61,8 @@ Blockly.blockRendering.InputConnection = function(constants, input) {
this.connectedBlockHeight = 0;
}
// TODO: change references to connectionModel, since that's on Connection.
// TODO (#3186): change references to connectionModel, since that's on
// Connection.
this.connection = input.connection;
this.connectionOffsetX = 0;
this.connectionOffsetY = 0;

View File

@@ -166,7 +166,6 @@ Blockly.blockRendering.Row.prototype.measure = function() {
/**
* Get the last input on this row, if it has one.
* TODO: Consider moving this to InputRow, if possible.
* @return {Blockly.blockRendering.InputConnection} The last input on the row,
* or null.
* @package

View File

@@ -241,7 +241,6 @@ Blockly.zelos.ConstantProvider.prototype.makeNotch = function() {
);
}
// TODO: Find a relationship between width and path
var pathLeft = makeMainPath(1);
var pathRight = makeMainPath(-1);