CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-09 10:00:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't update shadows on connections since they are immutable.

Browse Source
This commit is contained in:
Neil Fraser
2015-11-22 04:26:58 -08:00
parent d702808f71
commit a239c7207f
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/connection.js
View File

@@ -161,14 +161,10 @@ Blockly.Connection.prototype.connect = function(otherConnection) {
// Can't make a value connection if male block is already connected.
throw 'Source connection already connected (value).';
} else if (otherConnection.targetConnection) {
// Record and disable the shadow so that it does not respawn here.
var shadowDom = otherConnection.getShadowDom();
otherConnection.setShadowDom(null);
// If female block is already connected, disconnect and bump the male.
var orphanBlock = otherConnection.targetBlock();
orphanBlock.setParent(null);
if (orphanBlock.isShadow()) {
otherConnection.setShadowDom(Blockly.Xml.blockToDom_(orphanBlock));
orphanBlock.dispose();
} else {
if (!orphanBlock.outputConnection) {
@@ -194,8 +190,6 @@ Blockly.Connection.prototype.connect = function(otherConnection) {
orphanBlock.outputConnection.bumpAwayFrom_(otherConnection);
}, Blockly.BUMP_DELAY);
}
// Restore the shadow.
otherConnection.setShadowDom(shadowDom);
}
}
} else {