CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-11 19:07:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Block comments from XML not fatal

Browse Source 
…if Blockly.Comment was not compiled in.
This commit is contained in:
Neil Fraser
2019-09-27 11:40:55 -07:00
committed by Neil Fraser
parent b701475984
commit a2e6cfffcc
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/xml.js
View File

@@ -433,14 +433,14 @@ Blockly.Xml.domToWorkspace = function(xml, workspace) {
if (workspace.rendered) {
if (!Blockly.WorkspaceCommentSvg) {
console.warn('Missing require for Blockly.WorkspaceCommentSvg, ' +
'ignoring comment block.');
'ignoring workspace comment.');
} else {
Blockly.WorkspaceCommentSvg.fromXml(xmlChild, workspace, width);
}
} else {
if (!Blockly.WorkspaceComment) {
console.warn('Missing require for Blockly.WorkspaceComment, ' +
'ignoring comment block.');
'ignoring workspace comment.');
} else {
Blockly.WorkspaceComment.fromXml(xmlChild, workspace);
}
@@ -668,6 +668,11 @@ Blockly.Xml.domToBlockHeadless_ = function(xmlBlock, workspace) {
}
break;
case 'comment':
if (!Blockly.Comment) {
console.warn('Missing require for Blockly.Comment, ' +
'ignoring block comment.');
break;
}
var text = xmlChild.textContent;
var pinned = xmlChild.getAttribute('pinned') == 'true';
var width = parseInt(xmlChild.getAttribute('w'), 10);