CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-09 18:10:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2587 from BeksOmega/fixes/ImagesAndTextDropdown

Browse Source 
Fixed Rendering of Images & Text Dropdown
This commit is contained in:
alschmiedt
2019-06-24 17:19:58 -07:00
committed by GitHub
parent 55fc506782 b98eef2ae2
commit a8dc8359c5
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/field_dropdown.js
View File

@@ -456,6 +456,11 @@ Blockly.FieldDropdown.prototype.updateColour = function() {
* @private
*/
Blockly.FieldDropdown.prototype.render_ = function() {
// Hide both elements.
this.textContent_.nodeValue = '';
this.imageElement_.style.display = 'none';
// Show correct element.
if (this.imageJson_) {
this.renderSelectedImage_();
} else {
@@ -471,6 +476,7 @@ Blockly.FieldDropdown.prototype.render_ = function() {
* @private
*/
Blockly.FieldDropdown.prototype.renderSelectedImage_ = function() {
this.imageElement_.style.display = '';
this.imageElement_.setAttributeNS(
Blockly.utils.dom.XLINK_NS, 'xlink:href', this.imageJson_.src);
this.imageElement_.setAttribute('height', this.imageJson_.height);