Update todos so they are no longer in jsdocs (#3250) (#3257)

This commit is contained in:
alschmiedt
2019-10-15 10:14:39 -07:00
committed by GitHub
parent ef859d351d
commit a9420154a2
5 changed files with 8 additions and 6 deletions

View File

@@ -187,34 +187,34 @@ Blockly.BlockSvg.COLLAPSED_WARNING_ID = 'TEMP_COLLAPSED_WARNING_';
// Leftover UI constants from block_render_svg.js.
/**
* Vertical space between elements.
* TODO (#3142): Remove.
* @const
* @package
*/
// TODO (#3142): Remove.
Blockly.BlockSvg.SEP_SPACE_Y = 10;
/**
* Minimum height of a block.
* TODO (#3142): Remove.
* @const
* @package
*/
// TODO (#3142): Remove.
Blockly.BlockSvg.MIN_BLOCK_Y = 25;
/**
* Width of horizontal puzzle tab.
* TODO (#3142): Remove.
* @const
* @package
*/
// TODO (#3142): Remove.
Blockly.BlockSvg.TAB_WIDTH = 8;
/**
* Do blocks with no previous or output connections have a 'hat' on top?
* TODO (#3142): Remove.
* @const
* @package
*/
// TODO (#3142): Remove.
Blockly.BlockSvg.START_HAT = false;
/**

View File

@@ -446,9 +446,9 @@ Blockly.Gesture.prototype.startDraggingBlock_ = function() {
/**
* Create a bubble dragger and start dragging the selected bubble.
* TODO (fenichel): Possibly combine this and startDraggingBlock_.
* @private
*/
// TODO (fenichel): Possibly combine this and startDraggingBlock_.
Blockly.Gesture.prototype.startDraggingBubble_ = function() {
this.bubbleDragger_ = new Blockly.BubbleDragger(this.startBubble_,
this.startWorkspace_);

View File

@@ -185,9 +185,9 @@ Blockly.Icon.prototype.getIconLocation = function() {
* Get the size of the icon as used for rendering.
* This differs from the actual size of the icon, because it bulges slightly
* out of its row rather than increasing the height of its row.
* TODO (#2562): Remove getCorrectedSize.
* @return {!Blockly.utils.Size} Height and width.
*/
// TODO (#2562): Remove getCorrectedSize.
Blockly.Icon.prototype.getCorrectedSize = function() {
return new Blockly.utils.Size(
Blockly.Icon.prototype.SIZE, Blockly.Icon.prototype.SIZE - 2);

View File

@@ -459,6 +459,7 @@ Blockly.blockRendering.RenderInfo.prototype.getInRowSpacing_ = function(prev, ne
* should be placed.
* @protected
*/
// TODO: More cleanup.
Blockly.blockRendering.RenderInfo.prototype.computeBounds_ = function() {
var widestStatementRowFields = 0;
var blockWidth = 0;

View File

@@ -170,6 +170,7 @@ Blockly.blockRendering.Row.prototype.measure = function() {
* or null.
* @package
*/
// TODO: Consider moving this to InputRow, if possible.
Blockly.blockRendering.Row.prototype.getLastInput = function() {
for (var i = this.elements.length - 1, elem; (elem = this.elements[i]); i--) {
if (Blockly.blockRendering.Types.isInput(elem)) {