CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 17:40:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Create separate file for VariableMap and its functions.

Browse Source
This commit is contained in:
marisaleung
2017-05-02 14:55:35 -07:00
parent 2994805e6a
commit b159c7c3b5
3 changed files with 229 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

104
core/workspace.js
View File

@@ -76,13 +76,13 @@ Blockly.Workspace = function(opt_options) {
this.blockDB_ = Object.create(null);
/**
* @type {!Object<string, !Array.<Blockly.VariableModel>>}
* @type {!Blockly.VariableMap}
* A map from variable type to list of variable names. The lists contain all
* of the named variables in the workspace, including variables
* that are not currently in use.
* @private
*/
this.variableMap_ = {};
this.variableMap_ = new Blockly.VariableMap();
};
/**
@@ -195,7 +195,7 @@ Blockly.Workspace.prototype.clear = function() {
if (!existingGroup) {
Blockly.Events.setGroup(false);
}
this.variableMap_ = {};
this.variableMap_.clear();
};
/**
@@ -225,7 +225,7 @@ Blockly.Workspace.prototype.updateVariableStore = function(clear) {
}
}
if (clear) {
this.variableMap_ = {};
this.variableMap_.clear();
}
for (var i = 0, varDict; varDict = varList[i]; i++) {
if (!this.getVariable(varDict.name)) {
@@ -244,8 +244,6 @@ Blockly.Workspace.prototype.updateVariableStore = function(clear) {
Blockly.Workspace.prototype.renameVariableInternal_ = function(variable, newName) {
var newVariable = this.getVariable(newName);
var oldCase;
var variableIndex = -1;
var newVariableIndex = -1;
// If they are different types, throw an error.
if (variable && newVariable && variable.type != newVariable.type) {
@@ -253,17 +251,9 @@ Blockly.Workspace.prototype.renameVariableInternal_ = function(variable, newName
'" and variable "' + newName + '" is type "' + newVariable.type +
'". Both must be the same type.');
}
var type = (variable || newVariable || '').type;
var variableList = this.getVariablesOfType(type);
if (variable) {
variableIndex = variableList.indexOf(variable);
}
if (newVariable){
newVariableIndex = variableList.indexOf(newVariable);
}
// Find if newVariable case is different.
if (newVariableIndex != -1 && newVariable.name != newName) {
if (newVariable && newVariable.name != newName) {
oldCase = newVariable.name;
}
@@ -278,25 +268,7 @@ Blockly.Workspace.prototype.renameVariableInternal_ = function(variable, newName
}
Blockly.Events.setGroup(false);
if (variableIndex == -1 && newVariableIndex == -1) {
this.createVariable(newName, '');
console.log('Tried to rename an non-existent variable.');
}
else if (variableIndex == newVariableIndex ||
variableIndex != -1 && newVariableIndex == -1) {
// Only changing case, or renaming to a completely novel name.
if (oldCase) {
this.variableMap_[type][newVariableIndex].name = newName;
}
else {
this.variableMap_[type][variableIndex].name = newName;
}
} else if (variableIndex != -1 && newVariableIndex != -1) {
// Renaming one existing variable to another existing variable.
// The case might have changed, so we update the destination ID.
this.variableMap_[type][newVariableIndex].name = newName;
this.variableMap_[type].splice(variableIndex, 1);
}
this.variableMap_.renameVariable(variable, newName, oldCase);
};
@@ -335,24 +307,7 @@ Blockly.Workspace.prototype.renameVariableById = function(id, newName) {
* a UUID.
*/
Blockly.Workspace.prototype.createVariable = function(name, opt_type, opt_id) {
if (this.getVariable(name)) {
return;
}
if (opt_id && this.getVariableById(opt_id)) {
throw Error('Variable id, "' + opt_id + '", is already in use.');
}
opt_id = opt_id || Blockly.utils.genUid();
opt_type = opt_type || '';
var variable = new Blockly.VariableModel(name, opt_type, opt_id);
// If opt_type is not a key, create a new list.
if (!this.variableMap_[opt_type]) {
this.variableMap_[opt_type] = [variable];
}
// Else append the variable to the preexisting list.
else {
this.variableMap_[opt_type].push(variable);
}
this.variableMap_.createVariable(name, opt_type, opt_id);
};
/**
@@ -443,14 +398,7 @@ Blockly.Workspace.prototype.deleteVariableInternal_ = function(variable) {
}
Blockly.Events.setGroup(false);
var type = variable.type;
for (var i = 0, tempVar; tempVar = this.variableMap_[type][i]; i++) {
if (Blockly.Names.equals(tempVar.name, variable.name)) {
delete this.variableMap_[type][i];
this.variableMap_[type].splice(i, 1);
return;
}
}
this.variableMap_.deleteVariable(variable);
};
/**
@@ -474,16 +422,7 @@ Blockly.Workspace.prototype.variableIndexOf = function(name) {
* @return {?Blockly.VariableModel} the variable with the given name.
*/
Blockly.Workspace.prototype.getVariable = function(name) {
var keys = Object.keys(this.variableMap_);
for (var i = 0; i < keys.length; i++ ) {
var key = keys[i];
for (var j = 0, variable; variable = this.variableMap_[key][j]; j++) {
if (Blockly.Names.equals(variable.name, name)) {
return variable;
}
}
}
return null;
return this.variableMap_.getVariable(name);
};
/**
@@ -493,14 +432,7 @@ Blockly.Workspace.prototype.getVariable = function(name) {
* @return {?Blockly.VariableModel} The variable with the given id.
*/
Blockly.Workspace.prototype.getVariableById = function(id) {
for (var key of Object.keys(this.variableMap_)) {
for (var variable of this.variableMap_[key]) {
if (variable.getId() == id) {
return variable;
}
}
}
return null;
return this.variableMap_.getVariableById(id);
};
/**
@@ -646,12 +578,7 @@ Blockly.Workspace.prototype.allInputsFilled = function(opt_shadowBlocksAreFilled
* passed in type. An empty array if none are found.
*/
Blockly.Workspace.prototype.getVariablesOfType = function(type) {
type = type || '';
var variable_list = this.variableMap_[type];
if (variable_list) {
return variable_list;
}
return [];
return this.variableMap_.getVariablesOfType(type);
};
/**
@@ -659,7 +586,7 @@ Blockly.Workspace.prototype.getVariablesOfType = function(type) {
* @return {!Array.<string>} List of variable types.
*/
Blockly.Workspace.prototype.getVariableTypes = function() {
return Object.keys(this.variableMap_);
return this.variableMap_.getVariableTypes();
};
/**
@@ -667,12 +594,7 @@ Blockly.Workspace.prototype.getVariableTypes = function() {
* @return {!Array.<Blockly.VariableModel>} List of variable models.
*/
Blockly.Workspace.prototype.getAllVariables = function() {
var all_variables = [];
var keys = Object.keys(this.variableMap_);
for (var i = 0; i < keys.length; i++ ) {
all_variables = all_variables.concat(this.variableMap_[keys[i]]);
}
return all_variables;
return this.variableMap_.getAllVariables();
};
/**