Fix three new and ten existing Closure warnings.

Current count: 638
This commit is contained in:
Neil Fraser
2019-06-06 15:39:50 -07:00
committed by Neil Fraser
parent 42b4897f0e
commit cf91b82bb0
8 changed files with 19 additions and 15 deletions

View File

@@ -336,10 +336,10 @@ Blockly.Constants.Loops.CONTROL_FLOW_IN_LOOP_CHECK_MIXIN = {
/**
* Called whenever anything on the workspace changes.
* Add warning if this flow block is not nested inside a loop.
* @param {!Blockly.Events.Abstract} e Change event.
* @param {!Blockly.Events.Abstract} _e Change event.
* @this Blockly.Block
*/
onchange: function(/* e */) {
onchange: function(_e) {
if (!this.workspace.isDragging || this.workspace.isDragging()) {
return; // Don't change state at the start of a drag.
}

View File

@@ -1048,10 +1048,10 @@ Blockly.Blocks['procedures_ifreturn'] = {
/**
* Called whenever anything on the workspace changes.
* Add warning if this flow block is not nested inside a loop.
* @param {!Blockly.Events.Abstract} e Change event.
* @param {!Blockly.Events.Abstract} _e Change event.
* @this Blockly.Block
*/
onchange: function(/* e */) {
onchange: function(_e) {
if (!this.workspace.isDragging || this.workspace.isDragging()) {
return; // Don't change state at the start of a drag.
}

View File

@@ -142,7 +142,13 @@ Blockly.Constants.VariablesDynamic.CUSTOM_CONTEXT_MENU_VARIABLE_GETTER_SETTER_MI
}
}
},
onchange: function() {
/**
* Called whenever anything on the workspace changes.
* Set the connection type for this block.
* @param {!Blockly.Events.Abstract} _e Change event.
* @this Blockly.Block
*/
onchange: function(_e) {
var id = this.getFieldValue('VAR');
var variableModel = this.workspace.getVariableById(id);
if (this.type == 'variables_get_dynamic') {