CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-09 18:10:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2151 from mehdi-yeganeh/develop

Browse Source 
#1848 Fixed throw console warning when deleting workspace comments
This commit is contained in:
Rachel Fenichel
2018-12-05 09:55:57 -08:00
committed by GitHub
parent c08eadff6e a20af7e413
commit d016932ef7
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/workspace_comment_render_svg.js
View File

@@ -425,6 +425,7 @@ Blockly.WorkspaceCommentSvg.prototype.disposeInternal_ = function() {
this.foreignObject_ = null;
this.svgRectTarget_ = null;
this.svgHandleTarget_ = null;
this.disposed_ = true;
};
/**
@@ -436,6 +437,9 @@ Blockly.WorkspaceCommentSvg.prototype.setFocus = function() {
this.focused_ = true;
// Defer CSS changes.
setTimeout(function() {
if (comment.disposed_) {
return;
}
comment.textarea_.focus();
comment.addFocus();
Blockly.utils.addClass(
@@ -454,6 +458,10 @@ Blockly.WorkspaceCommentSvg.prototype.blurFocus = function() {
this.focused_ = false;
// Defer CSS changes.
setTimeout(function() {
if (comment.disposed_) {
return;
}
comment.textarea_.blur();
comment.removeFocus();
Blockly.utils.removeClass(