CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-05-31 00:10:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: Block labels should not use custom input labels (#9886)

Browse Source
This commit is contained in:
Michael Harvey
2026-05-18 11:14:46 -04:00
committed by GitHub
parent 4771cd473b
commit dd91830d72
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/blockly/core/block_svg.ts
+1 -1
View File
@@ -2021,7 +2021,7 @@ export class BlockSvg
aria.setState(
this.getFocusableElement(),
aria.State.LABEL,
computeAriaLabel(this),
this.getAriaLabel(aria.Verbosity.STANDARD),
);
configureAriaRole(this);
}
packages/blockly/tests/mocha/aria_test.js
+12
View File
@@ -504,6 +504,18 @@ suite('ARIA', function () {
assert.notInclude(label, 'input');
});
test('Blocks with custom input labels are properly labeled', function () {
const block = this.makeBlock('logic_negate');
const input = block.getInput('BOOL');
input.setAriaLabelProvider('condition');
const label = Blockly.utils.aria.getState(
block.getFocusableElement(),
Blockly.utils.aria.State.LABEL,
);
assert.include(label, 'not');
assert.notInclude(label, 'condition');
});
test('Blocks with one input are properly labeled', function () {
const block = this.makeBlock('logic_negate');
const label = Blockly.utils.aria.getState(