CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 00:50:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve flyout performance (#8571)

Browse Source 
* fix: improve flyout performance

* refactor: don't call position() in show()

The later call to reflow() itself winds up calling position(), so this calculation is redundant.
This commit is contained in:
Aaron Dodson
2024-09-11 12:37:32 -07:00
committed by GitHub
parent cb1c055bff
commit def80b3f31
1 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
core/flyout_base.ts
View File

@@ -402,7 +402,14 @@ export abstract class Flyout
this.wheel_,
),
);
this.filterWrapper = this.filterForCapacity.bind(this);
this.filterWrapper = (event) => {
if (
event.type === eventUtils.BLOCK_CREATE ||
event.type === eventUtils.BLOCK_DELETE
) {
this.filterForCapacity();
}
};
this.targetWorkspace.addChangeListener(this.filterWrapper);
// Dragging the flyout up and down.
@@ -704,10 +711,17 @@ export abstract class Flyout
this.filterForCapacity();
// Correctly position the flyout's scrollbar when it opens.
this.position();
this.reflowWrapper = this.reflow.bind(this);
// Listen for block change events, and reflow the flyout in response. This
// accommodates e.g. resizing a non-autoclosing flyout in response to the
// user typing long strings into fields on the blocks in the flyout.
this.reflowWrapper = (event) => {
if (
event.type === eventUtils.BLOCK_CHANGE ||
event.type === eventUtils.BLOCK_FIELD_INTERMEDIATE_CHANGE
) {
this.reflow();
}
};
this.workspace_.addChangeListener(this.reflowWrapper);
this.emptyRecycledBlocks();
}