CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-11 10:57:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Correct changedState in setWarningText() (#908)

Browse Source 
When clearing warnings on blocks with IDs, the changedState variable should be true if the text changed. This will trigger the block being reshaped and remove the space for the notification icon (this.bumpNeighbours_).
This commit is contained in:
Jim Mussared
2017-02-07 03:41:17 +11:00
committed by Andrew n marshall
parent 1a1646a5c4
commit ec878b02cd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/block_svg.js
View File

@@ -1510,7 +1510,7 @@ Blockly.BlockSvg.prototype.setWarningText = function(text, opt_id) {
if (!newText) {
this.warning.dispose();
}
changedState = oldText == newText;
changedState = oldText != newText;
}
}
if (changedState && this.rendered) {