Commit Graph

49 Commits

Author SHA1 Message Date
Aaron Dodson 1647a3299a fix: Move @alias onto classes instead of constructors (#6003)
* fix: Move @alias onto classes instead of constructors

* fix: Fix JSDoc for constructors.
2022-03-16 15:48:32 -07:00
Beka Westberg 237e66cf29 refactor: convert row.js and base.js to ES6 classes (#5957)
* fix: remove unnecessary properties from rows

* refactor: run conversion script on measurables

* clean: cleanup from conversion

* fix: make debug build happy

* clean: format

* fix: remove widthWithConnectedBlocks assignment on element

* fix: add inline docs for statementEdge
2022-02-25 11:06:12 -08:00
Rachel Fenichel 4cf1a5c886 refactor: convert some files to es classes (#5913)
* refactor: update workspace_comment and _svg to es classes

* refactor: update classes that extend icon to es classes

* refactor: update icon to es6 class

* refactor: update connection classes to es6 classes and add casts as needed

* refactor: update scrollbar to es6 class and add casts as needed

* refactor: update workspace_svg to es6 class

* refactor: update several files to es6 classes

* refactor: update several files to es6 classes

* refactor: update renderers/common/info.js to es6 class

* refactor: update several files to es6 classes

* chore: rebuild deps.js

* chore: run format
2022-02-04 10:58:22 -08:00
Rachel Fenichel 97c19be612 refactor: convert renderer measurables to es6 classes (#5899)
* chore: use casts to narrow types in renderers

* chore: add @struct and type information on common measurables

* refactor: update some renderer measurables to es6 classes

* refactor: convert many measurables to es6 classes

* chore: format

* chore: rebuild
2022-02-01 15:43:11 -08:00
Aaron Dodson 3851b14627 refactor: Migrate to named exports (#5623)
* refactor: Migrate to named exports

* fix: Sort requires

* fix: Remove duplicate deps
2021-10-20 15:53:23 -07:00
Neil Fraser 90b3f75d82 Remove @author tags (#5601)
Our files are up to a decade old, and have churned so much, that the initial author of the file no longer has much meaning.

Furthermore, this will encourage developers to post to the developer group, rather than emailing Googlers (usually me) directly.
2021-10-15 09:50:46 -07:00
Neil Fraser c929b3015b chore: Convert == to === and != to !== where possible. (#5599) 2021-10-15 09:17:04 -07:00
Monica Kozbial 49bc2b1ae4 Replace namespace annotation with class annotation in files that define a class (#5566) 2021-09-28 15:57:09 -07:00
Monica Kozbial d8fbe1b05b Add namespace and alias annotations to jsdoc (#5550)
* Add annotations to files under core/events

* Add annotations to files under core/interfaces

* Add annotations to files under core/keyboard_nav

* Add annotations to files under core/renderers

* Add annotations to files under core/serialization

* Add annotations to files under core/theme

* Add annotations to files under core/toolbox

* Add annotations to files under core/utils

* Add annotations to files under core
2021-09-27 14:42:54 -07:00
Aaron Dodson 6b07ccab96 chore: Remove declareLegacyNamespace from renderers (#5528)
* chore: Remove declareLegacyNamespace from Geras renderer

* chore: Remove declareLegacyNamespace from minimalist renderer

* chore: Remove declareLegacyNamespace from thrasos renderer

* chore: Remove declareLegacyNamespace from zelos renderer

* fix: Move debugger functionality out of Blockly.blockRendering to avoid dependency cycle when re-exporting submodules

* chore: Remove declareLegacyNamespace from Blockly.blockRendering.*
2021-09-24 08:33:35 -07:00
Rachel Fenichel 3adfaaf6d9 chore: named exports for block* files (#5512)
* chore: named export for block.js

* chore: named export for block_drag_surface.js

* chore: named export for block_dragger.js

* chore: named export for block_svg.js

* Fix import ordering

* chore: fix imports using requireType

* Remove extra require
2021-09-22 08:46:19 -07:00
Christopher Allen e7955084ae refactor: Remove remaining references to Blockly.* from goog.modules (#5505) 2021-09-21 17:51:35 +01:00
Christopher Allen 4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343)
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
kozbial a4a3b6a068 Migrate core/renderers/common/block_rendering.js to goog.module 2021-08-09 18:23:07 -07:00
Aaron Dodson 0e6258ca1a Migrated to inline exports 2021-07-21 08:17:13 -07:00
Rachel Fenichel 218046495f Sort requires 2021-07-16 13:12:05 -07:00
Rachel Fenichel d2142a2e9f Clang-format core/renderers/common/drawer.js and remove unused require 2021-07-16 11:00:50 -07:00
Rachel Fenichel f80764e153 Migrate core/renderers/common/drawer.js to named requires 2021-07-16 10:51:14 -07:00
Rachel Fenichel 94685bd8be Migrate core/renderers/common/drawer.js to goog.module 2021-07-16 09:52:32 -07:00
Rachel Fenichel b43b19c7a3 Migrate core/renderers/common/drawer.js to ES6 const/let 2021-07-15 14:38:16 -07:00
Neil Fraser cff7b359f4 Make comments more consistent. 2021-06-09 11:41:42 -07:00
Sam El-Husseini 63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Sam El-Husseini f97730e83c Sort requires (#4658)
* Cleanup gulp method to sort requires
2021-02-25 17:17:42 -08:00
Rachel Fenichel 107181d6f5 Missing requires, r through v 2021-02-17 14:52:06 -08:00
Rachel Fenichel b2052aeff4 Add requireTypes for renderers/common 2021-02-02 11:38:08 -08:00
Neil Fraser 4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Monica Kozbial 1afff3c439 Use baseline for positioning rendered connection. (#3609) 2020-01-16 16:07:38 -08:00
Sam El-Husseini fe555d9021 Rename input connection to connectionModel (#3571)
* Remove input measurable's connection property and rename references to connectionModel.
2020-01-09 18:09:15 -08:00
Sam El-Husseini 3d66eab311 [zelos] Output connection position (#3516)
* Move connection point for output connections to the left and centerline
2019-12-16 14:06:10 -08:00
Sam El-Husseini 337cb9c486 Fix path_object inheritance (#3403)
* Fix path_object inheritance, add zelos path_object
2019-11-05 16:36:30 -08:00
Sam El-Husseini 06b5bb1945 Might right corner support to common. Making it so there's always a right corner element, square by default. (#3311) 2019-10-23 21:58:43 -04:00
Neil Fraser b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Rachel Fenichel 0e1a4b68e1 Remove blockRendering.Debug, thrasos, and zelos from default requires.js 2019-09-27 12:01:06 -07:00
Monica Kozbial 21c5698e98 Moving DARK_PATH_OFFSET to geras only. (#3066)
* Moving DARK_PATH_OFFSET to geras.

* Adding compressed and uncompressed files.

* Adding missing newlines

* Reverting commit of messages.

* Reverting compressed files.

* Updating compressed files.

* Addressing PR comments.

* Removing unecessary input overrides.
2019-09-23 15:57:59 -07:00
Sam El-Husseini 57c8e3dded Rendering: Fix setting the path in RTL (#3047)
* Fix setting the RTL path.
2019-09-19 14:44:44 -07:00
Rachel Fenichel 77185906d8 Renderers define which paths a block has. (#2981)
* Move render elements into a path object.
2019-09-16 12:13:32 -07:00
Sam El-Husseini e339ae26bc Move the rendering object to live on the workspace_svg (#3016)
* Move the rendering object onto the workspace allowing the various workspaces to have different renderers.
2019-09-13 14:20:34 -07:00
Rachel Fenichel 4b17234cba Alphabetize requires 2019-09-10 13:01:13 -07:00
Sam El-Husseini 4c8e28c53d Dynamic output shapes (#2980)
* Round and triangle dynamic output shapes.
2019-09-06 13:04:01 -07:00
Rachel Fenichel e96acf476c Add dark path offset in geras info. 2019-09-05 16:55:56 -07:00
Rachel Fenichel e48c60fee6 Use strings instead of arrays for highlight paths 2019-09-05 15:48:46 -07:00
Rachel Fenichel 135ab7993e Use ascender/descender naming for top and bottom rows; tweak position calculation. 2019-09-04 16:26:53 -07:00
Sam El-Husseini 73d0b70c22 Add a spacer before and after a statement input and place use it to render a right corner before and after the statement input. (#2967) 2019-09-04 15:38:23 -07:00
Sam El-Husseini 189c561f49 Rendering type checker (#2950)
* Convert all rendering types to use a type enum flag.
2019-09-03 14:39:02 -07:00
Sam El-Husseini 96378f9183 Fix slight offset in statement input connection X location. (#2953)
* Fix slight offset in statement input connection X location.
2019-09-03 14:38:10 -07:00
Sam El-Husseini 06a882348b Render round right corners in zelos. (#2938)
* Render round right corners in zelos.
2019-08-30 18:11:01 -07:00
Rachel Fenichel 4dfb03adbf Make statement inputs store their actual width. (#2944)
* Make statement inputs store their actual width.
2019-08-30 17:55:51 -07:00
Rachel Fenichel c069316866 Debug configurability 2019-08-29 16:21:51 -07:00
Rachel Fenichel d28c5dd8be Rename rendering files and folders 2019-08-26 10:48:44 -07:00