d387841db2
Resolve remaining compiler warnings with visibility issues ( #3335 )
2019-10-24 19:13:51 -04:00
bfe62f98ca
Dispose makes the types we use inconsistent. Suppress checkTypes in dispose. ( #3336 )
2019-10-24 15:47:42 -04:00
52bef4463c
Fix warnings related to connections. ( #3306 )
...
* Fix warnings related to connections.
2019-10-23 17:56:52 -04:00
90ad0789f6
Fix 11 warnings related to variables and variable_model. ( #3278 )
...
* Fix 10 warnings related to variables and variable_model.
2019-10-22 14:26:59 -04:00
526528354f
Fix 10 warnings related to visibility ( #3275 )
2019-10-17 11:46:57 -05:00
cf04a9529b
Fix compilier warnings for keyboard nav ( #3196 )
...
* Fix compilier warnings for keyboard nav
2019-10-08 11:34:39 -07:00
80aac249ea
Make bumpNeighbours public. ( #3156 )
2019-10-03 19:31:55 -07:00
d0772ad496
Fix compiler warnings related to fields. ( #3144 )
...
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
7839512f0e
When collapsed, toString was referencing text_. Using getText instead. ( #3150 )
2019-10-03 15:26:41 -07:00
fba98fca5b
Move the dropdown field into the dropdown div. ( #3122 )
...
* Move the dropdown field into the dropdown div.
2019-10-03 14:35:28 -07:00
735a72c20a
mutation / compose fn annotations ( #3149 )
...
* Add compose / decompose type annotations.
2019-10-03 14:25:07 -07:00
b46a4fe286
Bring our license format up to date ( #3127 )
...
* Google changed from an Inc to an LLC.
This happened back in 2017 but we didn’t notice. Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.
* Remove project description/titles from licenses
This is no longer part of Google’s header requirements. Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).
* License no longer requires URL.
* Fix license regexps.
2019-10-02 14:46:56 -07:00
afbb2cca1e
Moved all database related code out of headless and into rendered.
2019-09-27 18:00:06 -07:00
4ed3295ad9
Make generator an optional module ( #3105 )
2019-09-27 10:47:10 -07:00
870824bc3e
Workspace theme ( #3093 )
...
* Move the theme object so it's on the workspace.
* Add support for subscribing UI elements to theme component styles and changes.
2019-09-26 16:52:17 -07:00
ddb04a3bc2
Partial code review of nav ( #3091 )
...
* Partial code review of nav
Had a few minutes free.
* Move getTopStackBlock to block
This is a generally useful function.
2019-09-26 10:19:40 -07:00
269f0dc381
Enable eslint rule spaced-comment
...
Fix up all remaining violations and turn the rule on.
2019-09-25 16:04:05 -07:00
e1e9513e86
Disconnect child block always for block.dispose(/* healStack */ true) ( #3073 )
...
* Disconnecting child block even if it cannot be connected to parent block.
* Bump disconnected child block.
* Added method for behavior on failed connection and updated expected behavior of unplug in unit tests.
* Removing obsolete TODO and calling new helper method in tests.
2019-09-25 10:47:29 -07:00
7653785ae6
Add missing require for utils.colour
...
Pushed without review since it’s activily breaking users (bug report filed from Blockly Games).
2019-09-21 08:40:56 -07:00
9e5df6216a
Fixed comment ownership. ( #2923 )
...
* Moved comment icons to use a model-based system. The block holds the model of the comment, and the comment icon holds a reference to it.
* Reorganized the setVisible function.
* Changed how xml.js serializes and deserializes comments.
2019-09-20 13:16:07 -07:00
a1e3973499
Make block comments an optional module. ( #3053 )
...
Measured as a 5 KB *increase* in code size, but that's because some other commit just landed between my tests. It's like running down an up escalator.
2019-09-19 14:53:28 -07:00
84a814cda1
Make mutator an optional module. ( #3048 )
2019-09-19 11:39:55 -07:00
8fae0411f7
Check if a type exists before testing instanceof ( #3031 )
...
* Check if a type exists before instance of
2019-09-17 16:28:18 -07:00
5650fe51a2
Typos.
2019-09-12 18:24:48 -07:00
e43e19d19a
Remove three functions deprecated in 2015
...
We’ve had four years of console warnings, and this next release is known to be breaking. Each is trivial to fix in code.
2019-09-12 18:04:45 -07:00
8ab51c8639
Remove closure base file dependency ( #2976 )
...
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
7bba4fa59c
Moves the cursor to correct location when block is deleted ( #2887 )
...
* Moves the cursor to correct location when block is deleted
* Moves cursor on block mutation
2019-08-21 16:33:16 -07:00
0872d022e1
Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires.
2019-08-16 09:57:28 -07:00
cdc90f4059
Refactored field utilities.
2019-08-16 09:57:27 -07:00
174fe53516
Minor jsdoc issue ( #2826 )
...
The JavaScript closure compiler barfs at this. No such thing as JSDOC @throw.
2019-08-14 14:40:54 -07:00
654467e9ac
Added disposed = false properties to fields, connections, and blocks. Changed applicable unit tests from isNotOk -> isFalse.
2019-08-07 07:17:41 -07:00
6f03634730
Moved disposed into finally block.
2019-08-07 07:11:17 -07:00
057cee51f8
Added disposed property to blocks (for use in unit tests).
2019-08-07 07:07:30 -07:00
8921fa96a9
Removed redundant connection disposal code from block.
2019-08-07 07:07:30 -07:00
45e5fb4157
More JSDoc and lint corrections
2019-07-30 17:00:40 -07:00
6aedfab4d1
Misc JSDoc fixes. ( #2747 )
2019-07-30 16:28:48 -07:00
3d813803ca
updateVariableName -> refreshVariableName
2019-07-26 12:55:43 -07:00
20837da54f
Deprecated field setText function.
2019-07-19 08:57:34 -07:00
f873ddb1c6
Added Field Tooltip Support to the JSON ( #2657 )
...
* Added support for setting a field's tooltip via JSON.
* Added a test block to the playground.
2019-07-18 12:21:37 -07:00
a9fdf7844a
Fix ordering of requires
...
Search and replace of a name strikes again.
2019-06-07 10:32:57 -07:00
d1a29739d8
Move utilities into own directory.
...
TODO: There are more functions which may be migrated into dom and string.
2019-06-07 10:32:57 -07:00
5bf7069a2f
Remove goog.math.Coordinate
2019-06-07 10:32:57 -07:00
069423e7cd
Remove last traces of goog.color.
2019-06-05 16:41:04 -07:00
ed9330cf57
Move Blockly.hueToRgb to Blockly.utils.colour
...
Also adds support for ‘#f00’, ‘rgb(255, 0, 0)’ and ‘red’ for block colours, in addition to ‘#ff0000’ (and of course hue).
2019-06-05 16:41:04 -07:00
dce0b77424
Fix 19 warnings in theme-related code. ( #2523 )
...
* Fix 19 warnings in theme-related code.
Resolves #2414
* Remove suppressPrefixSuffix property definition
The mixin code throws an error if property exists on both objects.
* eslint has strange ideas about indentation.
2019-05-30 10:05:06 -07:00
9f528922a7
Fix some dependencies
2019-05-24 15:45:05 -07:00
247aafae7e
Added updateColour to field.
2019-04-29 16:53:59 -07:00
1b10d134a5
Add Block.setEnabled ( #2386 )
...
* Implement Block.setEnabled()
From issue #1593 . This commit:
- add setEnabled
- deprecate setDisabled
* Update setDisabled calls to setEnabled
Add setEnabled and deprecate setDisabled in
- core/block_svg
Update calls in
- blocks/loops
- blocks/procedures
- core/block_events
- core/events
- core/flyout_base
- core/xml
- tests/workplace_svg/procedure_svg_test
* Implement changes from comments from RoboErikG
- Implement isEnabled()
- Make this.disabled @private
- Make setDisabled(disabled) call setEnabled(!disabled)
- Update setEnabled to use isEnabled()
* Utilize isEnabled() and fix typos
Fix missing parentheses
Implement isEnabled() more widely
Fix lint and parentheses errors
* Change prevDisabledState to prevEnabledState
2019-04-23 08:49:07 -07:00
1034ba835c
Adds check for a targetConnection
2019-04-02 14:42:41 -07:00
e9de083361
Fix @return JSDocs.
2019-03-29 15:24:37 -07:00
Sam El-Husseini
alschmiedt
Neil Fraser
Beka Westberg
Rachel Fenichel
Monica Kozbial
Sam El-Husseini
Jim Jiang