Commit Graph

3778 Commits

Author SHA1 Message Date
Rachel Fenichel 779be46a92 Allow variables of different types to share the same name. 2017-12-13 11:50:07 -08:00
duzc2dtw@gmail.com da429688f8 space between if and ( 2017-12-13 17:02:34 +08:00
duzc2dtw@gmail.com 26ea42c264 #1376 2017-12-09 20:41:43 +08:00
RoboErikG 0142aa0e94 Don't require flyouts to run Blockly (#1502)
* Don't require flyouts to run Blockly

There was a bug with Dynamic Variables that made them required for Blockly
to run. This adds checks so that the flyouts only get registered if they're
included. Also does a rebuild of core to pick up the fix.

* Also fix dependencies so dynamic vars don't get stripped
2017-12-08 14:18:09 -08:00
Tianwei Du 383f1d9bac Develop (#1501)
Adds missing requires in core/extensions
2017-12-08 10:49:35 -08:00
RoboErikG a83a625e3b Rebuild core and fix indents in field_variable.js (#1500)
After the addition of dynamic variables blockly_uncompressed needed
to be rebuilt for the playground. Also fixes some leftover missing
indents.
2017-12-08 10:46:20 -08:00
Tianwei Du 492462e1d4 Develop (#1481)
* variables_dynamic

* make test , and i18n

* Issue #1470

* Blockly.Constants.VariablesDynamic.CUSTOM_CONTEXT_MENU_VARIABLE_MUTATION
to make sure setCheck before event trigger

* Update built files from develop.

* fix copyright ,quotes , comments ,  and optimize some flow.

* quotes,change UI , change category custom name

* single setter , remove mutator , colour typo , typed variables create button message

* undo the indent edits.
2017-12-08 08:53:24 -08:00
Rachel Fenichel 7ef19b6851 Fix #1467 2017-12-06 17:00:22 -08:00
Rachel Fenichel 1d78d7be45 Merge pull request #1483 from DubeySandeep/ScrollableDropdowns
Added scrollable functionality to dropdown menu
2017-12-04 10:39:43 -08:00
picklesrus d1886572d0 Fix #1487 and only add the delete cursor if the block is not deletabl… (#1491)
* Fix #1487 and only add the delete cursor if the block is not deletable. Also add a grab cursor when it is not deletable so the cursor keeps the grab hand when over the toolbox.  This changes the toolbox api slightly, but the methods it touches are @package so it should be okay.
2017-12-04 10:36:47 -08:00
Sandeep Dubey 2dd8c1f669 Made the changes asked by the reviewer 2017-12-03 02:40:11 +05:30
Rachel Fenichel 222407c6ce Extract code for domToField_ 2017-11-30 12:08:01 -08:00
Rachel Fenichel d73337ad73 Extract fieldToDom into its own function 2017-11-30 11:24:57 -08:00
Karishma Chadha 143d95222c Fixing type annotation. 2017-11-22 15:22:34 -05:00
Karishma Chadha aae1b1bb74 Addressing PR comment. Moving functionality to get newly added variables into a helper function. 2017-11-22 14:51:11 -05:00
Karishma Chadha ee142e92bb Fixing comment style. 2017-11-22 13:43:25 -05:00
Karishma Chadha c950225897 Minor refactoring 2017-11-22 13:37:30 -05:00
Karishma Chadha 71205de2ef Target workspace is the one that carries the variables we want. VarCreate gets fired when a block with a new default variable is dragged out into the workspace. 2017-11-22 13:27:29 -05:00
Karishma Chadha 07d6624625 Fixing bug where VarCreate event does not fire when adding a block with pre-existing variables from the flyout into the workspace. 2017-11-22 12:50:00 -05:00
Rachel Fenichel 662757ab7d Switch to parentNode for IE 2017-11-20 16:50:21 -08:00
Rachel Fenichel 3b81eede3e Call forceRerender instead of setText 2017-11-17 14:39:12 -08:00
Sam El-Husseini ee7ad3dfef Fix right aligned Flyout buttons when workspace is scaled 2017-11-16 00:53:07 -08:00
Neil Fraser 5707657569 Stop blocks from exploding.
Uncompiled a goog.math.Coordinate toStrings as a nice “(1, 2)”, but
complied it toStrings as a useless “[object Object]”.  Fixes #1448.
2017-11-14 15:44:09 -08:00
Neil Fraser eb796b71de Prevent selection of toolbox categories. 2017-11-13 15:30:33 -08:00
Rachel Fenichel 13aa7bfb69 No-regex-spaces 2017-11-07 17:27:00 -08:00
Neil Fraser 8a398ab334 Add @package 2017-11-07 14:23:41 -08:00
Neil Fraser 3bf0418460 Right-align flyout buttons in RTL.
Fixes #1208.
2017-11-07 14:23:41 -08:00
Neil Fraser 8cedef49ac Cleanup. 2017-11-07 14:23:41 -08:00
Neil Fraser 7216c060bd Terminology: "background button" -> "mat"
Originally flyouts had ‘blocks’ and rectangular hidden ’buttons’
underneath the blocks.  When UI buttons were added to flyounts, there
was a terminology collision.  This change renames the original
background ‘buttons’ to ‘mats’.  As in placemats or door mats.
2017-11-07 14:23:41 -08:00
Rachel Fenichel f06aed4710 Fix text input widget position in RTL 2017-11-06 12:50:22 -08:00
Rachel Fenichel 30716fbd78 switch to variabletype everywhere 2017-11-03 16:03:32 -07:00
Rachel Fenichel a6457ef614 Get rid of highlighting when releasing the drag would delete instead of connecting 2017-11-03 15:47:15 -07:00
Rachel Fenichel 768bd4aef5 Check workspace.isDragging() instead of Blockly.dragMode_ 2017-11-03 15:46:41 -07:00
Rachel Fenichel 8c51935025 More lint for unused variables 2017-11-03 14:04:36 -07:00
Rachel Fenichel cd9be725c1 fix lint in field_angle.js 2017-11-02 16:37:09 -07:00
picklesrus e0f7862547 spacing changes 2017-11-02 14:05:29 -07:00
picklesrus de8d13eaa1 Fix lint errors so we can eventually run eslint on travis. 2017-11-02 14:05:29 -07:00
Neil Fraser 6635dada6d Allow external code to load new audio. (#1409)
If external code can ‘play’, it should be able to ‘load’.  Resolves
compile error in Blockly Games.  Feel free to push back if this API
shouldn’t be public.

Also fix compiler warnings on block defs.  ‘undefined’ means undefined, ‘=‘ means optional.
2017-11-01 17:47:24 -07:00
Neil Fraser 63637a927a Remove unnecessary restriction on variable names. 2017-11-01 12:08:53 -07:00
Evan W. Patton 67e192e208 Fix logic bugs related to e1e9427 (#1398)
This commit adds a fallback when attempting to merge events that
collide on a hash but do not actually merge. Previously, the latter
event would be dropped.

This also fixes a minor UX problem where moving the isNull check into
the merging loop resulted in extra events in the undo queue that
served no purpose and required multiple undo operations without visual
feedback.

Fixes #1373
2017-10-27 16:04:17 -07:00
Andrew n marshall 85f8a24ac8 Adding JSDoc for Blockly event fields (#1385)
Adding JSDoc for blockId, varId, workspaceId, group, and recordUndo
2017-10-25 12:26:24 -07:00
Neil Fraser 8779a8c3d9 Introduce minimap to style guide. 2017-10-24 14:06:29 -07:00
Neil Fraser e100c66659 Linting. 2017-10-24 14:06:29 -07:00
Neil Fraser 2445a752b7 Resolve another 20 warnings. 2017-10-24 14:06:29 -07:00
Neil Fraser 4262b09002 Resolve 106 warnings. 2017-10-24 14:06:29 -07:00
Andrew n marshall f992ea0f9c Fix #1369: resource loading order constraints, interpolation tokens in message expansion (PR #1383)
This fixes race condition in #1369 by using message references instead of explicit string lookups. This required fixing a bug the token interpolation parser that was breaking on the inner '"%1"' for these tooltips.
2017-10-24 13:02:14 -07:00
Rachel Fenichel 5a8ebef4b8 Move some context menu options into contextmenu.js (#1372) 2017-10-23 13:27:39 -07:00
Rachel Fenichel bd1d199058 Don't check typeof == undefined in variable deserialization (#1379) 2017-10-23 11:28:00 -07:00
Neil Fraser 631c978174 Fix typos. 2017-10-20 13:29:23 -07:00
Rachel Fenichel 236aadec3e Don't share the warning text PID map between blocks (#1371)
* Don't share the warning text PID map between blocks

* Clear pending warnings on dispose
2017-10-20 10:35:14 -07:00