9fa6b03789
Merge pull request #4925 from gonfunko/copy-paste
...
Prevent an error beep when copying blocks in Safari.
2021-06-16 11:16:51 -07:00
7a456a048b
Prevent an error beep when copying blocks in Safari.
2021-06-16 17:51:36 +00:00
a15bbf1700
Revert #4697 ( #4917 )
2021-06-16 09:36:39 -07:00
a46dbb37e7
Fixes workspace scroll bug ( #4921 )
2021-06-16 08:18:28 -07:00
672574b056
Require field name to be string, test changes
...
* Now throws error for getField/getFieldValue/setFieldValue if provided name is not a string
* Changed error to more specific TypeError
* Type checking and error message moved up to getField
* Tests added/modified to check that non-string types for field names produce type errors
2021-06-16 10:46:05 +01:00
62bb663b38
Added tests/setFieldValue error message
...
* Added tests for getting/setting field (values) when names are not supplied and test for getting a field value, setting it to a new value, and getting it again.
* Added more user-friendly error message for setFieldValue telling the developer that he/she is missing the name rather than Field "undefined" not found.
* Fixed lint error by removing trailing space
2021-06-16 10:46:05 +01:00
f9c5260fb0
Added tests/setFieldValue error message
...
* Added tests for getting/setting field (values) when names are not supplied and test for getting a field value, setting it to a new value, and getting it again.
* Added more user-friendly error message for setFieldValue telling the developer that he/she is missing the name rather than Field "undefined" not found.
2021-06-16 10:46:05 +01:00
ee8e282360
Fix #4830 for getting/setting unnamed fields
...
* Returns null when getting unnamed field (value), throws error Field "undefined" not found when attempting to set value of unnamed field
2021-06-16 10:46:05 +01:00
355c54f70a
Use captureWarning helper from dev-tools instead of mocha/test_helpers.js implementation.
2021-06-15 19:10:13 +00:00
e5a2df301a
Add msg files ( #4918 )
2021-06-15 11:27:36 -07:00
f9702deab0
Merge pull request #4911 from gonfunko/ipad-useragent
...
Updated user agent parsing to detect iPads posing as desktop Safari.
2021-06-15 08:33:01 -07:00
289d8ac857
Adjusted line wrapping.
2021-06-15 15:22:51 +00:00
0eef4f34f6
'navigator' may be renamed by the compiler.
...
Use quoted name instead. Also, navigator doesn't exist in Node, or non-browser environments.
2021-06-14 22:32:55 -07:00
c29afbcd27
Updated user agent parsing to detect iPads posing as desktop Safari.
2021-06-14 22:14:46 +00:00
8d8309e7e7
Merge pull request #4906 from gonfunko/test-suite
...
Use selenium-standalone-service to automatically start and stop Selenium when running the test suite.
2021-06-14 14:10:57 -07:00
ff34e067f8
Update positionable jsdoc ( #4908 )
2021-06-14 13:14:01 -07:00
65339377f4
Moved Typescript to devDependencies.
2021-06-14 19:40:41 +00:00
1931c31aa6
Update JsDoc for IDragTarget ( #4907 )
2021-06-14 12:19:36 -07:00
5cd2d375ef
Updated comment for runGeneratorsInBrowser to refer to Chrome instead of Firefox.
2021-06-14 19:06:28 +00:00
384e88add1
Merge branch 'test-suite' of https://github.com/gonfunko/blockly into test-suite
2021-06-14 11:54:35 -07:00
146840e09f
Updated CI config to run new simplified test target.
2021-06-14 18:54:13 +00:00
df7da795a3
Use selenium-standalone-service to automatically start and stop Selenium when running the test suite.
2021-06-14 11:52:49 -07:00
e65a396809
Revert removal of node v10 from build matrix.
2021-06-14 19:41:12 +01:00
f94cb15021
Re-disable CI on macOS
...
I have been unable to resolve the mocha test issues, so leave macOS
disabled for the moment.
2021-06-14 19:41:12 +01:00
f477db2251
Remove unneeded macOS setup
...
Chrome comes pre-installed on GitHub hosted macOS runners, and while
`Xvfb` does not seem to be installed neither does it seem to be needed.
2021-06-14 19:41:12 +01:00
ab33cd567a
Update test setup for GitHub Actions
...
- Do the (hopefully now) correct test to check we are on macOS.
- Fix brew command-line syntax for installing google-chrome.
2021-06-14 19:41:12 +01:00
5cc0df775d
Reenable CI on macOS
...
Working on fixing #2114 .
2021-06-14 19:41:12 +01:00
403f3119a6
Bump node.js versions for CI
...
Remove v12 and add v16, per https://nodejs.org/en/about/releases/
2021-06-14 19:41:12 +01:00
06352c0eea
Use selenium-standalone-service to automatically start and stop Selenium when running the test suite.
2021-06-14 17:27:01 +00:00
34fce2c1cb
Moves toolbox cursor styling out of block_dragger ( #4896 )
2021-06-11 18:02:40 -07:00
5a1533d1b0
Creates getLocationAfterMove in BlockDragger ( #4905 )
...
* Add getLocationAfterMove method to block dragger
* Renames and addresses comments
2021-06-11 17:32:27 -07:00
a17cb7f12e
Adding parameter to dragEnter and dragExit ( #4890 )
...
* introduce IDraggable interface
* Add parameter to drag methods in IDragTarget
* combines bubble/drag methods on IDragTarget and IDeleteArea to take an IDraggable element
2021-06-11 12:58:26 -07:00
fb170b9052
Remove extra space in generator error message.
2021-06-11 12:12:14 -07:00
8aeb78eff3
Revert bubble dragger logic change and helper name change ( #4897 )
...
* Revert accidental change in bubble drag logic
* Revert name change
2021-06-11 11:10:39 -07:00
73b06f14bb
Fix bug in Flyout getClientRect ( #4901 )
2021-06-11 11:10:22 -07:00
566b14e15f
Fixes block dragger after merge ( #4895 )
2021-06-10 16:54:33 -07:00
2005576036
Add onDragOver and wouldDelete_ to DeleteArea ( #4888 )
...
* keep track of state for whether the block or bubble would be deleted for use with drag enter exit
* Check if block and bubble is deletable in IDeleteArea
* Add to jsdoc of IDeleteArea
2021-06-10 16:27:04 -07:00
2c15a0dfb1
Merge pull request #4894 from maribethb/clone-coord
...
Add a clone method to Coordinate
2021-06-10 16:24:41 -07:00
777b3f46d6
use clone
2021-06-10 16:17:12 -07:00
e40093dc23
Add API to IDragTarget to prevent block move ( #4886 )
2021-06-10 16:17:07 -07:00
c4f04a7a7b
Merge branch 'develop' of github.com:google/blockly into clone-coord
2021-06-10 16:15:25 -07:00
f0143b6d6c
Add a clone method to Coordinate
2021-06-10 16:12:48 -07:00
0014ad3257
Add id to component interface ( #4887 )
2021-06-10 16:03:43 -07:00
9eaca6a1e1
Adds necessary methods for scroll-options plugin ( #4893 )
2021-06-10 15:50:42 -07:00
77dddca02e
Fix bug with updating cursor style in draggers ( #4889 )
2021-06-10 10:57:09 -07:00
d2579a7369
Add removeComponent to ComponentManager ( #4884 )
2021-06-09 22:29:33 -07:00
96315ad449
Fix removal of spaces near parens inside strings
...
Extra spaces should only be stripped from the inside of paren tokens. Parens in strings (and other static content) should not be edited.
2021-06-09 22:16:35 -07:00
d2c61d5735
Prevent uncessary add/remove class calls on cursor during drag ( #4885 )
2021-06-09 19:20:47 -07:00
11390341b1
Adding IDragTarget support. ( #4852 )
2021-06-09 13:59:22 -07:00
861a981cb6
Remove extra else clauses
2021-06-09 11:41:42 -07:00
Aaron Dodson
Monica Kozbial
alschmiedt
jschanker
Neil Fraser
Christopher Allen
Maribeth Bottorff
Neil Fraser