Commit Graph

222 Commits

Author SHA1 Message Date
Beka Westberg e2eaebec47 fix: convert the Workspace class to an ES6 class (#5977)
* fix: run conversion script on workspace

* fix: cleanup from conversion script

* fix: make debug build happy

* fix: tests

* fix: format

* fix: format
2022-03-16 13:22:03 -07:00
Beka Westberg fa14e9d6de refactor: convert blocksvg and block to ES6 classes (#5952)
* refact: move super call to top of block svg

* refact: run conversion script on block svg and block

* fix: make debug build happy

* fix: tests

* style: format

* fix: cleanup from rebase

* fix: use new.target instead of a new parameter

* fix: add more overridden casted methods to BlockSvg

* style: fix typos

* style: move override tags to the end of JSDoc

* fix: cleanup from rebase
2022-02-28 09:48:37 -08:00
Rachel Fenichel 4cf1a5c886 refactor: convert some files to es classes (#5913)
* refactor: update workspace_comment and _svg to es classes

* refactor: update classes that extend icon to es classes

* refactor: update icon to es6 class

* refactor: update connection classes to es6 classes and add casts as needed

* refactor: update scrollbar to es6 class and add casts as needed

* refactor: update workspace_svg to es6 class

* refactor: update several files to es6 classes

* refactor: update several files to es6 classes

* refactor: update renderers/common/info.js to es6 class

* refactor: update several files to es6 classes

* chore: rebuild deps.js

* chore: run format
2022-02-04 10:58:22 -08:00
alschmiedt 0f3c06306f chore: runs clang format on all files (#5627) 2021-10-21 15:22:24 -07:00
Aaron Dodson 3851b14627 refactor: Migrate to named exports (#5623)
* refactor: Migrate to named exports

* fix: Sort requires

* fix: Remove duplicate deps
2021-10-20 15:53:23 -07:00
Neil Fraser 90b3f75d82 Remove @author tags (#5601)
Our files are up to a decade old, and have churned so much, that the initial author of the file no longer has much meaning.

Furthermore, this will encourage developers to post to the developer group, rather than emailing Googlers (usually me) directly.
2021-10-15 09:50:46 -07:00
Neil Fraser c929b3015b chore: Convert == to === and != to !== where possible. (#5599) 2021-10-15 09:17:04 -07:00
Rachel Fenichel b25e24fd02 chore: Run clang-format on core/*.js (#5589)
* Run clang-format on core/*.js

* Revert changes for css formatting
2021-10-07 10:32:02 -07:00
Monica Kozbial d8fbe1b05b Add namespace and alias annotations to jsdoc (#5550)
* Add annotations to files under core/events

* Add annotations to files under core/interfaces

* Add annotations to files under core/keyboard_nav

* Add annotations to files under core/renderers

* Add annotations to files under core/serialization

* Add annotations to files under core/theme

* Add annotations to files under core/toolbox

* Add annotations to files under core/utils

* Add annotations to files under core
2021-09-27 14:42:54 -07:00
alschmiedt 2b34748e0e chore: remove declareLegacyNamespace from events (#5532)
- Adds an extra events/utils.js file to hold helper methods related to events.
2021-09-24 14:20:32 -07:00
Aaron Dodson e0693a65d2 chore: Remove declareLegacyNamespace() from files in core (#5525)
* chore: Remove declareLegacyNamespace() from files in core

* fix: Update missing/errant re-exports in blockly.js
2021-09-23 14:48:52 -07:00
Rachel Fenichel 3adfaaf6d9 chore: named exports for block* files (#5512)
* chore: named export for block.js

* chore: named export for block_drag_surface.js

* chore: named export for block_dragger.js

* chore: named export for block_svg.js

* Fix import ordering

* chore: fix imports using requireType

* Remove extra require
2021-09-22 08:46:19 -07:00
Aaron Dodson a3b52aaab3 Migrate core/events/events.js to goog.module syntax (#5302)
* Migrate core/events/events.js to ES6 const/let

* Migrate core/events/events.js to goog.module

* Migrate core/events/events.js to named requires

* clang-format core/events/events.js

* Migrate Blockly core to use getRecordUndo/setRecordUndo

* Update core/events.js to reflect latest guidance around exporting mutable fields
2021-08-26 08:53:31 -07:00
kozbial d1d8863fe8 Rename private methods in core/xml.js 2021-08-11 16:09:44 -07:00
kozbial 1d9371a3bc clang-format core/xml.js 2021-08-11 16:09:44 -07:00
kozbial 9666a3eb18 Migrate core/xml.js named requires 2021-08-11 16:09:44 -07:00
kozbial a64097d23f Migrate core/xml.js to goog.module 2021-08-11 16:09:44 -07:00
kozbial 66130e6668 Migrate core/xml.js to ES6 const/let 2021-08-11 16:09:44 -07:00
kozbial b834d9026b Add requireType calls for Blockly.WorkspaceComment and Blockly.WorkspaceCommentSvg 2021-08-06 18:05:53 -07:00
Rachel Fenichel cf7a8b95b8 Remove extra requires of Blockly.constants 2021-07-21 15:35:19 -07:00
Neil Fraser cff7b359f4 Make comments more consistent. 2021-06-09 11:41:42 -07:00
Neil Fraser e661c92a36 More JSDoc improvements 2021-05-27 21:30:26 -07:00
Neil Fraser f64c11d74e Make JSDoc object nullability more strict.
Also make Blockly.utils.deprecation.warn apply to properties.
2021-05-27 21:30:26 -07:00
Neil Fraser d919b0af21 Update JSDoc from Array.<> to Array<>
Same with Object.
2021-05-27 21:30:26 -07:00
Sam El-Husseini 63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Rachel Fenichel 750b62030b First pass at creating connectionTypes and inputTYpes 2021-03-04 10:22:24 -08:00
Sam El-Husseini f97730e83c Sort requires (#4658)
* Cleanup gulp method to sort requires
2021-02-25 17:17:42 -08:00
Sam El-Husseini ab8a11784d Fix event related missing requires (#4656)
* Fix event related missing requires
2021-02-25 14:28:11 -08:00
Rachel Fenichel f35aeb22b4 Remove circular dependency 2021-02-09 15:22:55 -08:00
Rachel Fenichel c449a3ec6c Fix missing requires in input and xml 2021-02-09 14:41:58 -08:00
Monica Kozbial c94f40d02b Connecting block to parent in domToBlockHeadless_ (#4461)
* Attaching parent before setting field values when processing xml
2021-01-20 09:48:37 -08:00
Monica Kozbial faf953b18b Process xml tags in an explicit order in domToBlockHeadless_ (#4571)
* Process xml tags in an explicit order in domToBlockHeadless_
2021-01-11 15:58:45 -08:00
Sam El-Husseini fba35d342c Add missing require Blockly.constants (#4366) 2020-10-12 17:56:42 -04:00
Monica Kozbial c6bea7c51b Call initsvg after loading field. (#4296) 2020-09-21 10:06:43 -07:00
alschmiedt 22d598484f Update blockToDom types to include document fragments (#4280) 2020-09-16 10:51:09 -07:00
Beka Westberg c732484180 Add programmatically setting shadows Take 2 (#4215)
* Add programmatically setting shadows
2020-09-08 08:50:01 -07:00
Rachel Fenichel 0951b5e613 Update eslintrc for eslint v7, and resolve new lint errors 2020-08-10 15:10:48 -07:00
Eric Anderson 2b8208b1e2 Perf: Move multiline xml text encoding out of domToText (#4046)
* Move multiline xml text encoding out of domToText
2020-07-14 16:32:12 -07:00
Sam El-Husseini c9563c1d24 Revert "Add programmatically setting shadows (#3902)"
This reverts commit 3aa1963be8.
2020-06-12 08:54:04 -07:00
Beka Westberg 3aa1963be8 Add programmatically setting shadows (#3902)
* Add programmatically setting shadows
2020-05-21 11:44:08 -07:00
Beka Westberg 44ba0226c9 Add ignoring insertion markers in xml gen (#3883)
* Add ignoring insertion markers in xml gen
2020-05-14 17:05:43 -07:00
Sam El-Husseini 493c89869e Rename dom Node enum (#3824)
* Rename Node enum to NodeType to avoid conflict with type Node
2020-04-15 15:54:36 -07:00
Neil Fraser 4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini 4a94dc8a85 Unpack self-closing tags when converting domToText (#3665)
* Unpack self-closing tags when converting domToText
2020-01-27 15:32:12 -08:00
Sam El-Husseini 671162b79a Fix RTL appendDomToWorkspace positioning. (#3601)
* Fix RTL appendDomToWorkspace positioning.
2020-01-16 13:43:41 -08:00
Sam El-Husseini 6c6296d74a Use setAttribute for setting the id instead of block.id as IE doesn't serialize the id otherwise. (#3604) 2020-01-16 13:33:24 -08:00
Rachel Fenichel 04ddb90680 Delete two leftover constants in block_svg. 2019-11-06 14:02:13 -08:00
Neil Fraser 123f436e04 Add parens around inline assignments (#3381) 2019-10-31 15:17:35 -07:00
Beka Westberg c32c835088 Fixed programmatically added connections not being added to the connection db (#3318)
* Fixed programmatically added connections not getting added to the connection db.
2019-10-29 15:31:40 -07:00
Sam El-Husseini 36d7e4ff8c Suppress workspace comment module not included while Workspace comments are not bundled in. (#3303) 2019-10-22 08:49:17 -04:00