Commit Graph

2110 Commits

Author SHA1 Message Date
Rachel Fenichel 078932a652 ignore more types of tests 2017-11-10 14:16:47 -08:00
Rachel Fenichel f4b7a8851f Eslint ignore svg-externs.js 2017-11-10 14:16:47 -08:00
Rachel Fenichel 75d0798e4a Run eslint on travis 2017-11-10 14:16:47 -08:00
Rachel Fenichel 13aa7bfb69 No-regex-spaces 2017-11-07 17:27:00 -08:00
Neil Fraser 8a398ab334 Add @package 2017-11-07 14:23:41 -08:00
Neil Fraser 3bf0418460 Right-align flyout buttons in RTL.
Fixes #1208.
2017-11-07 14:23:41 -08:00
Neil Fraser 8cedef49ac Cleanup. 2017-11-07 14:23:41 -08:00
Neil Fraser 7216c060bd Terminology: "background button" -> "mat"
Originally flyouts had ‘blocks’ and rectangular hidden ’buttons’
underneath the blocks.  When UI buttons were added to flyounts, there
was a terminology collision.  This change renames the original
background ‘buttons’ to ‘mats’.  As in placemats or door mats.
2017-11-07 14:23:41 -08:00
RoboErikG 53e6bddff5 Use msg references in block JSON for text_charat (#1426) 2017-11-06 13:05:09 -08:00
Rachel Fenichel f06aed4710 Fix text input widget position in RTL 2017-11-06 12:50:22 -08:00
Rachel Fenichel 66586bf622 Add a test for case-sensitivity in the variable names, ids, etc. in the flyout 2017-11-03 16:03:32 -07:00
Rachel Fenichel 30716fbd78 switch to variabletype everywhere 2017-11-03 16:03:32 -07:00
Rachel Fenichel a6457ef614 Get rid of highlighting when releasing the drag would delete instead of connecting 2017-11-03 15:47:15 -07:00
Rachel Fenichel 768bd4aef5 Check workspace.isDragging() instead of Blockly.dragMode_ 2017-11-03 15:46:41 -07:00
Rachel Fenichel 432881d2c1 Make quote images meet line length requirements 2017-11-03 14:04:36 -07:00
Rachel Fenichel 8c51935025 More lint for unused variables 2017-11-03 14:04:36 -07:00
Rachel Fenichel cd9be725c1 fix lint in field_angle.js 2017-11-02 16:37:09 -07:00
picklesrus e0f7862547 spacing changes 2017-11-02 14:05:29 -07:00
picklesrus de8d13eaa1 Fix lint errors so we can eventually run eslint on travis. 2017-11-02 14:05:29 -07:00
RoboErikG c4b2899007 Fix #1397 by being more careful with mutator (#1410)
* Fix #1397 by being more careful with mutator

The text_charAt mutator was replacing more of the title string than
necessary, which would lead to losing some of the relevant text in
the label. Updated the mutator to only add/remove a new input on the
end instead of replacing the default dummy input.

* Code cleanup
2017-11-02 09:37:31 -07:00
Neil Fraser 6635dada6d Allow external code to load new audio. (#1409)
If external code can ‘play’, it should be able to ‘load’.  Resolves
compile error in Blockly Games.  Feel free to push back if this API
shouldn’t be public.

Also fix compiler warnings on block defs.  ‘undefined’ means undefined, ‘=‘ means optional.
2017-11-01 17:47:24 -07:00
Neil Fraser 63637a927a Remove unnecessary restriction on variable names. 2017-11-01 12:08:53 -07:00
Neil Fraser 905d542ae5 Switch compile to HTTPS. 2017-10-27 17:44:54 -07:00
Neil Fraser 2ff345fa4e Adding PHP to comment.
And normalizing order of languages.
2017-10-27 17:44:54 -07:00
Neil Fraser d503e1c05b Reenable compressed builds. 2017-10-27 17:44:54 -07:00
Neil Fraser 7ec0862357 Restore Translations (#1396)
* Remove English from Tagalog.

* Resurrect translations for TEXT_INDEXOF_TITLE

* Resurrect translations for TEXT_APPEND_TITLE

* Resolve compile warnings.
2017-10-27 16:50:44 -07:00
Evan W. Patton 67e192e208 Fix logic bugs related to e1e9427 (#1398)
This commit adds a fallback when attempting to merge events that
collide on a hash but do not actually merge. Previously, the latter
event would be dropped.

This also fixes a minor UX problem where moving the isNull check into
the merging loop resulted in extra events in the undo queue that
served no purpose and required multiple undo operations without visual
feedback.

Fixes #1373
2017-10-27 16:04:17 -07:00
Andrew n marshall 722ef5f3e1 Updating the templates to minimize checkboxes and use HTML comments. (#1394) 2017-10-26 16:00:07 -07:00
Andrew n marshall ef14f0f306 Adding code removed in #1028 to fix regression #1386. (#1389)
Modifications to avoid matching %{key} notation.
2017-10-25 12:27:11 -07:00
Andrew n marshall 187c2c85dc Built pt.js from prior portuguese update. (#1387) 2017-10-25 12:26:41 -07:00
Andrew n marshall 85f8a24ac8 Adding JSDoc for Blockly event fields (#1385)
Adding JSDoc for blockId, varId, workspaceId, group, and recordUndo
2017-10-25 12:26:24 -07:00
Neil Fraser 43423f268e Fix code demo in IE if Blockly is compiled harder.
Closure should not be used except within core.
2017-10-24 17:31:38 -07:00
Neil Fraser 8779a8c3d9 Introduce minimap to style guide. 2017-10-24 14:06:29 -07:00
Neil Fraser e100c66659 Linting. 2017-10-24 14:06:29 -07:00
Neil Fraser 2445a752b7 Resolve another 20 warnings. 2017-10-24 14:06:29 -07:00
Neil Fraser 4262b09002 Resolve 106 warnings. 2017-10-24 14:06:29 -07:00
Andrew n marshall f992ea0f9c Fix #1369: resource loading order constraints, interpolation tokens in message expansion (PR #1383)
This fixes race condition in #1369 by using message references instead of explicit string lookups. This required fixing a bug the token interpolation parser that was breaking on the inner '"%1"' for these tooltips.
2017-10-24 13:02:14 -07:00
Rachel Fenichel 5a8ebef4b8 Move some context menu options into contextmenu.js (#1372) 2017-10-23 13:27:39 -07:00
Rachel Fenichel bd1d199058 Don't check typeof == undefined in variable deserialization (#1379) 2017-10-23 11:28:00 -07:00
RoboErikG 2514976e80 Fix typo in mixin name (#1375)
There was a typo in the name of the loop check mixin. Fixes the immediate issue though we should post a warning if trying to register a mixin that doesn't exist.
2017-10-20 15:18:19 -07:00
Neil Fraser 631c978174 Fix typos. 2017-10-20 13:29:23 -07:00
Rachel Fenichel 236aadec3e Don't share the warning text PID map between blocks (#1371)
* Don't share the warning text PID map between blocks

* Clear pending warnings on dispose
2017-10-20 10:35:14 -07:00
Rachel Fenichel 078b4fceb3 Revert some whitespace changes to appease eslint (#1370) 2017-10-19 16:08:54 -07:00
vicng c429bb12a9 Fixes bad Breton translation that misses positional specifier (#1353) 2017-10-17 16:42:43 -07:00
Nicole Parrot 97ce5b3e4f Fix indentation for function blocks with return statements (#1362)
* fix indentation for the return statement in function blocks that return a value

* Fix hard-coded autoindent, and swap it for Blockly.PHP.INDENT

* Fix hard-coded 2 spaces indent and use language-appropriate global indent
2017-10-17 15:20:11 -07:00
Neil Fraser 5c00256e96 Style improvements. No functional changes. (#1367) 2017-10-17 15:19:50 -07:00
Paul Kaplan 075bda45a5 Block rendering performance (#1363)
* Use Blockly.Field.getCachedWidth instead of non-caching method

* Check for timeout pid before calling clearTimeout
2017-10-13 14:08:52 -07:00
Neil Fraser 82705923cb Convert compile demo into a unit test. (#1360)
* Intentionally break Travis.

* Alphabetize tests, remove orphaned test, and add fail to test that's running.

* Unbreak test, disable OS X, move scripts, list compiler directory.

* Test Java, break test.

* Unbreak test, call compile script.

* Compile main_compressed.js

* Run test command using bash.

* Fix path.

* Exclude node modules.

* Be more specific about JS files to compile.

* Test failure.

* Restore OSX, undo Blockly failure, remove compilation demo, add compilation test.

* Delete manual test files.

* Ignore downloaded/generated files.

* Whitespace cleanup.
2017-10-12 14:54:57 -07:00
Nicole Parrot 4df6f11f8a Do not assume an indentation of 2 spaces when writing the global variables at the top of a function declaration. (#1356) 2017-10-10 16:06:40 -07:00
Andrew n marshall fb774c9b67 Correct bad portuguese translation. (#1349)
This is identical to the Brazilian Portugues message, verified by two native Portuguese.
2017-10-04 13:47:56 -07:00