Commit Graph

532 Commits

Author SHA1 Message Date
Rachel Fenichel
04a77f0ef2 Fix some compiler warnings 2019-08-16 17:05:24 -07:00
kozbial
41e6167334 Fixing basic warnings in block_render_draw_debug. 2019-08-16 11:51:24 -07:00
kozbial
ca357aa71f Cleaning up some warnings in block_render_draw.js. 2019-08-15 16:16:26 -07:00
Rachel Fenichel
a01d1eb5bc Merge pull request #2825 from rachel-fenichel/block_widths
Correctly calculate widths of blocks with children on external inputs.
2019-08-15 14:35:15 -07:00
Rachel Fenichel
26e9348b07 Center some fields and inputs vertically 2019-08-15 11:06:05 -07:00
kozbial
c4165e92b8 Prevent incorrectly drawing vertical line for zero height spacer rows. 2019-08-14 16:16:48 -07:00
Rachel Fenichel
7b5e6eee63 Correctly calculate widths of blocks with children on external inputs. 2019-08-14 14:09:20 -07:00
kozbial
a476564fa2 Fixing width computation and start x for statement input draw. 2019-08-14 11:34:32 -07:00
kozbial
d921c4ff47 Using statement input xPos instead of statementEdge. 2019-08-13 18:01:24 -07:00
kozbial
2d30ed2e9c Update statementInput width to reflect what is actually being rendered. 2019-08-13 17:35:04 -07:00
Monica Kozbial
b0098f7817 Merge pull request #2810 from moniika/moniika-debug-rect
Adding missing padding to statement input rows.
2019-08-13 17:32:04 -07:00
kozbial
95163f30de Minor refactor in alignRowElements currentWidth and desiredWidth computation. 2019-08-13 17:15:50 -07:00
Rachel Fenichel
39b3717b2c Include next connection in block's bounding box 2019-08-13 15:23:27 -07:00
Rachel Fenichel
f449c8bb3c Remove commented out code 2019-08-13 14:32:03 -07:00
Rachel Fenichel
4f487c65f0 Fix hat 2019-08-13 14:26:22 -07:00
Rachel Fenichel
6b440cc5e0 Replace path array with path string 2019-08-13 14:17:51 -07:00
kozbial
99c970bcf5 Adding missing padding to statement input rows. 2019-08-13 13:32:03 -07:00
Rachel Fenichel
71e720444f Use connection width to find empty input width 2019-08-13 10:16:29 -07:00
Rachel Fenichel
d954182c41 Fix width with children for external inputs 2019-08-13 10:16:29 -07:00
Rachel Fenichel
ede7c7e125 Include tab width in block width 2019-08-13 10:16:29 -07:00
Rachel Fenichel
5b955f6bbe Add xpos to rows; add bounding box debug rendering 2019-08-13 10:16:29 -07:00
Rachel Fenichel
6e825c33a0 Centralize references to some shapes. 2019-08-13 10:16:29 -07:00
Rachel Fenichel
797b8dae46 Include tab width in block width 2019-08-13 10:14:33 -07:00
Rachel Fenichel
ace1971795 Make hats have height! 2019-08-13 10:14:33 -07:00
Rachel Fenichel
eb19ea970a Hats 2019-08-13 10:14:33 -07:00
Rachel Fenichel
caec821fec Cleanup 2019-08-13 10:14:33 -07:00
Rachel Fenichel
67d6a2f4f8 Cleanup 2019-08-13 10:14:33 -07:00
Rachel Fenichel
c901b20486 Handle negative x and y origin 2019-08-13 10:14:33 -07:00
Rachel Fenichel
74238d6e24 Works for positive x and y offsets; fails for negative 2019-08-13 10:14:33 -07:00
Rachel Fenichel
da391da005 Improvements for y offsets 2019-08-13 10:14:33 -07:00
Rachel Fenichel
7ecb841d8c Merge pull request #2804 from rachel-fenichel/variables_not_constants
Centralize references to puzzle tab and notch in measurables.js
2019-08-13 09:47:10 -07:00
Rachel Fenichel
61d03ba249 Add debug rendering that shows the bounding box of the block 2019-08-12 16:09:19 -07:00
Rachel Fenichel
23bddeaaa9 Centralize references to puzzle tab and notch in measurables.js 2019-08-12 16:03:42 -07:00
kozbial
a47177af28 fixing spacing 2019-08-07 12:24:09 -07:00
kozbial
11813c706c Remove flipRtl path for icon. 2019-08-07 12:20:15 -07:00
kozbial
d4b12343d6 Adding logic to flip FieldImages in RTL with flipRtl flag set. 2019-08-06 14:43:18 -07:00
Rachel Fenichel
5deedc8f53 Merge pull request #2783 from rachel-fenichel/field_corrected_size
Remove getCorrectedSize for fields
2019-08-06 13:45:44 -07:00
Rachel Fenichel
ed245a3c9e Remove dealWithOffsetFields 2019-08-06 11:44:03 -07:00
Rachel Fenichel
3802a0c960 Remove getCorrectedSize for fields 2019-08-05 16:01:50 -07:00
kozbial
2ece7a7c53 Refactoring to pass boolean isRtl rather than whole RenderInfo object for debug render helper methods. 2019-08-05 14:08:26 -07:00
kozbial
5208ddfc03 Updating debug rendering for RTL blocks. 2019-08-05 14:08:26 -07:00
Monica Kozbial
3c0bfa17c3 Merge branch 'develop' into moniika-render-collapsed 2019-08-02 14:38:47 -07:00
kozbial
eb3cb76300 Addressing PR comment. 2019-08-02 14:16:52 -07:00
Neil Fraser
939bbd072b Lint 2019-08-02 11:00:40 -07:00
kozbial
9ba91980e5 Addressing PR comments and refactoring path constants. 2019-08-01 13:01:57 -07:00
kozbial
3a983c53e1 Reverting extra files touched by eslint. 2019-08-01 11:42:00 -07:00
kozbial
c6b0d961a1 Running eslint on modified files. 2019-08-01 11:33:27 -07:00
kozbial
b1d86a57aa Updating logic to handle rendering collapsed blocks. 2019-08-01 11:29:55 -07:00
kozbial
e2f12f8262 Fixing edge case for centerline computation for bottom row elements. 2019-07-31 20:12:51 -07:00
Rachel Fenichel
5294d0ab71 Merge pull request #2753 from rachel-fenichel/remove_console_spam
Remove logs from rendering
2019-07-31 15:55:03 -07:00