Commit Graph

2336 Commits

Author SHA1 Message Date
Rachel Fenichel
1fa27fa043 Update comments and remove unused functions 2018-01-12 12:03:28 -08:00
Rachel Fenichel
80b397f532 Respond to more review comments 2018-01-10 17:27:43 -08:00
Rachel Fenichel
a43b0e7010 Respond to commit comments and make compressed blockly work again 2018-01-10 17:02:02 -08:00
Rachel Fenichel
bd4e4daebb Update comments and use try/catch with setGroup. 2018-01-09 13:31:13 -08:00
Rachel Fenichel
30f7c915d7 Merge pull request #1530 from rachel-fenichel/bugfix/nits
Remove some TODOs; add a variable-referencing block to the simple playground flyout
2018-01-08 14:36:13 -08:00
Rachel Fenichel
5d6d7519cd Remove some TODOs; add a variable-referencing block to the simple playground flyout 2018-01-08 14:14:26 -08:00
Rachel Fenichel
a49a148732 Merge pull request #1525 from rachel-fenichel/bugfix/variables_procedures
Use variable IDs for procedure arguments
2018-01-05 16:43:39 -08:00
Rachel Fenichel
ea6bf607fa Add displayRenamedVar to procedures_defnoreturn 2018-01-04 16:38:36 -08:00
Rachel Fenichel
832dae009e Cleanup 2018-01-04 16:32:23 -08:00
Rachel Fenichel
77cf3ddc33 Track variable IDs for procedure arguments 2018-01-04 16:16:12 -08:00
Rachel Fenichel
b342fb2121 Fix problem with clearing flyout after a variable was deleted. 2018-01-02 16:42:28 -08:00
Rachel Fenichel
9b091a8f9e Update procedure generators 2018-01-02 16:27:17 -08:00
Rachel Fenichel
b22c18fb27 Merge pull request #1522 from rachel-fenichel/bugfix/variables_procedures
Fix generator tests
2017-12-21 10:55:27 -08:00
Rachel Fenichel
24cf1cf7dd Remove TODO and get rid of unnecessary wrapper call. 2017-12-21 10:54:54 -08:00
Rachel Fenichel
e4e389bd60 Add documentation 2017-12-20 16:33:44 -08:00
Rachel Fenichel
0a0b6f3848 Add error; python and php tests pass. 2017-12-20 16:28:14 -08:00
Rachel Fenichel
fced496d28 Lua generator tests pass with new variables 2017-12-20 15:23:05 -08:00
Rachel Fenichel
3d0567fe46 JS and Dart generator tests pass 2017-12-20 15:14:37 -08:00
Rachel Fenichel
04fa9faadd Merge pull request #1520 from rachel-fenichel/feature/variables_headless
Fix headless
2017-12-19 16:53:51 -08:00
Rachel Fenichel
d69519bdab Fix headless 2017-12-19 16:10:07 -08:00
Rachel Fenichel
c113d5c785 Merge pull request #1519 from rachel-fenichel/feature/variables_headless
Create variables when blocks are created directly (not from XML)
2017-12-19 15:46:55 -08:00
Rachel Fenichel
4cd0b36944 Fix event ordering for variables created from XML implicitly 2017-12-19 14:25:52 -08:00
Rachel Fenichel
6218750207 Fix events for variable fields on new blocks; fix tests 2017-12-19 11:28:23 -08:00
Rachel Fenichel
3e56e6f8f2 Merge pull request #1518 from rachel-fenichel/feature/move_variable_map
Move all variable functionality into the variable map.
2017-12-15 16:08:50 -08:00
Rachel Fenichel
db9a9f5182 Move code from the variable to the variable map. Fixes #1512. 2017-12-15 15:31:41 -08:00
Rachel Fenichel
792ada63dc Merge branch 'variables_by_id' of https://github.com/google/blockly into variables_by_id 2017-12-15 14:56:32 -08:00
Rachel Fenichel
9593a90cc0 Merge pull request #1517 from rachel-fenichel/rebase_variables_by_id
Merge develop into variables_by_id
2017-12-15 14:33:32 -08:00
Rachel Fenichel
df1d5ba525 fix tests 2017-12-15 14:07:17 -08:00
Rachel Fenichel
66975c8f94 Rebase 2017-12-15 13:44:27 -08:00
Rachel Fenichel
a75ab878af Fix html escaping and flyouts opening 2017-12-13 11:50:08 -08:00
Rachel Fenichel
e77b498504 Respond to review comments in variable_map 2017-12-13 11:50:08 -08:00
Rachel Fenichel
f0b7190603 Clean up TODOs and move potential variable map to the flyout workspace 2017-12-13 11:50:08 -08:00
Rachel Fenichel
b60e70497a Avoid spurious rename event 2017-12-13 11:50:08 -08:00
Rachel Fenichel
5047b00e27 Fix missing events for variable creation 2017-12-13 11:50:08 -08:00
Rachel Fenichel
7e411b5428 Fix checkmarks when the variable dropdown is open. 2017-12-13 11:50:08 -08:00
Rachel Fenichel
be4054b593 Tests 2017-12-13 11:50:08 -08:00
Rachel Fenichel
399f1a5c11 Tests 2017-12-13 11:50:08 -08:00
Rachel Fenichel
279cf83b72 Fix events for variable renaming 2017-12-13 11:50:08 -08:00
Rachel Fenichel
24672bcbb2 Remove ws.updateVariableStore and tests, and ws.getVariableUses 2017-12-13 11:50:08 -08:00
Rachel Fenichel
61db23c78a Get rid of workspace.deleteVariable 2017-12-13 11:50:08 -08:00
Rachel Fenichel
1ce46ab88b Move getOrCreateVariable to variables.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel
f37386d2bf Fix default variable name 2017-12-13 11:50:07 -08:00
Rachel Fenichel
3ae7ac1cd4 Make unique variable names in the flyout 2017-12-13 11:50:07 -08:00
Rachel Fenichel
523a10413b All tests pass 2017-12-13 11:50:07 -08:00
Rachel Fenichel
19939dc16a All but XML tests now pass 2017-12-13 11:50:07 -08:00
Rachel Fenichel
4d76f2948c Move code from renameVariableInternal to renameVariableById 2017-12-13 11:50:07 -08:00
Rachel Fenichel
3728cfed45 Update tests in workspace_test. Get rid of renameVariable 2017-12-13 11:50:07 -08:00
Rachel Fenichel
6974208fa3 Fix variable_map_test and variable_model_test 2017-12-13 11:50:07 -08:00
Rachel Fenichel
c55b6afc6f Fix tests in field_variable_test.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel
012ba022c8 Delete by id 2017-12-13 11:50:07 -08:00