Commit Graph

360 Commits

Author SHA1 Message Date
Sam El-Husseini
1052f7548b Enable unusedPrivateMembers check (#3924)
* Add unusedPrivateMembers check
2020-05-28 17:44:16 -07:00
Sam El-Husseini
acfc335870 Type fixes for Dropdown / Widget divs (#3911)
* Stricter typechecks in dropdown and widget div
2020-05-28 08:42:26 -07:00
Bluefox
6f3e27cf16 Do not add COLLAPSED_WARNINGS_WARNING by deleting of warning
If some block tries to remove warning with `block.setWarningText(null, block.id)` in collapsed state, the warning will be shown anyway.
2020-05-25 11:40:59 +02:00
Sam El-Husseini
317834ff59 Add accessibility interfaces and fix navigation types (#3908)
* Add accessibility interfaces and fix navigation types
2020-05-21 11:18:10 -07:00
Sam El-Husseini
6809f63555 Rename bounding box to bounded element (#3909) 2020-05-20 11:21:26 -07:00
Sam El-Husseini
fd916fdb9b Bounding Box interface (#3906)
* Add an interface describing a bounding box registered on the workspace

* Clear the bounding box array

* PR comments

* Update chromedriver
2020-05-19 18:06:11 -07:00
Maribeth Bottorff
781dbd974d Make block.removeInput return a boolean. (#3832)
Make block.removeInput return a boolean.
2020-04-17 17:47:58 -07:00
Sam El-Husseini
4b20383831 Add Selectable interface (#3823)
* Add I Selectable interface
2020-04-16 18:22:32 -07:00
Beka Westberg
9e98df9949 Fix collapsed blocks not updating when modified (#3806)
* Stop recursive render calls

* Fix visibility bugs.

* Make toString ignore collapsed input.

* Add automatic collapse rendering handling

* Fix insertion markers with collapsed

* Add tests

* Fix build?

* PR comments

* Add missing jsdoc
2020-04-16 13:02:05 -07:00
Monica Kozbial
a9223b0b22 Typo fixes. (#3769) 2020-03-25 15:47:27 -07:00
Sam El-Husseini
7e1f81cf11 Insertion marker properties in theme (#3752)
* Pipe inseriton marker colour and opacity from theme
2020-03-18 10:15:30 -07:00
Sam El-Husseini
14428a0da4 Fix two memory leaks (#3747)
* Fix two memory leaks
2020-03-13 14:49:08 -07:00
Sam El-Husseini
5db1574852 Move cursor on tab if we're in keyboard nav mode. (#3738) 2020-03-12 09:42:19 -07:00
Sam El-Husseini
29dc7bd7f7 Adjust marker and cursor colours from the theme (#3735)
* Support adjusting marker and cursor colours from the theme
2020-03-11 11:23:29 -07:00
Sam El-Husseini
13ac939b91 Support passing renderer overrides in options (#3734)
* Support passing in renderer options through workspace options.
2020-03-10 18:36:29 -07:00
Sam El-Husseini
8c5c33902b Flash on render (#3721)
* Flash a block when it's renderered in debug mode
2020-03-05 13:26:10 -08:00
Beka Westberg
392d25eb39 fix: Break breaking undo. 2020-02-18 16:01:18 -08:00
alschmiedt
0c60c119a2 Update to use knew variable (#3694) 2020-02-17 14:08:27 -08:00
Neil Fraser
4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
alschmiedt
513e85bf4a Checks keyboardAccessibility flag before rendering (#3671) 2020-01-30 14:11:47 -08:00
Beka Westberg
025d087e6a fix: Fixed insertion preview logic. And fixed markers not handling typed statements. (#3526)
* Added planned functions.

* Added default getConnectionPreviewMethod method.

* Moved show preview logic into their new functions.

* Fixed default getConnectinPreviewMethod logic.

* Reverted to lastConnectionInRow call (for output connections) for behavioral backwards-compat.

* Added zelos logic.

* Removed unused functions, and added docs.
2020-01-24 07:49:31 -08:00
alschmiedt
130297f795 Add colour methods back to blockSvg (#3626)
* Add colour methods back to blockSvg
2020-01-22 07:34:46 -08:00
Monica Kozbial
8f787a3e41 Re-rendering block in setMutator. (#3574) 2020-01-13 10:32:22 -08:00
Monica Kozbial
26db9167db Move of render contant START_HAT into ConstantProvider. (#3563)
* Move of render contant START_HAT into ConstantProvider.
2020-01-07 16:18:05 -08:00
Monica Kozbial
835a6120a2 Removing leftover constant MIN_BLOCK_Y in BlockSvg. (#3552) 2020-01-06 16:34:51 -08:00
Sam El-Husseini
55997784ca Move blockStyles into constants (#3485)
* Move blockStyles into constants.
2019-12-06 10:51:36 -08:00
Sam El-Husseini
917f58ab0f Fix bugs with apply colour (#3483) 2019-12-03 13:22:41 -08:00
Sam El-Husseini
f4431b3361 [Zelos] apply Colour (#3465)
* Only apply colour from a single entry point. Zelos rendering apply colour
2019-11-25 14:18:10 -08:00
Sam El-Husseini
2f87243466 Fix bug with tabbing out of Blockly (#3470)
* Pipe handled cursor action correctly.
2019-11-22 17:30:25 -08:00
Sam El-Husseini
2a8e7d9ac8 [zelos] Full field colour (#3461)
* Support showing the colour value on the entire block.
2019-11-22 13:50:33 -08:00
Sam El-Husseini
3c120f9d46 Highlight input shape in Zelos (#3444)
* Highlight shape for input in zelos rendering
2019-11-15 13:14:39 -08:00
alschmiedt
564af764d0 Cursor renderer (#3440)
* Initial commit for adding the cursor to renderer
2019-11-14 13:36:29 -08:00
Sam El-Husseini
f9dcb60f82 Zelos replacement highlight (#3431)
* Zelos replacement highlight
2019-11-13 17:14:28 -08:00
Rachel Fenichel
6dd07ec44d Move cursorSvg and markerSvg to pathObject 2019-11-13 11:23:10 -08:00
Neil Fraser
a15d9611d0 Add missing requires. 2019-11-12 13:15:06 -08:00
Rachel Fenichel
067fbb4488 Move highlightForReplacement into the path object as well. 2019-11-11 15:17:26 -08:00
alschmiedt
b7b262efd5 Action update (#3389)
Make it easier for users to create new shortcuts
2019-11-08 13:51:22 -08:00
Rachel Fenichel
04ddb90680 Delete two leftover constants in block_svg. 2019-11-06 14:02:13 -08:00
Rachel Fenichel
e71366259c Move lots of update style functions from block_svg to path_object 2019-11-05 17:15:26 -08:00
Rachel Fenichel
88a317899b Merge pull request #3388 from rachel-fenichel/defs
Move filters and patterns into constants
2019-11-01 15:57:05 -07:00
Rachel Fenichel
13e4d671c3 Moved setHighlighted and setDisabled into the path object. 2019-11-01 14:28:51 -07:00
Rachel Fenichel
46f323971a Move filter and pattern creation from inject into constants. 2019-11-01 13:32:17 -07:00
Neil Fraser
22c1eba546 Make warnings an optional module. 2019-11-01 11:52:12 -07:00
Neil Fraser
123f436e04 Add parens around inline assignments (#3381) 2019-10-31 15:17:35 -07:00
Rachel Fenichel
5634ff5de0 Remove extra annotation 2019-10-30 16:07:41 -07:00
Rachel Fenichel
46fad66ab1 Review feedback. 2019-10-30 15:58:53 -07:00
Rachel Fenichel
5ef08fc0d4 Switch to using the style object in the path object. 2019-10-30 14:47:23 -07:00
Rachel Fenichel
ca1e49bf8e Fields now go through blockSvg for colours. 2019-10-30 14:43:42 -07:00
Rachel Fenichel
ecef3467fd Colourer/path_object cleanup 2019-10-30 14:42:13 -07:00
Rachel Fenichel
6f520335ea Cleanup of colouring code, and move it into path_object. 2019-10-30 14:42:13 -07:00