Commit Graph

3407 Commits

Author SHA1 Message Date
Beka Westberg
354d402c49 Refactored field.init into field.initView and field.initModel 2019-05-03 07:12:46 -07:00
Rachel Fenichel
12a769b9c4 Merge pull request #2426 from rachel-fenichel/testing/run_mocha_tests
Add mocha tests to npm test
2019-05-02 15:32:09 -07:00
Rachel Fenichel
9e7becc262 Update comments 2019-05-02 15:31:54 -07:00
Navid Zandi
44501f17cc Resolve field angle overlap render problem (#2418)
* Rebuild and update version numbers

* rebuild

* Update version number to 1.20190419.0

* Resolve field angle overlap render problem

* use block.getColourBorder() function
2019-05-02 13:38:48 -07:00
Neil Fraser
834fa64674 Use Element constants and ‘i’ variable.
I don’t care about whether we use the Element constants or the ubiquitously known 1 & 3 integers.  But we had a mix.
Also, ’x’ is usually used for horizontal location, ‘i’ is an iterator.
No functional change.
2019-05-02 09:56:37 -07:00
Neil Fraser
6f433d7521 Don’t preserve IDs during cut/copy/paste or flyout
Previously, if the XML of a toolbox contained a block ID, the first creation of this block would inherit this ID.  Thus two realtime collaborators could realistically end up with conflict.  Likewise, cut and paste could generate similar conflict.
2019-05-02 09:56:37 -07:00
Neil Fraser
e06916e5e3 Factor out licence stripping
Matches code in Blockly Games.
No functional change.
2019-05-02 09:56:37 -07:00
Rachel Fenichel
5e56b4ad58 Merge pull request #2425 from BeksOmega/fixes/fromXml
Removed Explicitly Setting Variable Type to Two Single Quotes
2019-05-01 15:42:10 -07:00
Beka Westberg
3afcd23535 Removed explicitly setting variable type to two single quotes. 2019-05-01 14:31:20 -07:00
Rachel Fenichel
99dc9bb38f Fix test (matching fix in jsunit tests) 2019-05-01 14:19:55 -07:00
Rachel Fenichel
e77efa6c13 Add mocha tests + parsing to npm test 2019-05-01 13:43:19 -07:00
Rachel Fenichel
5983c3c4b7 Merge pull request #2424 from rachel-fenichel/testing/webdriverio_upgrade
Update to webdriverio v5; fix resulting test breakages
2019-05-01 10:55:40 -07:00
Rachel Fenichel
00f84bb595 Add firefox addon explicitly 2019-05-01 10:50:14 -07:00
Rachel Fenichel
da2a89e177 Update to webdriverio v5; fix resulting test breakages 2019-04-30 14:38:33 -07:00
Neil Fraser
8d4a73e33d Strip MIT’s licence out of compiled code.
Matches existing stripping of Google’s licence.  Done with MIT’s permission.  Resolves issue 2412.
2019-04-29 17:27:43 -07:00
Rachel Fenichel
67ee390ef9 Merge pull request #2413 from BeksOmega/feature/FieldUpdateColour
Added updateColour to Field
2019-04-29 17:00:58 -07:00
Beka Westberg
247aafae7e Added updateColour to field. 2019-04-29 16:53:59 -07:00
Beka Westberg
79d75b9f3d Fixed buttons being rendered as labels if they come after a label. (#2410) 2019-04-25 18:21:42 -07:00
Neil Fraser
c438188ab1 Delete two unused i18n scripts
These date back to before Blockly Games was separated from Blockly.
2019-04-25 17:13:49 -07:00
Rachel Fenichel
de6bf6e6ab Merge pull request #2407 from BeksOmega/feature/FieldsXML
Added fromXml and toXml to Fields
2019-04-25 16:10:48 -07:00
Beka Westberg
123b5dc91e Added fromXml and toXml to fields. 2019-04-25 16:00:09 -07:00
Beka Westberg
5c4c816a9b Removed setVisible from the public API (#2406) 2019-04-24 16:07:47 -07:00
Beka Westberg
ce816b93bf Added field_label_serializable. (#2399) 2019-04-24 10:43:09 -07:00
Rachel Fenichel
71d7809c8d Set node version explicitly for travis; rebuild (#2403)
* Set node version explicitly for travis
* rebuild
* Tweak travis config
2019-04-23 16:33:39 -07:00
RoboErikG
d625d60c49 Add release and milestone information to Readme (#2401)
* Add release and milestone information to Readme

* Readme updates in response to comments
2019-04-23 14:36:37 -07:00
Jim Jiang
1b10d134a5 Add Block.setEnabled (#2386)
* Implement Block.setEnabled()

From issue #1593. This commit:
- add setEnabled
- deprecate setDisabled

* Update setDisabled calls to setEnabled

Add setEnabled and deprecate setDisabled in
- core/block_svg

Update calls in
- blocks/loops
- blocks/procedures
- core/block_events
- core/events
- core/flyout_base
- core/xml
- tests/workplace_svg/procedure_svg_test

* Implement changes from comments from RoboErikG

- Implement isEnabled()
- Make this.disabled @private
- Make setDisabled(disabled) call setEnabled(!disabled)
- Update setEnabled to use isEnabled()

* Utilize isEnabled() and fix typos

Fix missing parentheses
Implement isEnabled() more widely
Fix lint and parentheses errors

* Change prevDisabledState to prevEnabledState
2019-04-23 08:49:07 -07:00
asunwoo98
aa4d885cba Validate newValue parameter in setValue (#2392)
* Validate newValue parameter in setValue

* bugfix

* alternate fix

* test

* cleanup
2019-04-22 16:00:37 -07:00
Rachel Fenichel
a84e86f097 Merge pull request #2366 from alschmiedt/Documentation_Update
Documentation update
2019-04-22 14:45:38 -07:00
alschmiedt
1ca7d6a28b Clarifies what statementToCode does 2019-04-22 14:20:05 -07:00
translatewiki.net
fc80d71f39 Localisation updates from https://translatewiki.net. 2019-04-22 22:04:07 +02:00
Beka Westberg
9a9c6612f8 Changed buttons and labels to respect <sep> elements in toolbox. (#2395) 2019-04-22 12:23:04 -07:00
Rachel Fenichel
bc49f29015 Merge pull request #2389 from BeksOmega/feature/SerializableFields
Added isSerializable and SERIALIZABLE to Field
2019-04-22 11:05:50 -07:00
Beka Westberg
148823146d Fixed lint errors 2019-04-22 10:55:36 -07:00
Beka Westberg
91b0e3d79a Changed mocha eslint config to extend root eslint config. 2019-04-22 10:45:35 -07:00
Rachel Fenichel
2e70b8e343 Merge pull request #2397 from BeksOmega/fixes/RTLDemoBlocks
Moved RTL Demo Blocks so They Aren't Behind the Toolbox
2019-04-22 09:12:23 -07:00
Beka Westberg
e8573bc0db Added isSerializable function and SERIALIZABLE property to fields. 2019-04-21 08:28:37 -07:00
Beka Westberg
5df7a39dae Moved RTL demo blocks so they aren't behind the toolbox. 2019-04-20 08:32:56 -07:00
Rachel Fenichel
9152b9dc94 Merge pull request #2394 from rachel-fenichel/update_version_num
Update version number to 1.20190419.0-develop
2019-04-19 13:28:44 -07:00
Rachel Fenichel
a82604d75c Update version number to 1.20190419.0-develop 2019-04-19 11:38:11 -07:00
Rachel Fenichel
a03f9b9fca Merge pull request #2393 from google/rachel-fenichel-patch-2
Add sauce labs to readme
2019-04-18 12:21:07 -07:00
Rachel Fenichel
0c0eeab502 Add sauce labs to readme 2019-04-18 12:18:05 -07:00
ahigerd
bc77024670 Reorganize conditionals for block context menu (#2390)
* Reorganize conditionals for block context menu

* Disable comments and disabling in block factory
2019-04-18 08:49:07 -07:00
translatewiki.net
ae112354fb Localisation updates from https://translatewiki.net. 2019-04-18 16:55:44 +02:00
Rachel Fenichel
209a87ee6c Merge pull request #2382 from BeksOmega/feature/FieldIsDirty
Added isDirty_ Property to Fields
2019-04-16 14:24:05 -07:00
Beka Westberg
0617cc7fea Added isDirty_ property to fields. 2019-04-15 16:37:11 -07:00
RoboErikG
ec78eeb39b Propagate the visible state when blocks connect (#2003)
* Propagate the visible state when blocks connect

This fixes #1967.

In rendered connections when connecting:
- If the superior connection is hidden this hides the newly connected block.
- If the superior connection isn't hidden it makes sure the block is visible.

In rendered connections when disconnecting:
- If the superior connection is hidden, make the disconnected block stack visible.

TODO before review:
 - write tests.
 - update collapsed message

* Add missing overrides

* Add tests for hidden connections and fix a bug while disposing
2019-04-15 16:23:19 -07:00
Beka Westberg
f88c704d69 Fixed visible floating point errors in number fields. (#2384) 2019-04-15 13:26:20 -07:00
Rachel Fenichel
6bb27052ee Merge pull request #2383 from google/fraser-angle
Angle picker's degree symbol left of number in both LTR and RTL.
2019-04-15 12:33:38 -07:00
Beka Westberg
b93253c69c Fixed Mutator Flyout Being Positioned Incorrectly RTL (#2378)
* Fixed mutator flyout being positioned incorrectly.

* Changed flyout_horizonal and flyout_vertical to check this.targetWorkspace_.toolboxPosition instead of targetWorkspaceMetrics.toolboxPosition.
2019-04-15 10:02:07 -07:00
translatewiki.net
fd4bbe035c Localisation updates from https://translatewiki.net. 2019-04-15 17:31:58 +02:00