Rachel Fenichel
3d0567fe46
JS and Dart generator tests pass
2017-12-20 15:14:37 -08:00
Rachel Fenichel
d69519bdab
Fix headless
2017-12-19 16:10:07 -08:00
Rachel Fenichel
4cd0b36944
Fix event ordering for variables created from XML implicitly
2017-12-19 14:25:52 -08:00
Rachel Fenichel
6218750207
Fix events for variable fields on new blocks; fix tests
2017-12-19 11:28:23 -08:00
Rachel Fenichel
db9a9f5182
Move code from the variable to the variable map. Fixes #1512 .
2017-12-15 15:31:41 -08:00
Rachel Fenichel
66975c8f94
Rebase
2017-12-15 13:44:27 -08:00
Rachel Fenichel
a75ab878af
Fix html escaping and flyouts opening
2017-12-13 11:50:08 -08:00
Rachel Fenichel
e77b498504
Respond to review comments in variable_map
2017-12-13 11:50:08 -08:00
Rachel Fenichel
f0b7190603
Clean up TODOs and move potential variable map to the flyout workspace
2017-12-13 11:50:08 -08:00
Rachel Fenichel
b60e70497a
Avoid spurious rename event
2017-12-13 11:50:08 -08:00
Rachel Fenichel
5047b00e27
Fix missing events for variable creation
2017-12-13 11:50:08 -08:00
Rachel Fenichel
7e411b5428
Fix checkmarks when the variable dropdown is open.
2017-12-13 11:50:08 -08:00
Rachel Fenichel
399f1a5c11
Tests
2017-12-13 11:50:08 -08:00
Rachel Fenichel
279cf83b72
Fix events for variable renaming
2017-12-13 11:50:08 -08:00
Rachel Fenichel
24672bcbb2
Remove ws.updateVariableStore and tests, and ws.getVariableUses
2017-12-13 11:50:08 -08:00
Rachel Fenichel
61db23c78a
Get rid of workspace.deleteVariable
2017-12-13 11:50:08 -08:00
Rachel Fenichel
1ce46ab88b
Move getOrCreateVariable to variables.js
2017-12-13 11:50:07 -08:00
Rachel Fenichel
f37386d2bf
Fix default variable name
2017-12-13 11:50:07 -08:00
Rachel Fenichel
3ae7ac1cd4
Make unique variable names in the flyout
2017-12-13 11:50:07 -08:00
Rachel Fenichel
523a10413b
All tests pass
2017-12-13 11:50:07 -08:00
Rachel Fenichel
19939dc16a
All but XML tests now pass
2017-12-13 11:50:07 -08:00
Rachel Fenichel
4d76f2948c
Move code from renameVariableInternal to renameVariableById
2017-12-13 11:50:07 -08:00
Rachel Fenichel
3728cfed45
Update tests in workspace_test. Get rid of renameVariable
2017-12-13 11:50:07 -08:00
Rachel Fenichel
6974208fa3
Fix variable_map_test and variable_model_test
2017-12-13 11:50:07 -08:00
Rachel Fenichel
c55b6afc6f
Fix tests in field_variable_test.js
2017-12-13 11:50:07 -08:00
Rachel Fenichel
012ba022c8
Delete by id
2017-12-13 11:50:07 -08:00
Rachel Fenichel
47457d1683
Fix renaming
2017-12-13 11:50:07 -08:00
Rachel Fenichel
c157412fc5
Can now create a variable with the button in the flyout; drag a block with a variable out of the flyout; handle default variable names; and import and export variables
2017-12-13 11:50:07 -08:00
Rachel Fenichel
24462fbc91
Add TODOs and fix return type
2017-12-13 11:50:07 -08:00
Rachel Fenichel
779be46a92
Allow variables of different types to share the same name.
2017-12-13 11:50:07 -08:00
duzc2dtw@gmail.com
da429688f8
space between if and (
2017-12-13 17:02:34 +08:00
duzc2dtw@gmail.com
26ea42c264
#1376
2017-12-09 20:41:43 +08:00
RoboErikG
0142aa0e94
Don't require flyouts to run Blockly ( #1502 )
...
* Don't require flyouts to run Blockly
There was a bug with Dynamic Variables that made them required for Blockly
to run. This adds checks so that the flyouts only get registered if they're
included. Also does a rebuild of core to pick up the fix.
* Also fix dependencies so dynamic vars don't get stripped
2017-12-08 14:18:09 -08:00
Tianwei Du
383f1d9bac
Develop ( #1501 )
...
Adds missing requires in core/extensions
2017-12-08 10:49:35 -08:00
RoboErikG
a83a625e3b
Rebuild core and fix indents in field_variable.js ( #1500 )
...
After the addition of dynamic variables blockly_uncompressed needed
to be rebuilt for the playground. Also fixes some leftover missing
indents.
2017-12-08 10:46:20 -08:00
Tianwei Du
492462e1d4
Develop ( #1481 )
...
* variables_dynamic
* make test , and i18n
* Issue #1470
* Blockly.Constants.VariablesDynamic.CUSTOM_CONTEXT_MENU_VARIABLE_MUTATION
to make sure setCheck before event trigger
* Update built files from develop.
* fix copyright ,quotes , comments , and optimize some flow.
* quotes，change UI , change category custom name
* single setter , remove mutator , colour typo , typed variables create button message
* undo the indent edits.
2017-12-08 08:53:24 -08:00
Rachel Fenichel
7ef19b6851
Fix #1467
2017-12-06 17:00:22 -08:00
Rachel Fenichel
1d78d7be45
Merge pull request #1483 from DubeySandeep/ScrollableDropdowns
...
Added scrollable functionality to dropdown menu
2017-12-04 10:39:43 -08:00
picklesrus
d1886572d0
Fix #1487 and only add the delete cursor if the block is not deletabl… ( #1491 )
...
* Fix #1487 and only add the delete cursor if the block is not deletable. Also add a grab cursor when it is not deletable so the cursor keeps the grab hand when over the toolbox. This changes the toolbox api slightly, but the methods it touches are @package so it should be okay.
2017-12-04 10:36:47 -08:00
Sandeep Dubey
2dd8c1f669
Made the changes asked by the reviewer
2017-12-03 02:40:11 +05:30
Rachel Fenichel
222407c6ce
Extract code for domToField_
2017-11-30 12:08:01 -08:00
Rachel Fenichel
d73337ad73
Extract fieldToDom into its own function
2017-11-30 11:24:57 -08:00
Karishma Chadha
143d95222c
Fixing type annotation.
2017-11-22 15:22:34 -05:00
Karishma Chadha
aae1b1bb74
Addressing PR comment. Moving functionality to get newly added variables into a helper function.
2017-11-22 14:51:11 -05:00
Karishma Chadha
ee142e92bb
Fixing comment style.
2017-11-22 13:43:25 -05:00
Karishma Chadha
c950225897
Minor refactoring
2017-11-22 13:37:30 -05:00
Karishma Chadha
71205de2ef
Target workspace is the one that carries the variables we want. VarCreate gets fired when a block with a new default variable is dragged out into the workspace.
2017-11-22 13:27:29 -05:00
Karishma Chadha
07d6624625
Fixing bug where VarCreate event does not fire when adding a block with pre-existing variables from the flyout into the workspace.
2017-11-22 12:50:00 -05:00
Rachel Fenichel
662757ab7d
Switch to parentNode for IE
2017-11-20 16:50:21 -08:00
Rachel Fenichel
3b81eede3e
Call forceRerender instead of setText
2017-11-17 14:39:12 -08:00
