Commit Graph

3819 Commits

Author SHA1 Message Date
Rachel Fenichel
40ba284c3f Change constant 2019-08-06 13:40:06 -07:00
Rachel Fenichel
ed245a3c9e Remove dealWithOffsetFields 2019-08-06 11:44:03 -07:00
Rachel Fenichel
c6463acc70 Cleanup and comments 2019-08-06 11:03:53 -07:00
Rachel Fenichel
3802a0c960 Remove getCorrectedSize for fields 2019-08-05 16:01:50 -07:00
translatewiki.net
109f1ad676 Localisation updates from https://translatewiki.net. 2019-08-05 11:58:28 +02:00
Monica Kozbial
1055829188 Merge pull request #2767 from moniika/moniika-render-collapsed
Updating logic to handle rendering collapsed blocks.
2019-08-02 17:41:38 -07:00
Monica Kozbial
3c0bfa17c3 Merge branch 'develop' into moniika-render-collapsed 2019-08-02 14:38:47 -07:00
kozbial
eb3cb76300 Addressing PR comment. 2019-08-02 14:16:52 -07:00
Neil Fraser
b6947976d7 Fix lint in golden PHP generator.
Causing tests to fail.
2019-08-02 11:00:40 -07:00
Neil Fraser
939bbd072b Lint 2019-08-02 11:00:40 -07:00
Neil Fraser
ae24b544f3 Fix injection vulnerability in Block Factories.
Fixes issue #756.
2019-08-02 11:00:40 -07:00
kozbial
9ba91980e5 Addressing PR comments and refactoring path constants. 2019-08-01 13:01:57 -07:00
kozbial
b98b433dff Reverting blockly.js edit. 2019-08-01 11:43:23 -07:00
kozbial
3a983c53e1 Reverting extra files touched by eslint. 2019-08-01 11:42:00 -07:00
Neil Fraser
e77a9b7e81 Change parseFloat() to Number()
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number.  An audit of each case shows nowhere that parseFloat()’s features are needed.
2019-08-01 11:36:58 -07:00
Neil Fraser
8916dbf75b Add Infinity tests for number and angle fields. 2019-08-01 11:36:58 -07:00
Neil Fraser
c8e3938eba Remove field tests with null
Null is explicitly disallowed in most field constructors.  Thus the random results of passing null are undefined and may change.  These changes should not be tested against.

Exceptions:  Variable and serializable lable fields acually do take null.

This commit is due to the upcoming parseInt->Number commit which happens to change how null behaves.

Also added missing ‘empty’ test for checkboxes.
2019-08-01 11:36:58 -07:00
Neil Fraser
11f6c5a631 Fix angle picker when 'Infinity' is typed in.
Previously 'NaN' would be generated, which is not a legal value.
2019-08-01 11:36:58 -07:00
kozbial
c6b0d961a1 Running eslint on modified files. 2019-08-01 11:33:27 -07:00
kozbial
b1d86a57aa Updating logic to handle rendering collapsed blocks. 2019-08-01 11:29:55 -07:00
Roy van Schaijk
bcadd836b2 Make the TabList exclude hidden fields (#2764)
* Make the TabList exclude hidden fields

* Stop using private variable
2019-08-01 11:14:52 -07:00
Monica Kozbial
9cc0cb6881 Merge pull request #2760 from moniika/moniika-update-centerline
Fix bottom row element centerlines
2019-08-01 10:47:46 -07:00
alschmiedt
1ba6bb887d Fixes undo (#2766) 2019-08-01 10:05:56 -07:00
alschmiedt
579363e67a Fix compile (#2759)
* Adds ability to have multiple folders in core
2019-08-01 09:01:49 -07:00
kozbial
e2f12f8262 Fixing edge case for centerline computation for bottom row elements. 2019-07-31 20:12:51 -07:00
Rachel Fenichel
5294d0ab71 Merge pull request #2753 from rachel-fenichel/remove_console_spam
Remove logs from rendering
2019-07-31 15:55:03 -07:00
Rachel Fenichel
860db83b50 Merge pull request #2755 from rachel-fenichel/connection_locations
Work on connection locations
2019-07-31 13:20:38 -07:00
Rachel Fenichel
41c686e733 Use constants 2019-07-31 13:17:20 -07:00
Rachel Fenichel
37250f4ce4 Fix connection highlight rendering 2019-07-31 12:42:34 -07:00
Sam El-Husseini
47da636803 Update LICENSE (#2754)
Replacing the contents of the LICENSE file with the exact text of https://www.apache.o…nses/LICENSE-2.0.txt including the APPENDIX.
2019-07-31 12:29:21 -07:00
Rachel Fenichel
bcdd691796 Make updating the connection locations called the same way for both renderers 2019-07-31 11:45:32 -07:00
Rachel Fenichel
113c24509b Remove logs from rendering 2019-07-31 11:14:24 -07:00
Rachel Fenichel
bc49bf849c Merge pull request #2751 from rachel-fenichel/eslint_rules
Add more eslint rules
2019-07-31 11:01:15 -07:00
Rachel Fenichel
2d1179e52f Add spaced-comment as warning 2019-07-31 09:56:07 -07:00
Rachel Fenichel
16f0992764 Enable operator-linebreak rule 2019-07-31 09:45:27 -07:00
Rachel Fenichel
afd2b09453 Add func-call-spacing rule 2019-07-31 09:43:21 -07:00
Rachel Fenichel
b4109d7c43 Add no-multi-spaces rule 2019-07-31 09:33:54 -07:00
alschmiedt
9466c6b7df Move marker creation to the workspace (#2742)
* Move marker creation to the workspace
2019-07-31 09:04:53 -07:00
alschmiedt
62f4871e45 Fixes copy paste to work with the marker (#2740)
* Fixes copy paste to work with the marker
2019-07-31 07:49:02 -07:00
Neil Fraser
45e5fb4157 More JSDoc and lint corrections 2019-07-30 17:00:40 -07:00
Neil Fraser
6aedfab4d1 Misc JSDoc fixes. (#2747) 2019-07-30 16:28:48 -07:00
Neil Fraser
abc452109e Fix XML across Blockly. (#2727)
Also fixes references to createSvgElement
2019-07-30 15:08:47 -07:00
Rachel Fenichel
47574c670d Merge pull request #2745 from rachel-fenichel/render/constants
Position notches
2019-07-30 14:05:39 -07:00
Beka Westberg
c43e001634 Fixed DropDownDiv Rendering On Small Workspaces (#2641)
* Fixed dropdown div rendering when the workspace is too small.
2019-07-30 13:29:52 -07:00
Sam El-Husseini
d2d621aec3 Update typings after removing references to goog.math (#2743)
* Update typings after removing references to goog.math
2019-07-30 13:19:14 -07:00
Rachel Fenichel
94fe97d9fd position notches 2019-07-30 11:38:18 -07:00
Sam El-Husseini
57868e7e83 Remove all calls to goog.math (#2739)
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Sam El-Husseini
9d593f2cb8 TypeScript Definition file (#2738)
* Add Typescript definition file for Blockly
2019-07-30 11:17:57 -07:00
Sam El-Husseini
5ce8c68833 Fix node build and add node tests (#2736)
* Fix node build and add node tests
2019-07-30 11:13:52 -07:00
alschmiedt
8ef540a8dc Used moveBy in moveTo (#2741) 2019-07-30 10:50:59 -07:00