Commit Graph

6618 Commits

Author SHA1 Message Date
Maribeth Bottorff
5df8752288 fix whitespace 2021-08-11 17:16:25 -07:00
Maribeth Bottorff
f1e8f75f75 Merge branch 'goog_module' of github.com:google/blockly into bubble-module 2021-08-11 17:12:33 -07:00
kozbial
d1d8863fe8 Rename private methods in core/xml.js 2021-08-11 16:09:44 -07:00
kozbial
1d9371a3bc clang-format core/xml.js 2021-08-11 16:09:44 -07:00
kozbial
9666a3eb18 Migrate core/xml.js named requires 2021-08-11 16:09:44 -07:00
kozbial
a64097d23f Migrate core/xml.js to goog.module 2021-08-11 16:09:44 -07:00
kozbial
66130e6668 Migrate core/xml.js to ES6 const/let 2021-08-11 16:09:44 -07:00
kozbial
390469435b clang-format core/insertion_marker_manager.js 2021-08-11 16:02:56 -07:00
kozbial
0bb3f3af84 Migrate core/insertion_marker_manager.js named requires 2021-08-11 16:02:56 -07:00
kozbial
61eb96c831 Migrate core/insertion_marker_manager.js to goog.module 2021-08-11 16:02:56 -07:00
kozbial
fdd9011637 Migrate core/insertion_marker_manager.js to ES6 const/let 2021-08-11 16:02:56 -07:00
kozbial
2ba3b0ba97 Add newline to core/events/events_ui.js 2021-08-11 15:44:43 -07:00
kozbial
75eab4f395 clang-format core/events/events_ui.js 2021-08-11 15:44:43 -07:00
kozbial
2826d70cac Migrate core/events/events_ui_base.js named requires 2021-08-11 15:44:43 -07:00
kozbial
e16a0a4bce Migrate core/events/events_ui.js and core/events/events_ui_base.js to goog.module 2021-08-11 15:44:43 -07:00
kozbial
aa83199a55 Migrate core/events/events_ui.js to ES6 const/let 2021-08-11 15:44:43 -07:00
kozbial
3bdcfd9821 Split core/ui_events.js into multiple files 2021-08-11 15:44:43 -07:00
Aaron Dodson
cf96aac58e Migrate core/procedures.js to goog.module syntax (#5265)
* Migrate core/procedures.js to ES6 const/let

* Migrate core/procedures.js to goog.module

* Migrate core/procedures.js to named requires

* clang-format core/procedures.js

* Rename xml to utilsXml to disambiguate from Xml
2021-08-11 14:04:02 -07:00
kozbial
bdf16d88e0 clang-format core/renderers/geras/measurables/input.js 2021-08-11 13:51:05 -07:00
kozbial
8f83073cdb Migrate core/renderers/geras/measurables/input.js named requires 2021-08-11 13:51:05 -07:00
kozbial
26d4431ae5 Migrate core/renderers/geras/measurables/input.js to goog.module 2021-08-11 13:51:05 -07:00
kozbial
87568c5869 Split classes from core/renderers/geras/measurables/input.js into multiple files 2021-08-11 13:51:05 -07:00
kozbial
88a7779cb2 clang-format core/renderers/measurables/inputs.js 2021-08-11 13:49:50 -07:00
kozbial
35cf6482e3 Migrate core/renderers/measurables/inputs.js named requires 2021-08-11 13:49:50 -07:00
kozbial
59dee77fa8 Migrate core/renderers/measurables/inputs.js to goog.module 2021-08-11 13:49:50 -07:00
kozbial
3081c40a02 Migrate core/renderers/measurables/input_connection.js to ES6 const/let 2021-08-11 13:49:50 -07:00
kozbial
09573bcf16 Split classes from core/renderers/measurables/inputs.js 2021-08-11 13:49:50 -07:00
kozbial
62fff867d8 clang-format core/renderers/common/renderer.js 2021-08-11 13:45:38 -07:00
kozbial
15c512f6ea Migrate core/renderers/common/renderer.js named requires 2021-08-11 13:45:38 -07:00
kozbial
c1bf49ae5c Migrate core/renderers/common/renderer.js to goog.module 2021-08-11 13:45:38 -07:00
kozbial
684047d22f Migrate core/renderers/common/renderer.js to ES6 const/let 2021-08-11 13:45:38 -07:00
kozbial
8aa437b44a Migrate core/renderers/minimalist/drawer.js named requires 2021-08-11 13:44:17 -07:00
kozbial
7c45b039f3 Migrate core/renderers/minimalist/drawer.js to goog.module 2021-08-11 13:44:17 -07:00
Christopher Allen
4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343)
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
Aaron Dodson
a5729043c1 Migrate core/events/events_block_drag.js to goog.module syntax (#5286)
* Migrate core/events/events_block_drag.js to ES6 const/let

* Migrate core/events/events_block_drag.js to goog.module

* Migrate core/events/events_block_drag.js to named requires

* clang-format core/events/events_block_drag.js
2021-08-11 08:40:01 -07:00
Aaron Dodson
4b6ccf868c Migrate core/events/events_theme_change.js to goog.module syntax (#5279)
* Migrate core/events/events_theme_change.js to ES6 const/let

* Migrate core/events/events_theme_change.js to goog.module

* Migrate core/events/events_theme_change.js to named requires

* clang-format core/events/events_theme_change.js
2021-08-11 08:35:01 -07:00
Aaron Dodson
228ecb0f2d Migrate core/renderers/geras/renderer.js to goog.module syntax (#5307)
* Migrate core/renderers/geras/renderer.js to goog.module

* Migrate core/renderers/geras/renderer.js to named requires

* clang-format core/renderers/geras/renderer.js
2021-08-11 08:30:05 -07:00
Aaron Dodson
0f7f597758 Migrate core/renderers/geras/drawer.js to goog.module syntax (#5300)
* Migrate core/renderers/geras/drawer.js to ES6 const/let

* Migrate core/renderers/geras/drawer.js to goog.module

* Migrate core/renderers/geras/drawer.js to named requires

* clang-format core/renderers/geras/drawer.js

* Remove Blockly prefix on call to blockRendering in core/renderers/geras/drawer.js
2021-08-11 08:26:04 -07:00
Aaron Dodson
18283e816f Migrate core/renderers/measurables/base.js to goog.module syntax (#5308)
* Migrate core/renderers/measurables/base.js to goog.module

* Migrate core/renderers/measurables/base.js to named requires
2021-08-11 08:11:44 -07:00
Aaron Dodson
a04debf275 Fix issue that prevented Mocha and generator tests from running on certain configurations (#5344)
* Fix issue that prevented Mocha and generator tests from running on certain configurations

* Link to Blockly issue re: --disable-gpu flag
2021-08-10 15:11:56 -07:00
kozbial
a7fcf881fa Add missing eslint disable line for required interface 2021-08-10 11:20:03 -07:00
kozbial
ee53e8e812 Update optional requires 2021-08-10 11:18:38 -07:00
Aaron Dodson
6bae1ce9f9 Migrate core/workspace_svg.js to goog.module syntax (#5334)
* Migrate core/workspace_svg.js to ES6 const/let

* Migrate core/workspace_svg.js to goog.module

* Migrate core/workspace_svg.js to named requires

* clang-format core/workspace_svg.js
2021-08-10 08:09:46 -07:00
kozbial
6ad723afbc Add eslint disable 2021-08-09 18:53:11 -07:00
kozbial
6863d7fa08 clang-format core/toolbox/toolbox.js 2021-08-09 18:53:11 -07:00
kozbial
a2e9509542 Migrate core/toolbox/toolbox.js named requires 2021-08-09 18:53:11 -07:00
kozbial
ec1567020b Migrate core/toolbox/toolbox.js to goog.module 2021-08-09 18:53:11 -07:00
kozbial
8875dbd50c Migrate core/toolbox/toolbox.js to ES6 const/let 2021-08-09 18:53:11 -07:00
kozbial
d7840db736 clang-formant core/events/variable_events.js 2021-08-09 18:52:07 -07:00
kozbial
dc2438eb28 Migrate core/events/block_events.js named requires 2021-08-09 18:52:07 -07:00