Christopher Allen
4c40378b9a
Use goog.requireType when importing interfaces (etc.) ( #5343 )
...
* Use goog.requireType when importing I* interfaces
Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.
This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.
* Use goog.requireType when only using import for type specifications
Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.
* Remove spurious eslint-disable no-unused-vars
There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.
Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.
* Remove obsolete Closure Compiler error group
stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
kozbial
ee53e8e812
Update optional requires
2021-08-10 11:18:38 -07:00
Monica Kozbial
bec82da358
Remove require destructuring ( #5294 )
2021-08-03 15:07:14 -07:00
Aaron Dodson
47314fd0b9
clang-format core/flyout_base.js
2021-07-22 11:27:36 -07:00
Aaron Dodson
c5694ba711
Migrate core/flyout_base.js named requires
2021-07-22 11:26:32 -07:00
Aaron Dodson
3df8c32594
Migrate core/flyout_base.js to goog.module
2021-07-22 11:11:27 -07:00
Aaron Dodson
380cfd5963
Migrate core/flyout_base.js to ES6 const/let
2021-07-22 11:08:58 -07:00
Monica Kozbial
7b286dbf82
Update the registered component ids ( #4898 )
2021-06-17 17:50:04 -07:00
Monica Kozbial
0014ad3257
Add id to component interface ( #4887 )
2021-06-10 16:03:43 -07:00
Monica Kozbial
d2579a7369
Add removeComponent to ComponentManager ( #4884 )
2021-06-09 22:29:33 -07:00
Monica Kozbial
11390341b1
Adding IDragTarget support. ( #4852 )
2021-06-09 13:59:22 -07:00
Neil Fraser
e661c92a36
More JSDoc improvements
2021-05-27 21:30:26 -07:00
Neil Fraser
d919b0af21
Update JSDoc from Array.<> to Array<>
...
Same with Object.
2021-05-27 21:30:26 -07:00
Neil Fraser
dd0314bc0b
Normalize comments
2021-05-19 09:57:14 -07:00
Sam El-Husseini
f2f878db8c
Fix multiple strict require warnings ( #4793 )
2021-04-21 16:46:04 -07:00
Monica Kozbial
e295102eda
Update Flyout metrics and implement adjustable margin for scrollbars. ( #4763 )
2021-04-09 11:16:34 -07:00
alschmiedt
869e4eb366
Update flyout metrics to work with the new metrics manager ( #4684 )
2021-03-09 17:09:49 -08:00
Monica Kozbial
8b0488d71e
Fix flyout scrollbar reposition edge case ( #4693 )
...
* Fix flyout scrollbar position
2021-03-09 11:32:10 -08:00
Sam El-Husseini
63d26dc186
Add extra requires check ( #4677 )
...
* Add extra requires check
2021-03-05 09:50:51 -08:00
Maribeth Bottorff
4fd6d1b229
Add overrideable function to get flyout scale ( #4647 )
2021-02-26 12:06:27 -08:00
Sam El-Husseini
ab8a11784d
Fix event related missing requires ( #4656 )
...
* Fix event related missing requires
2021-02-25 14:28:11 -08:00
Rachel Fenichel
1d8c234d33
Update uses of bindEvent_, bindEventWithChecks_, and unbindEvent_. Add missing requires for Blockly.browserEvents.
2021-02-23 11:23:28 -08:00
Rachel Fenichel
26d2b51681
Fix missing require types
2021-02-17 11:17:48 -08:00
Monica Kozbial
17d7d1b449
Use ScrollbarPair and WorkspaceDragger in flyouts ( #4607 )
...
* Use ScrollbarPair for flyouts
* Address PR comments
* Fix compile error
2021-02-02 11:46:06 -08:00
alschmiedt
a3adc42e8a
Remove keyboard navigation from core ( #4593 )
2021-01-19 11:50:51 -08:00
Sam El-Husseini
7ebb53968c
Update typings script and fix two typing issues: ( #4542 )
2020-12-16 19:29:20 -08:00
alschmiedt
f1498e7f07
Keyboard shortcuts ( #4421 )
...
* Adds shortcut registry and removes action and key map (#4398 )
* Adds Shortcut tests and refactored navigation tests (#4412 )
* Adds shortcut items (#4408 )
* Add shortcuts for navigation (#4409 )
* Add final keyboard shortcut cleanup (#4413 )
2020-11-02 13:30:05 -08:00
alschmiedt
ae4f894233
Make private methods protected ( #4365 )
2020-10-12 11:20:28 -07:00
Sam El-Husseini
db40e44b7c
Move Blockly.utils.dom.SvgElementType to Blockly.utils.Svg ( #4285 )
...
* Move SVGElementType to its own file shaving off 2.7KB
2020-09-16 14:42:58 -07:00
alschmiedt
22d598484f
Update blockToDom types to include document fragments ( #4280 )
2020-09-16 10:51:09 -07:00
Maribeth Bottorff
6017a953d1
Fix bugs related to events firing during block create ( #4278 )
...
Fix bugs related to events firing during block create and add test for expected block init behavior
2020-09-15 20:02:07 -07:00
alschmiedt
d01169fa79
Toolbox Rewrite ( #4223 )
...
Rewrite the toolbox in order to get rid of old closure code and make it easier to extend.
Co-authored-by: Maribeth Bottorff <maribethb@google.com >
2020-09-02 08:13:07 -07:00
alschmiedt
0f00f42580
Adds Ability to Add a Flyout as a Plugin ( #4059 )
2020-07-22 17:13:19 -07:00
Monica Kozbial
e88ec53425
Hide flyout after Events are re-enabled when creating a block ( #4055 )
2020-07-21 12:58:40 -07:00
Sam El-Husseini
0f3db47fa5
Use generics to derive SVG element type ( #4036 )
...
* Encapsulate type in a generic to automatically derive type of SVG element when using createSvgElement
2020-07-13 10:40:31 -07:00
Sam El-Husseini
9e7f3b07e9
Advanced compilation fixes ( #3995 )
...
* Advanced compilation fixes
2020-06-25 11:59:03 -07:00
Sam El-Husseini
9152c55c9f
Fix multiline field not rendered in flyout ( #3984 )
2020-06-22 15:52:18 -07:00
alschmiedt
b77a30450e
Fix performance ( #3931 )
...
* Speed up performance for converting the xml to json
2020-06-05 09:22:52 -07:00
alschmiedt
26e84fef11
Add ability to add blocks by type ( #3928 )
...
* Add ability to add blocks by type
2020-06-04 12:49:04 -07:00
Sam El-Husseini
1052f7548b
Enable unusedPrivateMembers check ( #3924 )
...
* Add unusedPrivateMembers check
2020-05-28 17:44:16 -07:00
alschmiedt
6bc60894db
Toolbox interface ( #3918 )
...
* Add toolbox interface
2020-05-27 10:06:18 -07:00
Sam El-Husseini
e3babee1f3
Add Blockly.utils.Metrics @record ( #3913 )
...
* Add Blockly.utils.Metrics
2020-05-21 15:03:17 -07:00
Sam El-Husseini
317834ff59
Add accessibility interfaces and fix navigation types ( #3908 )
...
* Add accessibility interfaces and fix navigation types
2020-05-21 11:18:10 -07:00
Sam El-Husseini
fd916fdb9b
Bounding Box interface ( #3906 )
...
* Add an interface describing a bounding box registered on the workspace
* Clear the bounding box array
* PR comments
* Update chromedriver
2020-05-19 18:06:11 -07:00
alschmiedt
d0e91a15a2
Toolbox definition ( #3891 )
...
* Add support for creating a toolbox with JSON
2020-05-13 08:16:53 -07:00
Sam El-Husseini
2d169eabd3
Fix flyout createBlock annotation ( #3749 )
2020-03-16 08:45:22 -07:00
Jakub Vrána
00bb99e0ff
Add non-nullable modifier to return type of functions never returning null ( #3742 )
2020-03-16 08:14:47 -07:00
Sam El-Husseini
14428a0da4
Fix two memory leaks ( #3747 )
...
* Fix two memory leaks
2020-03-13 14:49:08 -07:00
Sam El-Husseini
eb40ca44ba
Dynamic fonts ( #3698 )
...
* Piping themes into the renderer and ensuring fields update their size information when constants change.
2020-02-20 17:16:01 -08:00
Neil Fraser
4e2f8e6e02
Use SPDX licences.
...
This is a followup to #3127 .
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00