Commit Graph

9 Commits

Author SHA1 Message Date
Christopher Allen
4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343)
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
Aaron Dodson
0e6258ca1a Migrated to inline exports 2021-07-21 08:17:13 -07:00
kozbial
bac62dc9be Update jsdoc annotation in core/interfaces/i_bubble.js 2021-07-19 10:13:45 -07:00
kozbial
2c80b90dab Migrate core/interfaces/i_bubble.js named requires 2021-07-19 10:13:45 -07:00
kozbial
30f27606c8 Migrate core/interfaces/i_bubble.js to goog.module 2021-07-19 10:13:45 -07:00
Monica Kozbial
a17cb7f12e Adding parameter to dragEnter and dragExit (#4890)
* introduce IDraggable interface
* Add parameter to drag methods in IDragTarget
* combines bubble/drag methods on IDragTarget and IDeleteArea to take an IDraggable element
2021-06-11 12:58:26 -07:00
Sam El-Husseini
f2f878db8c Fix multiple strict require warnings (#4793) 2021-04-21 16:46:04 -07:00
Rachel Fenichel
a392fcc57c More missing requireType calls 2021-02-17 11:32:54 -08:00
Sam El-Husseini
f3fdab11fb Add IBubble interface (#4104)
* Add IBubble interface and make use of it for WorkspaceCommentSvgs
2020-08-04 17:28:12 -04:00