CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-12 11:27:14 +01:00
Code Issues Packages Projects Releases Wiki Activity
6,618 Commits 110 Branches 106 Tags
5df8752288eacca8d2a301d78c5c85fd8787b31c
Commit Graph

69 Commits

Author SHA1 Message Date
Christopher Allen
4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343) 
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
 2021-08-11 18:50:45 +01:00
kozbial
6ad723afbc Add eslint disable 2021-08-09 18:53:11 -07:00
kozbial
6863d7fa08 clang-format core/toolbox/toolbox.js 2021-08-09 18:53:11 -07:00
kozbial
a2e9509542 Migrate core/toolbox/toolbox.js named requires 2021-08-09 18:53:11 -07:00
kozbial
ec1567020b Migrate core/toolbox/toolbox.js to goog.module 2021-08-09 18:53:11 -07:00
kozbial
8875dbd50c Migrate core/toolbox/toolbox.js to ES6 const/let 2021-08-09 18:53:11 -07:00
kozbial
f818f882bc clang-format core/toolbox/category.js 2021-08-05 10:55:13 -07:00
kozbial
3c564982fc Migrate core/toolbox/category.js named requires 2021-08-05 10:55:13 -07:00
kozbial
68654b34d1 Migrate core/toolbox/category.js to goog.module 2021-08-05 10:55:13 -07:00
kozbial
3ae6a21c55 Migrate core/toolbox/category.js to ES6 const/let 2021-08-05 10:55:13 -07:00
kozbial
ef0fcdbcdd Split Blockly.BlocklyOptions into a separate file 2021-08-05 10:50:44 -07:00
kozbial
38b44f5dab Remove unecessary implements 2021-08-03 15:32:13 -07:00
kozbial
d5d155641e Add eslint disable to core/toolbox/separator.js 2021-08-03 15:32:13 -07:00
kozbial
d004607b3b clang-format core/toolbox/separator.js 2021-08-03 15:32:13 -07:00
kozbial
6bf443bdd6 Migrate core/toolbox/separator.js named requires 2021-08-03 15:32:13 -07:00
kozbial
bce1136500 Migrate core/toolbox/separator.js to goog.module 2021-08-03 15:32:13 -07:00
kozbial
582b67ae7b Migrate core/toolbox/separator.js to ES6 const/let 2021-08-03 15:32:13 -07:00
kozbial
4eed760a19 Fix eslint disable lines 2021-07-30 15:53:51 -07:00
kozbial
7596388124 clang-format core/toolbox/toolbox_item.js 2021-07-30 15:53:51 -07:00
kozbial
65608065ea Migrate core/toolbox/toolbox_item.js named requires 2021-07-30 15:53:51 -07:00
kozbial
af3f04b508 Migrate core/toolbox/toolbox_item.js to goog.module 2021-07-30 15:53:51 -07:00
kozbial
7f5ec67860 Fix lint warnings in core/toolbox/collapsible_category.js 2021-07-29 16:54:07 -07:00
kozbial
17bc528039 Add eslint disable for requireType in core/toolbox/collapsible_category.js 2021-07-29 16:54:07 -07:00
kozbial
c3521b7eb4 clang-format core/toolbox/collapsible_category.js 2021-07-29 16:54:07 -07:00
kozbial
d7a864a498 Migrate core/toolbox/collapsible_category.js named requires 2021-07-29 16:54:07 -07:00
kozbial
41b53c50cd Migrate core/toolbox/collapsible_category.js to goog.module 2021-07-29 16:54:07 -07:00
kozbial
787145acf4 Migrate core/toolbox/collapsible_category.js to ES6 const/let 2021-07-29 16:54:07 -07:00
Neil Fraser
b3c94db951 Revert "Revert "Group field edits together for undo/redo"" 
This reverts commit 344ebcfd02.
 2021-07-12 09:38:04 -07:00
Neil Fraser
344ebcfd02 Revert "Group field edits together for undo/redo" 
This reverts commit 33ad2448b8.
 2021-06-29 11:35:21 -07:00
Neil Fraser
33ad2448b8 Group field edits together for undo/redo 
Fixes #4189.
Also use 0 instead of 0px, in accordance with the rest of Blockly and Google’s CSS style guide.
 2021-06-29 09:57:25 -07:00
Monica Kozbial
7b286dbf82 Update the registered component ids (#4898) 2021-06-17 17:50:04 -07:00
Monica Kozbial
7d45b531ac Update toolbox drag target when visibility changes (#4919) 2021-06-17 15:17:36 -07:00
alschmiedt
a46dbb37e7 Fixes workspace scroll bug (#4921) 2021-06-16 08:18:28 -07:00
Monica Kozbial
34fce2c1cb Moves toolbox cursor styling out of block_dragger (#4896) 2021-06-11 18:02:40 -07:00
Monica Kozbial
a17cb7f12e Adding parameter to dragEnter and dragExit (#4890) 
* introduce IDraggable interface
* Add parameter to drag methods in IDragTarget
* combines bubble/drag methods on IDragTarget and IDeleteArea to take an IDraggable element
 2021-06-11 12:58:26 -07:00
Monica Kozbial
2005576036 Add onDragOver and wouldDelete_ to DeleteArea (#4888) 
* keep track of state for whether the block or bubble would be deleted for use with drag enter exit

* Check if block and bubble is deletable in IDeleteArea

* Add to jsdoc of IDeleteArea
 2021-06-10 16:27:04 -07:00
Monica Kozbial
0014ad3257 Add id to component interface (#4887) 2021-06-10 16:03:43 -07:00
Monica Kozbial
d2579a7369 Add removeComponent to ComponentManager (#4884) 2021-06-09 22:29:33 -07:00
Monica Kozbial
11390341b1 Adding IDragTarget support. (#4852) 2021-06-09 13:59:22 -07:00
Neil Fraser
cff7b359f4 Make comments more consistent. 2021-06-09 11:41:42 -07:00
Neil Fraser
76b5517008 Use null-prototype objects for maps 
A {} has a bunch of names already defined on it (like ‘toString’).  When using an object as a map with arbitrary keys, it should not inherit from Object.prototype.
 2021-06-09 11:41:42 -07:00
Monica Kozbial
5344ad6c21 Add support for IAutoHideable (#4855) 2021-05-27 17:01:11 -07:00
Neil Fraser
dd0314bc0b Normalize comments 2021-05-19 09:57:14 -07:00
Sam El-Husseini
f2f878db8c Fix multiple strict require warnings (#4793) 2021-04-21 16:46:04 -07:00
Sam El-Husseini
0cc79b1366 Fix missing require - constructors (#4676) 
* Fix missing constructors
 2021-04-21 12:11:13 -07:00
alschmiedt
d58c80db76 Refactor flyout and toolbox metrics (#4648) 2021-03-15 12:37:23 -07:00
Rachel Fenichel
f7e0d5f4ea Use existing toolbox position enum 2021-03-05 14:16:43 -08:00
Rachel Fenichel
59084a043c TOOLBOX_AT_TOP and friends -> constants.toolboxPosition.TOP, etc 2021-03-05 13:48:45 -08:00
Sam El-Husseini
63d26dc186 Add extra requires check (#4677) 
* Add extra requires check
 2021-03-05 09:50:51 -08:00
Monica Kozbial
57749e6eb8 Updating bump logic to support single-direction scrollbars (#4652) 
* Updating bump logic to support single-direction scrollbars
 2021-03-01 12:20:12 -08:00