Commit Graph

2257 Commits

Author SHA1 Message Date
Rachel Fenichel
66975c8f94 Rebase 2017-12-15 13:44:27 -08:00
Rachel Fenichel
a75ab878af Fix html escaping and flyouts opening 2017-12-13 11:50:08 -08:00
Rachel Fenichel
e77b498504 Respond to review comments in variable_map 2017-12-13 11:50:08 -08:00
Rachel Fenichel
f0b7190603 Clean up TODOs and move potential variable map to the flyout workspace 2017-12-13 11:50:08 -08:00
Rachel Fenichel
b60e70497a Avoid spurious rename event 2017-12-13 11:50:08 -08:00
Rachel Fenichel
5047b00e27 Fix missing events for variable creation 2017-12-13 11:50:08 -08:00
Rachel Fenichel
7e411b5428 Fix checkmarks when the variable dropdown is open. 2017-12-13 11:50:08 -08:00
Rachel Fenichel
be4054b593 Tests 2017-12-13 11:50:08 -08:00
Rachel Fenichel
399f1a5c11 Tests 2017-12-13 11:50:08 -08:00
Rachel Fenichel
279cf83b72 Fix events for variable renaming 2017-12-13 11:50:08 -08:00
Rachel Fenichel
24672bcbb2 Remove ws.updateVariableStore and tests, and ws.getVariableUses 2017-12-13 11:50:08 -08:00
Rachel Fenichel
61db23c78a Get rid of workspace.deleteVariable 2017-12-13 11:50:08 -08:00
Rachel Fenichel
1ce46ab88b Move getOrCreateVariable to variables.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel
f37386d2bf Fix default variable name 2017-12-13 11:50:07 -08:00
Rachel Fenichel
3ae7ac1cd4 Make unique variable names in the flyout 2017-12-13 11:50:07 -08:00
Rachel Fenichel
523a10413b All tests pass 2017-12-13 11:50:07 -08:00
Rachel Fenichel
19939dc16a All but XML tests now pass 2017-12-13 11:50:07 -08:00
Rachel Fenichel
4d76f2948c Move code from renameVariableInternal to renameVariableById 2017-12-13 11:50:07 -08:00
Rachel Fenichel
3728cfed45 Update tests in workspace_test. Get rid of renameVariable 2017-12-13 11:50:07 -08:00
Rachel Fenichel
6974208fa3 Fix variable_map_test and variable_model_test 2017-12-13 11:50:07 -08:00
Rachel Fenichel
c55b6afc6f Fix tests in field_variable_test.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel
012ba022c8 Delete by id 2017-12-13 11:50:07 -08:00
Rachel Fenichel
47457d1683 Fix renaming 2017-12-13 11:50:07 -08:00
Rachel Fenichel
c157412fc5 Can now create a variable with the button in the flyout; drag a block with a variable out of the flyout; handle default variable names; and import and export variables 2017-12-13 11:50:07 -08:00
Rachel Fenichel
24462fbc91 Add TODOs and fix return type 2017-12-13 11:50:07 -08:00
Rachel Fenichel
779be46a92 Allow variables of different types to share the same name. 2017-12-13 11:50:07 -08:00
Rachel Fenichel
733a629f06 Merge pull request #1504 from areyeshot/develop
fix #1376
2017-12-13 09:41:40 -08:00
duzc2dtw@gmail.com
da429688f8 space between if and ( 2017-12-13 17:02:34 +08:00
Neil Fraser
bc1a5baa48 Fixes to Generator tests (#1510)
* Remove unneeded report variable from generator tests.
* Fix missing message parameter in unittest_fail.  This was a compile error in Dart.
* Fix indentation in PHP.
* Equality helper function not needed in PHP.
2017-12-12 17:38:38 -08:00
Rachel Fenichel
0cb5dfc437 Merge pull request #1492 from Kenny2github/patch-1
Remove "fake some drags!"
2017-12-11 17:12:11 -08:00
duzc2dtw@gmail.com
26ea42c264 #1376 2017-12-09 20:41:43 +08:00
Tianwei Du
0ce3963648 Merge pull request #2 from google/develop
Develop
2017-12-09 20:30:39 +08:00
RoboErikG
0142aa0e94 Don't require flyouts to run Blockly (#1502)
* Don't require flyouts to run Blockly

There was a bug with Dynamic Variables that made them required for Blockly
to run. This adds checks so that the flyouts only get registered if they're
included. Also does a rebuild of core to pick up the fix.

* Also fix dependencies so dynamic vars don't get stripped
2017-12-08 14:18:09 -08:00
Tianwei Du
383f1d9bac Develop (#1501)
Adds missing requires in core/extensions
2017-12-08 10:49:35 -08:00
RoboErikG
a83a625e3b Rebuild core and fix indents in field_variable.js (#1500)
After the addition of dynamic variables blockly_uncompressed needed
to be rebuilt for the playground. Also fixes some leftover missing
indents.
2017-12-08 10:46:20 -08:00
duzc2dtw@gmail.com
0ee877b4bf fix indent 2017-12-09 02:09:58 +08:00
duzc2dtw@gmail.com
f770b29491 fix #1173 2017-12-09 02:03:28 +08:00
Tianwei Du
63143d6eff Merge pull request #1 from google/develop
Develop
2017-12-09 02:01:36 +08:00
Tianwei Du
492462e1d4 Develop (#1481)
* variables_dynamic

* make test , and i18n

* Issue #1470

* Blockly.Constants.VariablesDynamic.CUSTOM_CONTEXT_MENU_VARIABLE_MUTATION
to make sure setCheck before event trigger

* Update built files from develop.

* fix copyright ,quotes , comments ,  and optimize some flow.

* quotes,change UI , change category custom name

* single setter , remove mutator , colour typo , typed variables create button message

* undo the indent edits.
2017-12-08 08:53:24 -08:00
duzc2dtw@gmail.com
8022d7e24b undo the indent edits. 2017-12-08 11:59:45 +08:00
Rachel Fenichel
404373e53a Merge pull request #1496 from rachel-fenichel/bugfix/1467
Fix #1467
2017-12-07 15:06:37 -08:00
duzc2dtw@gmail.com
b642317b0f single setter , remove mutator , colour typo , typed variables create button message 2017-12-07 15:40:28 +08:00
Rachel Fenichel
7ef19b6851 Fix #1467 2017-12-06 17:00:22 -08:00
duzc2dtw@gmail.com
a42c1bca74 quotes,change UI , change category custom name 2017-12-06 16:24:34 +08:00
duzc2dtw@gmail.com
cb380f9989 fix copyright ,quotes , comments , and optimize some flow. 2017-12-05 11:14:45 +08:00
Rachel Fenichel
1d78d7be45 Merge pull request #1483 from DubeySandeep/ScrollableDropdowns
Added scrollable functionality to dropdown menu
2017-12-04 10:39:43 -08:00
picklesrus
d1886572d0 Fix #1487 and only add the delete cursor if the block is not deletabl… (#1491)
* Fix #1487 and only add the delete cursor if the block is not deletable. Also add a grab cursor when it is not deletable so the cursor keeps the grab hand when over the toolbox.  This changes the toolbox api slightly, but the methods it touches are @package so it should be okay.
2017-12-04 10:36:47 -08:00
Sandeep Dubey
2dd8c1f669 Made the changes asked by the reviewer 2017-12-03 02:40:11 +05:30
Ken
c53dec9786 Remove "fake some drags!"
Removed the button, the "fakeDrag" and "fakeManyDrags" and "fakeDragWrapper", and the "fakeDragStack" list.
2017-12-02 11:47:46 +08:00
duzc2dtw@gmail.com
4ce03b4799 Update built files from develop. 2017-12-01 17:48:37 +08:00