Commit Graph

4206 Commits

Author SHA1 Message Date
Neil Fraser
76af463ec4 Removing require for Blockly.FlyoutButton
Should have been in the previous PR, since that’s the point.

Also, a recompile given all the recent dependency changes.
2019-09-24 12:15:03 -07:00
Neil Fraser
6e76b6f49e Make flyout buttons be an optional module. 2019-09-24 10:58:33 -07:00
Neil Fraser
ddb8e46b87 Make flyouts be optional modules.
No Blockly instances need both Horizontal and Vertical flyouts.  Dropping one of these saves 2 KB.  Some don’t need flyouts at all (e.g. Blockly Games Puzzle or readonly documentation blocks).
2019-09-23 22:02:59 -07:00
Monica Kozbial
21c5698e98 Moving DARK_PATH_OFFSET to geras only. (#3066)
* Moving DARK_PATH_OFFSET to geras.

* Adding compressed and uncompressed files.

* Adding missing newlines

* Reverting commit of messages.

* Reverting compressed files.

* Updating compressed files.

* Addressing PR comments.

* Removing unecessary input overrides.
2019-09-23 15:57:59 -07:00
Neil Fraser
b84cda2c76 Strip out more bloat from toolbox (#3068)
Also removes three private accesses from workspaceSvg into toolbox tree.

The strategy for workspace.updateToolbox is no longer to clear and repopulate the toolbox, but rather to throw away the old toolbox and rebuild a new one.  This is simpler and more reliable.

This commit trims off another KB from the compiled code.
2019-09-23 15:18:32 -07:00
Neil Fraser
f550eb0c27 Uncomment requires
Although these requires aren’t required for advanced compilation, they are for simple compilation.
2019-09-23 14:16:00 -07:00
Neil Fraser
fb334fe1c6 Remove ‘dir’ insertion from uncompressed.js
Previously base.js lived outside the blockly directory.  Now it lives in blockly/closure.
2019-09-23 14:16:00 -07:00
Sam El-Husseini
494487b37f Mark fields as dirty when the workspace becomes visible. (#3072)
* Mark fields as dirty when the workspace becomes visible.
2019-09-23 11:21:45 -07:00
Beka Westberg
593383e18a Changed variable field to use configuration (#3065)
* Changed variable field to use new configuration.
2019-09-23 11:14:03 -07:00
alschmiedt
f3b4fc0732 Fix interaction between mouse and keyboard (#3070) 2019-09-23 11:07:59 -07:00
alschmiedt
c16ea62b58 A bunch of small bug fixes (#3067) 2019-09-23 08:59:50 -07:00
Neil Fraser
b0e700307a Quick hack to solve circular dependencies
Submitted without review since everything is broken.  Further investigation needed to find origin of this regression.
2019-09-21 09:58:46 -07:00
Neil Fraser
56e7a46f45 Add more missing dependencies
Submitted without review.  From this bug:
https://github.com/google/blockly-games/issues/116
2019-09-21 08:48:27 -07:00
Neil Fraser
7653785ae6 Add missing require for utils.colour
Pushed without review since it’s activily breaking users (bug report filed from Blockly Games).
2019-09-21 08:40:56 -07:00
Monica Kozbial
5609cda70f Copying values to insertion marker fields directly. (#3063) 2019-09-20 15:35:46 -07:00
Sam El-Husseini
9318c370f9 Handle blockly actions on the dropdown fields. (#3064)
* Handle blockly actions on the dropdown fields.
2019-09-20 15:07:35 -07:00
alschmiedt
23b31c7ea8 Cursor rtl (#3062)
* Fix rtl for cursor svg & small bug fix
2019-09-20 14:34:18 -07:00
Sam El-Husseini
e22ad7f33b Update README with new npm instructions. (#3059)
* Update Readme
2019-09-20 14:21:10 -07:00
Monica Kozbial
a14ac351b5 Adding checks for whether to add elem spacer on row ends (#3060)
* Adding checks for whether elem spacer shouldbe added to start and end of row.

* Fix eslint and add package visibility.
2019-09-20 14:20:14 -07:00
Beka Westberg
e053084621 Changed dropdown field to use new configuration. (#3061) 2019-09-20 13:35:13 -07:00
Monica Kozbial
a8af9fea21 Move populate for topRow and bottomRow to info (#3057)
* Move populate for topRow and bottomRow from measurable definition to info.

* Fix local variable and circular dependency.
2019-09-20 13:24:46 -07:00
Beka Westberg
9e5df6216a Fixed comment ownership. (#2923)
* Moved comment icons to use a model-based system. The block holds the model of the comment, and the comment icon holds a reference to it.
* Reorganized the setVisible function.
* Changed how xml.js serializes and deserializes comments.
2019-09-20 13:16:07 -07:00
Neil Fraser
0726e4a909 Removed unreachable functions from Blockly.Component 2019-09-20 10:36:06 -07:00
Neil Fraser
02fc5bf19c Remove empty span from toolbox.
Every row started with this useless tag:
<span role=“presentation”></span>
2019-09-20 10:36:06 -07:00
Neil Fraser
fb17b0276d Remove unused CSS classes. 2019-09-20 10:36:06 -07:00
Neil Fraser
28953d8ea0 Simplify Blockly.utils.IdGenerator
Also drop unused menu highlight hook.
2019-09-20 10:36:06 -07:00
Neil Fraser
be24605b27 Strip 200 lines of unreachable code
There’s a lot more junk in here, this is just a quick first pass.
2019-09-20 10:36:06 -07:00
Neil Fraser
823c1c98a8 Make toolbox an optional module.
This drops the compiled size by 25 kb if there are no categories.  Which also indicates that the toolbox itself suffers from really bad bloat.  The toolbox should not represent 1/6th of our codebase.
2019-09-20 10:36:06 -07:00
alschmiedt
8e22e45bca Fix inserting into middle of stack from flyout (#3058) 2019-09-20 09:00:44 -07:00
Sam El-Husseini
cb564053b3 Merge toolbox navigation (#3054)
* Merge both types of keyboard navigation (with and without accessibility mode).
2019-09-19 16:36:39 -07:00
Beka Westberg
1c3db256fa Added angle field config (#3038)
* Added angle field configuration.
2019-09-19 16:15:20 -07:00
alschmiedt
6516363469 Change setLocation to setCurNode (#3051)
* Change setLocation to setCurNode
2019-09-19 15:15:14 -07:00
Neil Fraser
a1e3973499 Make block comments an optional module. (#3053)
Measured as a 5 KB *increase* in code size, but that's because some other commit just landed between my tests. It's like running down an up escalator.
2019-09-19 14:53:28 -07:00
Sam El-Husseini
57c8e3dded Rendering: Fix setting the path in RTL (#3047)
* Fix setting the RTL path.
2019-09-19 14:44:44 -07:00
alschmiedt
8003426316 Cleanup compile warnings (#3050)
* Cleanup jsdoc issues

* Cleanup compile warnings

* Fix jsdocs

* Removed unnecessary cast
2019-09-19 14:34:25 -07:00
alschmiedt
abb5ae6d23 Add key map demo (#3042)
* Merge with develop

* Update jsdocs
2019-09-19 13:02:02 -07:00
Neil Fraser
84a814cda1 Make mutator an optional module. (#3048) 2019-09-19 11:39:55 -07:00
Monica Kozbial
97268e665b Merge pull request #3037 from moniika/moniika-cursorDrawerOnRenderer
Creating cursordrawer in renderer.
2019-09-19 10:41:58 -07:00
kozbial
60e6b8c6df style and doc updates. 2019-09-19 10:38:23 -07:00
kozbial
c533a0d943 Setting cursor and marker directly in Workspace and adding check to setCursor/setDrawer. 2019-09-19 10:38:23 -07:00
kozbial
3d06e7eb33 Creating cursordrawer in renderer. 2019-09-19 10:38:23 -07:00
Beka Westberg
d82a0ae0b8 Fixed scrolling the trashcan flyout with mouse. (#3045) 2019-09-19 08:37:40 -07:00
translatewiki.net
585e860395 Localisation updates from https://translatewiki.net. 2019-09-19 11:33:38 +02:00
Sam El-Husseini
22cf08d16c Don't insert disabled blocks from the flyout. (#3046)
* Don't insert disabled blocks from the flyout.
2019-09-18 16:42:25 -07:00
Beka Westberg
a8a8c320d5 Changed multiline field to use new configuration (#3044)
* Changed multilineinput field to new configuration.
2019-09-18 16:30:17 -07:00
Beka Westberg
093467aed1 Added More Procedure Unit Tests (#2630)
* Added more procedure unit tests.

* Cleanup from rebase.

* Cleanup.
2019-09-18 16:14:06 -07:00
Neil Fraser
ec34698c53 Make trashcan and zoomcontrols optional modules. (#3043)
Saves 6 KB when compiled if there is no trashcan nor zoomcontrols.
2019-09-18 15:55:12 -07:00
Neil Fraser
ebdaf4dd46 Remove now unneeded requires from compile test. 2019-09-18 13:38:44 -07:00
Sam El-Husseini
c524980f31 Cache dynamic dropdown options (#3036)
* Cache dynamic dropdown options and only re-generate on initialization and render.
2019-09-18 13:05:25 -07:00
Sam El-Husseini
7d76cafd61 Apply the same patch to the gulp build script. 2019-09-18 13:00:44 -07:00