Commit Graph

64 Commits

Author SHA1 Message Date
Beka Westberg
654467e9ac Added disposed = false properties to fields, connections, and blocks. Changed applicable unit tests from isNotOk -> isFalse. 2019-08-07 07:17:41 -07:00
Beka Westberg
56f424d8ed Added removeInput tests. 2019-08-07 07:07:30 -07:00
Beka Westberg
2f88a40f9b Added block disposal tests. 2019-08-07 07:07:30 -07:00
Beka Westberg
995a2658fe Added shadow unplug tests. 2019-08-07 07:07:30 -07:00
Beka Westberg
b28788fad6 Added licenses to tests and changed some formatting. 2019-08-07 07:07:30 -07:00
Sam El-Husseini
f34f2beac7 Remove all calls to goog.style (#2781)
* Remove dependency on goog.style
2019-08-06 14:54:13 -07:00
Neil Fraser
e77a9b7e81 Change parseFloat() to Number()
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number.  An audit of each case shows nowhere that parseFloat()’s features are needed.
2019-08-01 11:36:58 -07:00
Neil Fraser
8916dbf75b Add Infinity tests for number and angle fields. 2019-08-01 11:36:58 -07:00
Neil Fraser
c8e3938eba Remove field tests with null
Null is explicitly disallowed in most field constructors.  Thus the random results of passing null are undefined and may change.  These changes should not be tested against.

Exceptions:  Variable and serializable lable fields acually do take null.

This commit is due to the upcoming parseInt->Number commit which happens to change how null behaves.

Also added missing ‘empty’ test for checkboxes.
2019-08-01 11:36:58 -07:00
Rachel Fenichel
16f0992764 Enable operator-linebreak rule 2019-07-31 09:45:27 -07:00
Rachel Fenichel
afd2b09453 Add func-call-spacing rule 2019-07-31 09:43:21 -07:00
Rachel Fenichel
b4109d7c43 Add no-multi-spaces rule 2019-07-31 09:33:54 -07:00
Neil Fraser
abc452109e Fix XML across Blockly. (#2727)
Also fixes references to createSvgElement
2019-07-30 15:08:47 -07:00
Beka Westberg
c43e001634 Fixed DropDownDiv Rendering On Small Workspaces (#2641)
* Fixed dropdown div rendering when the workspace is too small.
2019-07-30 13:29:52 -07:00
Sam El-Husseini
57868e7e83 Remove all calls to goog.math (#2739)
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
alschmiedt
826409b01a Add tests for keyboard navigation (#2725) 2019-07-29 13:12:09 -07:00
alschmiedt
7dcc03e791 Fixes mocha tests (#2723) 2019-07-29 12:40:20 -07:00
Rachel Fenichel
08982ce55e Merge pull request #2668 from BeksOmega/fixes/DeprecateSetText
Deprecated Field.setText
2019-07-26 13:02:35 -07:00
Sam El-Husseini
c1b49a1da7 Fix some jsdoc types (#2701)
* Fix JSDoc regarding type inconsistencies. Make image field src required and update image field tests.
2019-07-25 12:24:36 -07:00
Rachel Fenichel
e523943ee9 Merge pull request #2615 from BeksOmega/fixes/Procedures
Fixed Procedure Empty Names & Procedure Parameters
2019-07-23 11:21:22 -07:00
Erik Pasternak
5911e54dc0 Revert "Propagate the visible state when blocks connect (#2003)"
This reverts commit ec78eeb39b.
2019-07-19 16:03:40 -07:00
Beka Westberg
a5bc29357f Added unit tests. 2019-07-19 08:57:34 -07:00
Neil Fraser
829dcc207c Make type and variabletype attributes optional
If a variable doesn’t have a type, then don’t add these empty attributes in the XML.
2019-07-15 14:37:27 -07:00
Neil Fraser
52b6ce18a5 Fix unit tests 2019-07-08 13:29:43 -07:00
Beka Westberg
bb19b4ce0c Reenabled parameter case tests. 2019-07-08 10:44:20 -07:00
Beka Westberg
87fbe0447b Fixed procedures not handling empty names. Renenabled/fixed tests. 2019-07-08 09:23:16 -07:00
Beka Westberg
efde04b7dc Unskipped whitespace then text. 2019-07-08 09:20:51 -07:00
Beka Westberg
b34ca2f93b Fixed review comments. 2019-06-25 15:08:01 -07:00
Beka Westberg
347519b2a1 Added all block files to mocha index. 2019-06-25 15:08:01 -07:00
Beka Westberg
427291c05d Added skipping bad variable test. 2019-06-25 15:08:01 -07:00
Beka Westberg
2620a5092e Added message.js to mocha tests file. 2019-06-25 15:08:01 -07:00
Beka Westberg
85c4e4129f Added procedure tests. 2019-06-25 15:08:01 -07:00
Beka Westberg
5a4cc7ae12 Removed textToDom Needing <xml> Documents (#2585)
* Removed textToDom needing <xml> documents.

* Fixed jsdoc.

* Followon changes resulting from lack of XML tag.

* Fix Mocha test.
2019-06-24 15:50:06 -07:00
Beka Westberg
69e2eae218 Fixed setTooltip not working before appendField(). (#2578) 2019-06-21 13:36:25 -07:00
Beka Westberg
2463a754db Updated TODO's. 2019-06-12 18:36:50 -07:00
Beka Westberg
406c6aca76 Changed sendDeleteEvent to append <xml> tags. Fixed bad <next> tests. 2019-06-12 18:25:44 -07:00
Beka Westberg
6665e46cd1 Removed test cases that never actually occure. 2019-06-12 18:12:19 -07:00
Beka Westberg
d05ce11736 Added trashcan tests. 2019-06-11 15:24:58 -07:00
Beka Westberg
81035c3bcb Fixed unit tests. 2019-06-11 13:32:10 -07:00
Neil Fraser
1905531824 Fix Mocha tests. 2019-06-07 10:32:57 -07:00
alschmiedt
ceffe5c9f5 Merge pull request #2498 from BeksOmega/tests/SetValueAbstract
Added More setValue Test Coverage
2019-05-30 13:10:08 -07:00
Beka Westberg
e6caa50131 Added more setValue test coverage. 2019-05-25 10:20:20 -07:00
Beka Westberg
06c6d83355 Changed colour field class validator to accept all documented values. 2019-05-24 16:14:49 -07:00
Beka Westberg
f16c9c0beb Refactored field validation. 2019-05-24 14:23:42 -07:00
Beka Westberg
acd96aa2c5 Added Field Value Tests (#2459)
* Added field value tests.

* Fixed field image src param.

* Fixed falsy values with label fields.

* Fixed falsy values with text input fields.

* Fixed some angle field tests.

* Fixed other text input when editing tests.

* Fixed colour tests.

* Cleaned up some number and variable field tests.

* Added angle field > 360 degrees tests.

* Fixed variable validator tests.

* Split setValue tests into sub-suites.

* Fixed angle >360 tests

* Changed var declarations to property declarations.
2019-05-17 15:19:14 -07:00
Rachel Fenichel
12a769b9c4 Merge pull request #2426 from rachel-fenichel/testing/run_mocha_tests
Add mocha tests to npm test
2019-05-02 15:32:09 -07:00
Rachel Fenichel
9e7becc262 Update comments 2019-05-02 15:31:54 -07:00
Beka Westberg
3afcd23535 Removed explicitly setting variable type to two single quotes. 2019-05-01 14:31:20 -07:00
Rachel Fenichel
99dc9bb38f Fix test (matching fix in jsunit tests) 2019-05-01 14:19:55 -07:00
Rachel Fenichel
e77efa6c13 Add mocha tests + parsing to npm test 2019-05-01 13:43:19 -07:00