Commit Graph

1359 Commits

Author SHA1 Message Date
Rachel Fenichel
870e95a255 Fix inconsistent return type warning 2018-09-25 14:22:12 -07:00
Neil Fraser
59a4db61b2 Remove .children access
Not supported in node.js’ xmldom package.
2018-09-20 20:34:07 -07:00
Rachel Fenichel
5d8d30935e Restructure isConnectionAllowed to match scratch blocks 2018-09-14 13:58:31 -07:00
Rachel Fenichel
4581c06625 Merge pull request #2052 from rachel-fenichel/bugfix/get_all_blocks
Calls to getAllBlocks should pass a value for _ordered_
2018-09-13 16:17:10 -07:00
Rachel Fenichel
6092e4c517 Calls to getAllBlocks should pass a value for _ordered_ 2018-09-13 16:06:19 -07:00
Rachel Fenichel
a0e90627f7 Add some functions for insertion markers 2018-09-13 15:55:49 -07:00
Rachel Fenichel
7dadc4d4ba Merge pull request #2047 from rachel-fenichel/cleanup/field_properties
Mark some field properties protected
2018-09-13 12:03:55 -07:00
Rachel Fenichel
6a5c90f4b9 Merge pull request #2046 from duzc2/_fix_image_click
fix #1887 #2034
2018-09-13 11:09:02 -07:00
Rachel Fenichel
da309e264f Add info to annotation 2018-09-13 11:04:31 -07:00
Tianwei Du
dcab9c1013 Add connection.getCheck function #2048 (#2049)
* Add connection.getCheck function #2048

* remove unused argument

* fix eslint error

* fix eslint error
2018-09-13 11:02:39 -07:00
Rachel Fenichel
b4865f07f7 Fix some more annotations and an accidental global use of this 2018-09-11 16:41:01 -07:00
Rachel Fenichel
d09c340c79 Mark some field properties protected 2018-09-11 16:19:34 -07:00
duzc2dtw@gmail.com
c92a4f31f5 fix #1887 2018-09-11 00:57:52 +08:00
Andrew n marshall
411ec9724e Replacing node.parentNode.removeChild(node)
...with Blockly.utils.removeNode(..), which includes
a null/undefined check on parentNode before continuing.
2018-09-04 13:31:53 -07:00
Andrew n marshall
b8a1873f01 Converting bad block warning into an error. 2018-08-31 12:42:38 -07:00
Andrew n marshall
7ee9b6bc3e Fix lint errors. 2018-08-28 11:21:21 -07:00
Andrew n marshall
512c746a53 Rename getDeveloperVars() as getDeveloperVariables() (PR #2021)
Merge pull request #2021, a rebase of #1979 (from AnmAtAnm/pr1979-rebase)
2018-08-28 10:30:26 -07:00
Rachel Fenichel
aae8277513 Merge pull request #2022 from rachel-fenichel/feature/canvas_transition
Add support for transitioning the workspace block and bubble canvases on scrollCenter
2018-08-27 11:31:06 -07:00
Rachel Fenichel
48dac195f7 CSS style 2018-08-27 11:23:24 -07:00
Neil Fraser
cb3ea2f56e Remove goog.ui.ColorPicker (#2020)
Adds the ability to set the tooltip titles for each colour.

Note that Closure’s colour picker in Blockly used to have keyboard controls (as of > 3 years ago); but no longer seems to.  This replacement does not currently have keyboard controls either.
2018-08-24 12:14:42 -07:00
Rachel Fenichel
8f675fd82e Add support for transitioning the workspace block and bubble canvases on scrollCenter 2018-08-24 11:55:55 -07:00
Andrew n marshall
c7c9580c51 Rephrase comment, adding date. 2018-08-23 16:00:11 -07:00
Andrew n marshall
243116ca98 Adding warning old function name is detected. 2018-08-23 15:47:49 -07:00
Andrew n marshall
75abc65cd1 Merge branch 'fix-code-mismatch' of https://github.com/gokula-krishna-dev/blockly into pr1979-rebase 2018-08-23 15:17:58 -07:00
RoboErikG
9eacd7d3b9 Disable/enable function calls along with their definitions (#2019)
Fixes #1344

Extends the event listener on procedure caller blocks to also check
for their definition being enabled/disabled and update their own
state in response.
2018-08-23 11:18:29 -07:00
Andrew n marshall
26903a8ca5 Update the docs related to fieldvalidators. 2018-08-22 13:27:07 -07:00
picklesrus
962fcd5c2e Fix #1959 by calling bring to front when a block drag starts inside a mutator. (#2013) 2018-08-21 12:51:43 -07:00
DD
4a34663d49 Fix lint 2018-08-08 21:10:02 -04:00
DD
8d3dea4c74 Add issue to todo and getter for isVisible on workspace 2018-08-08 20:44:23 -04:00
DD
e06807155d Add todo per code review 2018-08-07 18:04:04 -04:00
Rachel Fenichel
2eeee8b9af Stop handling keypresses when the workspace is hidden. 2018-08-07 18:03:23 -04:00
Andrew n marshall
e064a147c7 Create a common helper function for Comment[Create|Delete]) (PR #1988)
Resolves #1871
2018-08-07 12:54:47 -07:00
Rachel Fenichel
341865c80c Merge pull request #1995 from rachel-fenichel/feature/unplug_horizontal
Heal rows when unplugging, and add tests
2018-08-06 11:28:12 -07:00
Rachel Fenichel
b89487e332 Ignore whether parent has multiple inputs 2018-08-06 11:18:00 -07:00
Rachel Fenichel
a8d52903e2 update comment with todo 2018-08-06 10:29:12 -07:00
Dhruv
3ab37dbe46 #1871 Create a common helper function for Comment[Create|Delete] 2018-08-07 00:17:55 +08:00
Neil Fraser
c6afb08c4b Add unit tests and code cleanup to utils (#1993)
* Add unit tests for new util functions
* Utils functions shouldn’t be package, not private.
* Use existing utility function for insertAfter
2018-08-03 14:31:50 -07:00
Rachel Fenichel
b65491e656 Heal rows when unplugging, and add tests 2018-08-03 13:54:29 -07:00
Neil Fraser
6ce31942e0 Some goog.dom removal (#1991) 2018-08-01 15:47:28 -07:00
Gokula Krishna
01eccf449b Prioritize recent key 2018-07-24 13:43:18 +08:00
Gokula Krishna
73340a06e5 Add backward compatibility support 2018-07-24 09:54:37 +08:00
Gokula Krishna
7d63b061bc Match docs with code 2018-07-17 14:34:57 +08:00
RoboErikG
99ebefa1bf Revert "Fix #1960 by collecting block info before icons are destroyed" (#1973)
* Revert "Localisation updates from https://translatewiki.net."

This reverts commit c4a0b64945.

* Revert "Fix #1960 by collecting block info before icons are destroyed (#1970)"

This reverts commit 9a3bd45b22.
2018-07-16 10:18:40 -07:00
RoboErikG
9a3bd45b22 Fix #1960 by collecting block info before icons are destroyed (#1970)
The icons in rendered Blockly currently own the comment text. When
a block was deleted the icons were being disposed of before the block
info was recorded in the event, which meant the comment was lost. This
adds some additional logic to block_svg to make sure the event is
captured before the icons are removed.
2018-07-12 15:34:32 -07:00
Neil Fraser
ac2fa96d7f Replace goog.dom.createDom for creating HTML 2018-07-11 12:20:02 -07:00
Neil Fraser
dce60fd152 Replace ReferenceError with Error.
Change to 4-space indentation rather than aligning with parent structure.
2018-07-11 12:20:02 -07:00
Neil Fraser
c51cf0b79c Remove goog.dom.removeNode 2018-07-11 12:20:02 -07:00
Neil Fraser
f802859547 Remove goog.dom.removeChildren
HTML can be nullified with innerHTML, SVG needs a loop.
2018-07-11 12:20:02 -07:00
Neil Fraser
c8e08109f2 Correct requires for goog.style 2018-07-11 12:20:02 -07:00
Neil Fraser
51e86263c7 Correct requires for goog.math.* 2018-07-11 12:20:02 -07:00