Commit Graph

3 Commits

Author SHA1 Message Date
Maribeth Bottorff
88ff901a72 chore: use prettier instead of clang-format (#7014)
* chore: add and configure prettier

* chore: remove clang-format

* chore: remove clang-format config

* chore: lint additional ts files

* chore: fix lint errors in blocks

* chore: add prettier-ignore where needed

* chore: ignore js blocks when formatting

* chore: fix playground html syntax

* chore: fix yaml spacing from merge

* chore: convert text blocks to use arrow functions

* chore: format everything with prettier

* chore: fix lint unused imports in blocks
2023-05-10 16:01:39 -07:00
Beka Westberg
3a9a9bd24e feat: break input types into separate classes (#7019)
* chore: move input and input types into new directory

* feat: define and export new input types

* feat: modify blocks to construct individual inputs

* chore: transition code to use actual type checks

* chore: fixup input type type

* chore: format

* chore: fixup PR comments

* chore: fix build
2023-05-04 08:50:45 -07:00
Christopher Allen
0177dff49c refactor(blocks): Migrate blocks/lists.js to TypeScript (#6902)
* refactor(blocks): Auto-migration of blocks/lists.js to ts

* fix(blocks): Manually migrate & fix types in lists.ts

* chore(blocks): format lists.ts

  Not running clang-format on this as for some reason it decides
  half way through the file to indent everything after that by
  an extra four spaces (and then has to re-wrap a bunch of lines
  that are consequently too long).

* refactor(blocks): Improve types in lists.ts

  It turns out that the way I originally specified the types for
  the mixins meant that they were all 'any', which is a bit
  useless.  Change them so that tsc actually typechecks
  properties (including method calls) on the mixed-in blocks,
  and then fix the numerous additional type errors which
  doing this revealed.

  (By "fix", I mean apply "as" casts and "!"s as required to
  suppress type errors from tsc.  Actually fixing the code in a
  way that makes the blocks meaningfully more bulletproof is
  left as an exercise to the reader - sorry, I mean: will be
  dealt with in a future PR.)

* fix(blocks): Additional fixes for comments PR #6902
2023-04-18 12:50:54 +01:00