Commit Graph

7908 Commits

Author SHA1 Message Date
Maribeth Bottorff
88ff901a72 chore: use prettier instead of clang-format (#7014)
* chore: add and configure prettier

* chore: remove clang-format

* chore: remove clang-format config

* chore: lint additional ts files

* chore: fix lint errors in blocks

* chore: add prettier-ignore where needed

* chore: ignore js blocks when formatting

* chore: fix playground html syntax

* chore: fix yaml spacing from merge

* chore: convert text blocks to use arrow functions

* chore: format everything with prettier

* chore: fix lint unused imports in blocks
2023-05-10 16:01:39 -07:00
Beka Westberg
af991f5e1b fix: switch most remaining render calls to queueRender (#7024)
* chore: remove render call from procedure blocks

* chore: have workspace queue renders when unhiding

* chore: remove forced rendering from flyouts

* chore: change mutators to use queueing

* chore: change shadows to use queueing

* chore: add comments about icon rendering
2023-05-09 16:57:11 -07:00
Beka Westberg
39cdd8a67a feat: add abstract icon class (#7060)
* chore: rename icon to old icon

* feat: add abstract icon class

* chore: format

* chore: move icon class to icons directory

* chore: switch imports to import type
2023-05-09 23:42:58 +00:00
Beka Westberg
07db0c27d1 feat: add IIcon interface, and related interfaces (#7054)
* feat: add IIcon interface

* feat: add ISerializable interface

* feat: add IHasBubble interface

* feat: add type guards for icon interfaces

* chore: PR comments
2023-05-09 10:13:44 -07:00
Beka Westberg
cdea0ee168 chore: test icon management (#7050)
* chore: test formatting

* chore: add unit tests for adding, removing, and accessing icons

* chore: format

* chore: PR comments
2023-05-09 10:11:34 -07:00
Beka Westberg
4cec0c23cc test: icon block hooks (#7053)
* chore: define test cases

* chore: add tests for icon block hooks

* chore: skip tests (whoops)

* chore: capitalization
2023-05-08 21:10:31 +00:00
dependabot[bot]
f0a7c1c40e chore(deps): Bump webdriverio from 8.3.11 to 8.10.0 (#7056)
Bumps [webdriverio](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/webdriverio) from 8.3.11 to 8.10.0.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v8.10.0/packages/webdriverio)

---
updated-dependencies:
- dependency-name: webdriverio
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-05-05 09:47:26 -07:00
dependabot[bot]
f247ab9cd6 chore(deps): Bump @typescript-eslint/eslint-plugin from 5.59.0 to 5.59.1 (#7028)
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.59.0 to 5.59.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.59.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-05-04 17:08:40 -07:00
Beka Westberg
3a9a9bd24e feat: break input types into separate classes (#7019)
* chore: move input and input types into new directory

* feat: define and export new input types

* feat: modify blocks to construct individual inputs

* chore: transition code to use actual type checks

* chore: fixup input type type

* chore: format

* chore: fixup PR comments

* chore: fix build
2023-05-04 08:50:45 -07:00
Christopher Allen
bf7910986e chore(tests): Stop testing on node.js v14 (#7049)
This formally ends our support for node.js v14.
2023-05-04 16:40:57 +01:00
dependabot[bot]
d3d0e39b1d chore(deps): Bump @blockly/theme-modern from 3.0.6 to 3.0.8 (#7029)
Bumps [@blockly/theme-modern](https://github.com/google/blockly-samples/tree/HEAD/plugins/theme-modern) from 3.0.6 to 3.0.8.
- [Release notes](https://github.com/google/blockly-samples/releases)
- [Changelog](https://github.com/google/blockly-samples/blob/master/plugins/theme-modern/CHANGELOG.md)
- [Commits](https://github.com/google/blockly-samples/commits/@blockly/theme-modern@3.0.8/plugins/theme-modern)

---
updated-dependencies:
- dependency-name: "@blockly/theme-modern"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-05-03 10:42:14 -07:00
Markus Bordihn
b996372994 Update category.ts to produce valid "aria-level" attributes to fix #7027 (#7033) 2023-05-03 10:39:31 -07:00
Rachel Fenichel
fea91af90e chore: remove private underscores in gesture.ts (#7021)
* chore: remove private underscores in gesture.ts

* chore: format

* chore: remove a stale todo
2023-05-01 09:09:46 -07:00
Beka Westberg
a520b88098 chore: Merge master back into develop following v9.3.3 release
Merge pull request #7018 from BeksOmega/release/master-to-develop-v9.3.3
2023-04-30 08:24:41 -07:00
Rachel Fenichel
d47369acfe refactor(blocks): Migrate blocks/text.js to TypeScript (#6958)
* refactor(blocks): auto-migration of blocks/text.js to ts

* refactor(blocks): fix up some types in blocks/text.ts

* refactor(blocks): improve some types in text.ts

* refactor(blocks): additional type cleanups

* chore: format

* chore: fix typo

* chore: respond to PR comments

* chore: respond to PR comments
2023-04-28 10:54:28 -07:00
dependabot[bot]
5e186de179 chore(deps): Bump @typescript-eslint/eslint-plugin from 5.55.0 to 5.59.0 (#7009)
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.55.0 to 5.59.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.59.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-28 17:44:29 +01:00
Rachel Fenichel
08d57853be chore: remove private underscores in field_variable.ts (#7022)
* chore: remove private underscores in field_variable.ts

* chore: remove stale TODO
2023-04-27 10:05:53 -07:00
Beka Westberg
ab3a796fd9 chore: merged master into master-to-develop, resolving conflicts 2023-04-26 19:58:56 +00:00
Beka Westberg
399bd650a6 release: v9.3.3
Merge pull request #7016 from google/rc/v9.3.3
blockly-v9.3.3
2023-04-26 09:35:15 -07:00
Beka Westberg
e86183e6c6 release: Update version number to 9.3.3 2023-04-26 16:07:28 +00:00
Neil Fraser
026e496044 fix: offset location of connection ripple (#6973)
Resolves issue #6972

(cherry picked from commit 8ade26148c)
2023-04-26 16:06:42 +00:00
Beka Westberg
f45cd8160e fix: insertion markers firing move events (#7005)
(cherry picked from commit 35276e9468)
2023-04-26 16:06:12 +00:00
Beka Westberg
961a83f420 fix: icons not having their locations updated (#7012)
* fix: icons not having their locations updated

* chore: fix running headful tests in node

(cherry picked from commit 139bc299a0)
2023-04-26 16:06:12 +00:00
Neil Fraser
64aa3e7df4 feat: Add 'reason' field to move event (#6996)
* feat: Add 'reason' field to move event

There are many types of move.  This addition allows one to detect what the reason for each move is.

* Clang formatting.

And unsaved editor tabs.

* Change reason string to array.
2023-04-26 00:22:10 +02:00
Beka Westberg
139bc299a0 fix: icons not having their locations updated (#7012)
* fix: icons not having their locations updated

* chore: fix running headful tests in node
2023-04-24 15:36:13 -07:00
Christopher Allen
60a2358cd7 chore(build): Delete chunks cache file chunks.json (#7011)
This file should have been deleted in PR #6222 but was somehow
overlooked.
2023-04-24 21:27:22 +01:00
Rachel Fenichel
96ecfea857 refactor(blocks): Migrate blocks/variables.js and blocks/variables_dynamic.js to TypeScript (#7001)
* refactor: run js2ts on variables

* refactor: clean up conversion of variables blocks to typescript

* refactor: add types for custom context menu options

* refactor: run js2ts on blocks/variables_dynamic.js

* refactor: clean up types in variables_dynamic

* chore: respond to PR comments

* chore: format
2023-04-24 13:09:02 -07:00
Rachel Fenichel
705a35a2d2 chore: clean up some drawer code lint (#6994)
* chore: clean up some drawer code lint

* chore: remove hungarian notation
2023-04-24 10:38:32 -07:00
Maribeth Bottorff
bf8be1a4f9 fix: update applyColour documentation (#6998) 2023-04-24 10:23:16 -07:00
dependabot[bot]
d516e517d4 chore(deps): Bump DoozyX/clang-format-lint-action from 0.15 to 0.16 (#7010)
Bumps [DoozyX/clang-format-lint-action](https://github.com/DoozyX/clang-format-lint-action) from 0.15 to 0.16.
- [Release notes](https://github.com/DoozyX/clang-format-lint-action/releases)
- [Commits](https://github.com/DoozyX/clang-format-lint-action/compare/v0.15...v0.16)

---
updated-dependencies:
- dependency-name: DoozyX/clang-format-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-24 07:55:19 -07:00
Beka Westberg
d726080eaa feat: add support for appending custom inputs (#6990)
* feat: add appendInput method

* feat: enable constructing inputs from the registry

* chore: reorganize into suites

* chore: add new input test + fixup existing

* chore: reorganize appending from registry

* chore: fix input types enum

* chore: fix tests
2023-04-21 15:58:42 -07:00
Beka Westberg
35276e9468 fix: insertion markers firing move events (#7005) 2023-04-21 12:49:02 -07:00
dependabot[bot]
7feefa44d0 chore(deps): bump rimraf from 4.1.2 to 5.0.0 (#6986)
* chore(deps): bump rimraf from 4.1.2 to 5.0.0

Bumps [rimraf](https://github.com/isaacs/rimraf) from 4.1.2 to 5.0.0.
- [Release notes](https://github.com/isaacs/rimraf/releases)
- [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md)
- [Commits](https://github.com/isaacs/rimraf/compare/v4.1.2...v5.0.0)

---
updated-dependencies:
- dependency-name: rimraf
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): Update imports of rimraf for compatibility with v5.0.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christopher Allen <cpcallen+git@google.com>
2023-04-21 16:02:07 +01:00
Maribeth Bottorff
467b6a2e79 fix: rtl field alignment (#6991) 2023-04-20 13:53:18 -07:00
Christopher Allen
65f64110a8 chore(tests): Update configuration to test on node.js v20 (#6995)
* chores(deps): Update eslint-plugin-jsdoc to 43.0.7 to fix issue

  - This resolves npm install error messages reporting incompatibility
    of the previous version (and one of its dependencies) with
    node.js version other than 14, 16, 18, and 19 (i.e. notably
    excluding v20).

  - It also pulls in a fix to a bug in 43.0.6 which caused the
    jsdoc/tag-lines startLines option (which replaces the former
    jsdoc/newline-after-description rule) to incorrectly error
    when linting single-line JSDocs containing tags.

  - Update .eslintrc.js appropriately to use the new rule.

* chore(tests): Add node.js v20 to CI test matrix

* chore(tests): Update lint job to also use node.js v20
2023-04-20 17:56:29 +01:00
dependabot[bot]
fa9cb579ae chore(deps): bump eslint-plugin-jsdoc from 40.0.0 to 41.1.2 (#6985)
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 40.0.0 to 41.1.2.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v40.0.0...v41.1.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-19 17:18:44 +01:00
Dima
acd046e4b3 fix: block_svg disable/enable ops lead to unsync state and render (#6989)
* fix: disable/enable block_svg downstream blocks

* fix: disable/enable block_svg improve
2023-04-19 15:11:21 +00:00
Beka Westberg
83e3dcac70 feat: add after queued renders promises to render management (#6981)
* feat: add promise to render queue system

* chore: update docs for variables

* chore: add export of render management

* chore: add tests for resolving render management promises

* fix: modify insertion marker manager to use render management promises

* chore: format

* chore: remove callback from afterQueuedRenders

* chore: don't store resolver

* chore: rename afterQueuedRenders -> finishQueuedRenders

* chore: fix tests
2023-04-18 17:02:33 -07:00
Rachel Fenichel
a4d0b67985 refactor(blocks): Migrate blocks/loops.js to TypeScript (#6957)
* refactor(blocks): Auto-migration of blocks/loops.js to ts

* fix(blocks): Manually migrate types and fix imports in loops.ts

* chore: respond to PR comments
2023-04-18 15:58:21 -07:00
Christopher Allen
0177dff49c refactor(blocks): Migrate blocks/lists.js to TypeScript (#6902)
* refactor(blocks): Auto-migration of blocks/lists.js to ts

* fix(blocks): Manually migrate & fix types in lists.ts

* chore(blocks): format lists.ts

  Not running clang-format on this as for some reason it decides
  half way through the file to indent everything after that by
  an extra four spaces (and then has to re-wrap a bunch of lines
  that are consequently too long).

* refactor(blocks): Improve types in lists.ts

  It turns out that the way I originally specified the types for
  the mixins meant that they were all 'any', which is a bit
  useless.  Change them so that tsc actually typechecks
  properties (including method calls) on the mixed-in blocks,
  and then fix the numerous additional type errors which
  doing this revealed.

  (By "fix", I mean apply "as" casts and "!"s as required to
  suppress type errors from tsc.  Actually fixing the code in a
  way that makes the blocks meaningfully more bulletproof is
  left as an exercise to the reader - sorry, I mean: will be
  dealt with in a future PR.)

* fix(blocks): Additional fixes for comments PR #6902
2023-04-18 12:50:54 +01:00
Beka Westberg
edc5843c4c fix: non-printable characters in XML (#6952)
* fix: non-printable characters in XMl

* fix: PR comments

* chore: format

* chore: move to module-level parser and serializer

* chore: reorganize textToDom

* chore: add dummy implementations of domParser and xmlSerializer

* chore: properly check classes before constructing

* chore: fix tests

* chore: PR comments

* chore: remove null char from tests

* chore: docs!
2023-04-17 16:05:09 -07:00
Neil Fraser
20f0c937cd chore: 'compareDocumentPosition' to 'contains' (#6982)
The 'compareDocumentPosition' call was inherited from Closure Library, in order to work with IE 8 and earlier.  Use the more modern 'contains' call instead.

This change was originally added here:
https://github.com/google/blockly/pull/1991

Remove the DOCUMENT_POSITION_CONTAINED_BY constant which is not a NodeType and should never have been part of that enum.

This change was originally added here:
https://github.com/google/blockly/pull/2736
2023-04-17 23:48:24 +02:00
Maribeth Bottorff
2bbb3aa1fc fix: do not hide all chaff when resizing (#6916) 2023-04-17 10:06:44 -07:00
Neil Fraser
2fa7280ce1 fix: Don't truncate text label fields. (#6979)
https://groups.google.com/g/blockly/c/S5b3iKB2Sos
2023-04-15 17:34:20 -07:00
Rachel Fenichel
c458d63018 chore: remove underscores from private properties and methods in some fields (#6977)
* chore: remove private underscores in field_checkbox

* chore: remove private underscores from field_dropdown

* chore: remove private underscores in field_image

* chore: remove private underscores in field_label

* chore: remove private underscores in field_number

* chore: format
2023-04-13 14:59:43 -07:00
Rachel Fenichel
5f8330e74e chore: remove underscores from private properties and methods in keyboard nav and rendering (#6975)
* chore: remove underscores in keyboard navigation

* chore: remove private underscores from renderers
2023-04-12 11:19:41 -07:00
Neil Fraser
8ade26148c Fix offset location of connection ripple (#6973)
Resolves issue #6972
2023-04-12 10:00:41 -07:00
Beka Westberg
ae8673f09e chore: Merge master back into develop following v9.3.2 release
Merge pull request #6956 from google/master
2023-04-11 14:53:22 -07:00
Beka Westberg
c0cceb56e6 chore: delete update metadata action (#6969) 2023-04-11 12:07:10 -07:00
Rachel Fenichel
85013f83b2 chore: remove underscores from private properties and methods in connections (#6961)
* chore: remove private underscores in connection and connection_db

* chore: remove private underscores in rendererd_connection
2023-04-11 10:06:17 -07:00