Commit Graph

3918 Commits

Author SHA1 Message Date
Beka Westberg
891d23795e Corrected some language. 2019-08-16 09:57:28 -07:00
Beka Westberg
b300583b6a Try to Fix Mocha: Remove changed tests. 2019-08-16 09:57:28 -07:00
Beka Westberg
542ba09d78 Try to Fix Mocha: Remove unnecessary function bindings? 2019-08-16 09:57:28 -07:00
Beka Westberg
0872d022e1 Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires. 2019-08-16 09:57:28 -07:00
Beka Westberg
84937a0ff6 Fixed lint error. 2019-08-16 09:57:27 -07:00
Beka Westberg
16c59d2ffc Added tests and remove jsunit fields test file. 2019-08-16 09:57:27 -07:00
Beka Westberg
cdc90f4059 Refactored field utilities. 2019-08-16 09:57:27 -07:00
Sam El-Husseini
f539dbe6f6 Add aria invalid for when a text input field is invalid (#2839) 2019-08-15 17:13:06 -07:00
Sam El-Husseini
f174f422ff Set the border size on a text input to take into account scaling. (#2837) 2019-08-15 16:23:17 -07:00
alschmiedt
9b3e05e3d9 Field accessibility (#2823)
* Gives fields a chance to handle keyboard events
2019-08-15 15:44:54 -07:00
Rachel Fenichel
a01d1eb5bc Merge pull request #2825 from rachel-fenichel/block_widths
Correctly calculate widths of blocks with children on external inputs.
2019-08-15 14:35:15 -07:00
Rachel Fenichel
f4d8c24e53 Merge pull request #2833 from rachel-fenichel/remove_render_icon
Remove renderIcon function
2019-08-15 11:28:21 -07:00
Rachel Fenichel
39e4ab63d7 Merge pull request #2835 from rachel-fenichel/center_fields
Center some fields and inputs vertically
2019-08-15 11:24:44 -07:00
Rachel Fenichel
26e9348b07 Center some fields and inputs vertically 2019-08-15 11:06:05 -07:00
Rachel Fenichel
eea2e2c61f Remove renderIcon function 2019-08-15 10:28:26 -07:00
Neil Fraser
b52de5cac2 Remove self-closing XML tags in workspace factory (#2769) 2019-08-15 10:20:49 -07:00
Monica Kozbial
47400f2b8e Merge pull request #2829 from moniika/moniika-fix-zero-height-spacer-row-rtl
Prevent incorrectly drawing vertical line for zero height spacer rows in RTL.
2019-08-14 16:50:39 -07:00
kozbial
c4165e92b8 Prevent incorrectly drawing vertical line for zero height spacer rows. 2019-08-14 16:16:48 -07:00
Rachel Fenichel
863f7f430c Merge pull request #2792 from BeksOmega/fixes/EventInheritance
Cleaned up BlockBase and CommentBase toJson and fromJson Calls
2019-08-14 15:50:57 -07:00
Beka Westberg
0eacbd7217 Fixed typo. 2019-08-14 15:45:37 -07:00
Beka Westberg
c862a13a38 Cleaned up BlockBase and CommentBase toJson and fromJson calls. 2019-08-14 15:45:37 -07:00
Rachel Fenichel
f3aca51ba9 Merge pull request #2827 from rachel-fenichel/delete_old_rendering
DELETE CODE
2019-08-14 14:53:56 -07:00
Rachel Fenichel
9325e993b2 Remove call to renderInternal 2019-08-14 14:48:25 -07:00
Sam El-Husseini
174fe53516 Minor jsdoc issue (#2826)
The JavaScript closure compiler barfs at this. No such thing as JSDOC @throw.
2019-08-14 14:40:54 -07:00
Rachel Fenichel
3e85d7b05a DELETE CODE 2019-08-14 14:32:48 -07:00
Sam El-Husseini
4a10ff833d Remove all calls to goog.events.KeyCodes (#2824)
* Remove all calls to goog.events.keyCodes
2019-08-14 14:14:49 -07:00
Rachel Fenichel
7b5e6eee63 Correctly calculate widths of blocks with children on external inputs. 2019-08-14 14:09:20 -07:00
Sam El-Husseini
f118d6de88 No closure toolbox (#2819)
* Update the toolbox to not rely on closure and instead use the built in Blockly.tree component
2019-08-14 13:48:21 -07:00
Monica Kozbial
d662410694 Merge pull request #2822 from moniika/moniika-fix-statement-input-width
Update statementInput width to reflect what is actually being rendered.
2019-08-14 12:36:33 -07:00
kozbial
a476564fa2 Fixing width computation and start x for statement input draw. 2019-08-14 11:34:32 -07:00
Sam El-Husseini
f9d7af7125 Add Blockly aria utils (#2813)
* Add aria utils
2019-08-14 11:22:36 -07:00
Sam El-Husseini
dbcdaf0d21 Foundation for no-closure toolbox (#2818)
* A subset of closure tree components for building a no-closure toolbox
2019-08-14 11:22:21 -07:00
Sam El-Husseini
b9d932559c Add a singleton id generator util (#2815)
* Add a singleton id generator utility
2019-08-14 10:06:46 -07:00
Sam El-Husseini
a0dcf7f495 Add extra style methods used by closure components (#2816) 2019-08-13 18:34:48 -07:00
kozbial
d921c4ff47 Using statement input xPos instead of statementEdge. 2019-08-13 18:01:24 -07:00
kozbial
2d30ed2e9c Update statementInput width to reflect what is actually being rendered. 2019-08-13 17:35:04 -07:00
Monica Kozbial
b0098f7817 Merge pull request #2810 from moniika/moniika-debug-rect
Adding missing padding to statement input rows.
2019-08-13 17:32:04 -07:00
kozbial
95163f30de Minor refactor in alignRowElements currentWidth and desiredWidth computation. 2019-08-13 17:15:50 -07:00
Sam El-Husseini
6911228f32 Cherry-pick from master: No longer private 2019-08-13 16:28:29 -07:00
Sam El-Husseini
a41a3c5f33 Add keycode utils to reference keycodes via an enum (#2814) 2019-08-13 16:25:26 -07:00
Rachel Fenichel
e2c00740b7 Merge pull request #2809 from rachel-fenichel/more_connections
Include next connection in block's bounding box
2019-08-13 15:55:47 -07:00
Rachel Fenichel
39b3717b2c Include next connection in block's bounding box 2019-08-13 15:23:27 -07:00
Rachel Fenichel
1ef4a1343b Merge pull request #2817 from rachel-fenichel/baby_steps
Replace path array with path string
2019-08-13 15:18:29 -07:00
Rachel Fenichel
f449c8bb3c Remove commented out code 2019-08-13 14:32:03 -07:00
Rachel Fenichel
4f487c65f0 Fix hat 2019-08-13 14:26:22 -07:00
Sam El-Husseini
109e32b866 Revert "Add extra style methods used by closure components"
This reverts commit cb461b2c94.
2019-08-13 14:19:25 -07:00
Sam El-Husseini
cb461b2c94 Add extra style methods used by closure components 2019-08-13 14:18:40 -07:00
Rachel Fenichel
6b440cc5e0 Replace path array with path string 2019-08-13 14:17:51 -07:00
alschmiedt
00be6a6381 Make the navigation namespace lowercase (#2812) 2019-08-13 14:00:49 -07:00
Sam El-Husseini
7ab4bb846c Add a test script to compile typings and test on travis (#2808) 2019-08-13 13:49:28 -07:00