Commit Graph

3497 Commits

Author SHA1 Message Date
Rachel Fenichel
8ce82d5142 Merge pull request #2558 from BeksOmega/fixes/ReadOnlyFields
Fixed Fields Still Being Editable on Non-Editable Blocks
2019-06-11 11:09:26 -07:00
Beka Westberg
e0909b4ef8 Fixed fields still being editable on non-editable blocks. 2019-06-10 10:42:58 -07:00
Neil Fraser
0213de11bc Use Rect in more places. 2019-06-07 10:32:57 -07:00
Neil Fraser
6947010c49 Change Rect to use top/bottom/left/right
Instead of top/left/height/width.  Given our uses of Rect, it makes the math slightly simpler.

This is a setup for using Rect in other places.  Currently it is only used to describe delete areas.
2019-06-07 10:32:57 -07:00
Neil Fraser
98a98bcce6 Add Blockly.utils.dom.XLINK_NS
And fix provide/require mixup.
2019-06-07 10:32:57 -07:00
Neil Fraser
848d3a3509 Move setCssTransform & createSvgElement to dom.
Also move SVG_NS and HTML_NS properties.
2019-06-07 10:32:57 -07:00
Neil Fraser
775ce34eac Simplify workspace.getBlocksBoundingBox
Previously it returned x,y,width,height.  Returning top,bottom,left,right results in simpler code, both in this function and in downstream callers.

This commit makes the minumum change to the metrics_test.  I’m happy to change the test’s data if that makes more sense.
2019-06-07 10:32:57 -07:00
Neil Fraser
a9fdf7844a Fix ordering of requires
Search and replace of a name strikes again.
2019-06-07 10:32:57 -07:00
Neil Fraser
02e9b25f03 Flaten bounding box data structure.
Old: a box object with two coordinate objects, each with two numbers.
New: a box object with four numbers.

The old system would make sense if there was a reason to group the top-left and bottom-right coordinates.  But in our code we only pulled out top/bottom/left/right numbers.

New code is simpler and faster.
2019-06-07 10:32:57 -07:00
Neil Fraser
3dfac9a2ba Alphabetize require statements.
Search and replace for userAgent didn’t take into account alphabetic ordering.
Also some line wraping.
2019-06-07 10:32:57 -07:00
Neil Fraser
1905531824 Fix Mocha tests. 2019-06-07 10:32:57 -07:00
Neil Fraser
566f182fa8 Move Blockly.userAgent to Blockly.utils.userAgent 2019-06-07 10:32:57 -07:00
Neil Fraser
d1a29739d8 Move utilities into own directory.
TODO: There are more functions which may be migrated into dom and string.
2019-06-07 10:32:57 -07:00
Neil Fraser
cf91b82bb0 Fix three new and ten existing Closure warnings.
Current count: 638
2019-06-07 10:32:57 -07:00
Neil Fraser
42b4897f0e Routine recompile due to changed dependencies. 2019-06-07 10:32:57 -07:00
Neil Fraser
5bf7069a2f Remove goog.math.Coordinate 2019-06-07 10:32:57 -07:00
Neil Fraser
f2c57dea1b Remove goog.math.Rect dependency 2019-06-07 10:32:57 -07:00
Neil Fraser
931cc85c83 Remove last goog.dom dependency. 2019-06-07 10:32:57 -07:00
Neil Fraser
e8d8798ecf Remove goog.events.BrowserFeature dependency. 2019-06-07 10:32:57 -07:00
Neil Fraser
a18aa76e67 Update colour tests
Blockly now normalizes colours lowercase.
2019-06-05 16:41:04 -07:00
Neil Fraser
2d11b6f0ad Recompile due to changed dependencies. 2019-06-05 16:41:04 -07:00
Neil Fraser
069423e7cd Remove last traces of goog.color. 2019-06-05 16:41:04 -07:00
Neil Fraser
ed9330cf57 Move Blockly.hueToRgb to Blockly.utils.colour
Also adds support for ‘#f00’, ‘rgb(255, 0, 0)’ and ‘red’ for block colours, in addition to ‘#ff0000’ (and of course hue).
2019-06-05 16:41:04 -07:00
Neil Fraser
cdaded4296 Remove goog.color.parse 2019-06-05 16:41:04 -07:00
Neil Fraser
4f20264128 Remove orphaned regexp. 2019-06-05 16:41:04 -07:00
Beka Westberg
985bf3af3b Fixed how the trashcan handled shadow blocks. (#2545) 2019-06-05 09:53:56 -07:00
Beka Westberg
54eb726063 Removed extra DropDownDiv calls. (#2532) 2019-06-03 11:02:05 -07:00
translatewiki.net
02de44c06f Localisation updates from https://translatewiki.net. 2019-06-03 17:23:44 +02:00
Rachel Fenichel
7c5a94d0d9 Merge pull request #2528 from BeksOmega/fixes/DropdownRendering
Fixed Dropdown Arrow Missing Padding
2019-05-31 12:24:05 -07:00
Beka Westberg
4b70215db8 Fixed dropdown arrow being to close to option. 2019-05-31 11:56:21 -07:00
Rachel Fenichel
b99d71ba80 Merge pull request #2509 from BeksOmega/fixes/FieldInitializationReorganization
Reorganized Field View Initialization
2019-05-31 10:46:37 -07:00
Beka Westberg
f0d6fbd192 Reorganized field view initialization. 2019-05-31 10:38:18 -07:00
Rachel Fenichel
37d8038aa2 Merge pull request #2526 from BeksOmega/fixes/FieldNameXML
Moved Serializing the Field's Name up to xml.js
2019-05-31 10:31:00 -07:00
Rachel Fenichel
d3062bae65 Merge pull request #2500 from BeksOmega/fixes/FieldSizeHandling
Fixed How Fields Handle Size
2019-05-31 10:17:25 -07:00
Beka Westberg
2f0b02525a Moved serializing the field's name up to xml.js 2019-05-31 10:12:57 -07:00
Beka Westberg
e1e746b845 Fixed how fields handle size. 2019-05-31 07:32:43 -07:00
Rachel Fenichel
44c01ff22a Merge pull request #2501 from BeksOmega/fixes/AngleFields
Angle Field Fixes
2019-05-30 16:03:49 -07:00
alschmiedt
ceffe5c9f5 Merge pull request #2498 from BeksOmega/tests/SetValueAbstract
Added More setValue Test Coverage
2019-05-30 13:10:08 -07:00
alschmiedt
ea3c483e51 Merge pull request #2517 from BeksOmega/feature/DateDropdownDiv
Moved the Date Field to the Dropdown Div, and Restyled It
2019-05-30 13:06:02 -07:00
translatewiki.net
3fbd183ed8 Localisation updates from https://translatewiki.net. 2019-05-30 19:13:24 +02:00
Neil Fraser
dce0b77424 Fix 19 warnings in theme-related code. (#2523)
* Fix 19 warnings in theme-related code.

Resolves #2414

* Remove suppressPrefixSuffix property definition

The mixin code throws an error if property exists on both objects.

* eslint has strange ideas about indentation.
2019-05-30 10:05:06 -07:00
Beka Westberg
73ff710a4d Added getSourceBlock function to field. (#2508) 2019-05-29 12:50:00 -07:00
Beka Westberg
9099ee8c14 Readded reevaluating values when constraints are set. (#2507) 2019-05-29 12:48:55 -07:00
Neil Fraser
459961c3cb Replace Element constants with Node constants.
Element constants apparently don’t exist in IE or Edge.  Node constants apparently do.
2019-05-29 10:45:54 -07:00
Rachel Fenichel
a03f0859cc Merge pull request #2497 from BeksOmega/fixes/ValidColourFieldValues
Changed Colour Field Class Validator to Accept all Documented Values
2019-05-28 16:07:52 -07:00
Beka Westberg
4d9c0f01f5 Moved the date field to the dropdown div, and restyled it. 2019-05-28 15:32:20 -07:00
Beka Westberg
0061931686 Change applicable locations to use the modulo assignment operator. 2019-05-27 07:41:01 -07:00
translatewiki.net
c8704689e5 Localisation updates from https://translatewiki.net. 2019-05-27 16:33:04 +02:00
Beka Westberg
38f437a87e Fixed angle fields not displaying 0 when given an empty string. 2019-05-25 17:36:27 -07:00
Beka Westberg
bace90e538 Fixed gauge breaking at high angle values. 2019-05-25 16:58:38 -07:00