Sam El-Husseini
8eba82b906
Fix 4 misc warnings ( #3283 )
2019-10-17 16:52:52 -05:00
Sam El-Husseini
c1c9121fcc
Fix jsdoc. @return instead of @returns ( #3271 )
...
* Fix jsdoc. @return instead of @returns
2019-10-16 17:01:36 -05:00
Neil Fraser
013f2714a3
Cleanup aria usage. ( #3261 )
...
Use enums instead of arbitrary strings.
Delete unused Aria properties
Add missing requires.
Delete unused code.
2019-10-15 22:43:23 -07:00
Sam El-Husseini
2224bb2a4e
More field dispose ( #3201 )
...
* Dispose of element references in fields.
* Fewer warnings
2019-10-15 17:56:53 -05:00
Beka Westberg
f4f9a67903
Fixed field editor disposal ( #3109 )
...
* Fixed field editor disposal.
2019-10-08 16:48:31 -07:00
RoboErikG
663809297d
Set correct defaults for Fields ( #3179 )
...
null was being converted to 0 by Number() when it should cause the
default value to be set instead. This updates FieldNumber and
FieldAngle to handle nulls correctly. Also update jsdoc.
Fixes #3177
2019-10-07 11:38:32 -07:00
Sam El-Husseini
d0772ad496
Fix compiler warnings related to fields. ( #3144 )
...
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
Neil Fraser
b46a4fe286
Bring our license format up to date ( #3127 )
...
* Google changed from an Inc to an LLC.
This happened back in 2017 but we didn’t notice. Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.
* Remove project description/titles from licenses
This is no longer part of Google’s header requirements. Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).
* License no longer requires URL.
* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini
a57c7ffb13
Clean up fields by passing the right type in fromJson ( #3095 )
2019-09-26 12:03:17 -07:00
Beka Westberg
a8a8c320d5
Changed multiline field to use new configuration ( #3044 )
...
* Changed multilineinput field to new configuration.
2019-09-18 16:30:17 -07:00
Sam El-Husseini
8fae0411f7
Check if a type exists before testing instanceof ( #3031 )
...
* Check if a type exists before instance of
2019-09-17 16:28:18 -07:00
Beka Westberg
8b9816abcb
Text Field Config ( #2986 )
...
* Added text input field configuration.
2019-09-16 10:08:46 -07:00
Beka Westberg
af81239c42
Number Field Configuration ( #2985 )
...
* Added number field configuration.
2019-09-16 09:52:08 -07:00
Sam El-Husseini
f3f3329355
Fix configure method ( #2915 )
...
* Fix configure method.
2019-09-12 17:01:03 -07:00
Rachel Fenichel
6f4476c962
Textarea Field, Multiline Block (from acbart) ( #2663 )
...
* Field Textarea, text_multiline block, generators
2019-09-11 17:57:46 -07:00
Sam El-Husseini
8ab51c8639
Remove closure base file dependency ( #2976 )
...
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Sam El-Husseini
dd9257e1b0
Field Text transformation methods ( #2930 )
...
* Add field text transform methods for converting from text to value and vice versa.
2019-08-30 17:00:31 -07:00
Sam El-Husseini
f23b659898
Remove this.text_ ( #2910 )
...
* Remove this.text_ and have every field handle its own properties.
2019-08-26 10:56:36 -07:00
Sam El-Husseini
b7097d1add
Field widgetdiv flicker ( #2911 )
...
* Stop field flickering when the text input is initially shown.
2019-08-26 08:53:55 -07:00
Sam El-Husseini
1d4cfb8dfa
Field angle keyboard navigation ( #2853 )
...
Field angle keyboard accessibility
2019-08-20 18:25:15 -07:00
Neil Fraser
096959fde9
Cleanup of last fortnight’s commits. ( #2865 )
...
No functional changes.
2019-08-19 14:07:48 -07:00
Sam El-Husseini
c99734b8f9
Add valuemin and valuemax aria properties for number fields ( #2850 )
2019-08-16 18:41:05 -07:00
Beka Westberg
0872d022e1
Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires.
2019-08-16 09:57:28 -07:00
Beka Westberg
cdc90f4059
Refactored field utilities.
2019-08-16 09:57:27 -07:00
Sam El-Husseini
f539dbe6f6
Add aria invalid for when a text input field is invalid ( #2839 )
2019-08-15 17:13:06 -07:00
Sam El-Husseini
f174f422ff
Set the border size on a text input to take into account scaling. ( #2837 )
2019-08-15 16:23:17 -07:00
Sam El-Husseini
36135ac62b
Fix RTL text field positioning bug by ensuring a reflow ( #2779 )
2019-08-07 10:54:36 -07:00
Rachel Fenichel
5deedc8f53
Merge pull request #2783 from rachel-fenichel/field_corrected_size
...
Remove getCorrectedSize for fields
2019-08-06 13:45:44 -07:00
Rachel Fenichel
3802a0c960
Remove getCorrectedSize for fields
2019-08-05 16:01:50 -07:00
Sam El-Husseini
9203517f3d
Center text field input when editing ( #2776 )
...
* Center text field input when editing
2019-08-05 11:23:47 -07:00
Neil Fraser
e77a9b7e81
Change parseFloat() to Number()
...
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number. An audit of each case shows nowhere that parseFloat()’s features are needed.
2019-08-01 11:36:58 -07:00
Neil Fraser
45e5fb4157
More JSDoc and lint corrections
2019-07-30 17:00:40 -07:00
Sam El-Husseini
57868e7e83
Remove all calls to goog.math ( #2739 )
...
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Rachel Fenichel
c3eb0ed3c4
Merge pull request #2690 from rachel-fenichel/border_rect_default_height
...
Define BORDER_RECT_DEFAULT_HEIGHT constant
2019-07-23 16:21:10 -07:00
Rachel Fenichel
24866deae9
Use BORDER_RECT_DEFAULT_HEIGHT constant
2019-07-23 13:38:28 -07:00
Rachel Fenichel
71ef4b86b8
Merge pull request #2670 from BeksOmega/fixes/RemoveChangeListener
...
Removed Useless Text Input Workspace Change Listener.
2019-07-23 12:56:32 -07:00
Rachel Fenichel
fc4372dbc2
Add TODOs with github issue number
2019-07-22 16:29:44 -07:00
Beka Westberg
7e3344cf17
Removed useless text input workspace change listener.
2019-07-19 09:55:29 -07:00
Rachel Fenichel
f469a388ed
Add getCorrectedSize functions to fields
2019-07-17 11:00:20 -07:00
alschmiedt
55fc506782
Merge pull request #2577 from BeksOmega/fixes/doValueInvalid
...
Added Sending the Bad Value to doValueInvalid
2019-06-24 16:09:20 -07:00
Beka Westberg
3227223c82
Renamed _newValue param to _invalidValue.
2019-06-24 14:58:33 -07:00
Beka Westberg
27a6593d27
Removed Class Option Check from Text Input fromJson ( #2588 )
...
* Removed class option check from text input fromJson, as text input fields don't accept a class.
* Fixed syntax error.
2019-06-24 13:34:28 -07:00
Beka Westberg
4a0d5f5df0
Added sending the bad value to doValueInvalid.
2019-06-14 12:00:10 -07:00
Neil Fraser
b8cbd9e7df
Resolve 13 warnings
...
Reduce count from 632 to 619.
Eliminate copy-paste code duplication in Field.prototype.setValue
2019-06-12 10:59:33 -07:00
Beka Westberg
392119680e
Fixed misc PR comments.
2019-06-11 13:32:10 -07:00
Beka Westberg
81035c3bcb
Fixed unit tests.
2019-06-11 13:32:10 -07:00
Beka Westberg
303115953e
Moved to #2125 disposal. Cleaned up some doc.
2019-06-11 13:32:09 -07:00
Beka Westberg
217206911a
Fixed some formatting in text input.
2019-06-11 13:30:50 -07:00
Beka Westberg
0122f36450
Fixed field disposal, and reorganized editor creation.
2019-06-11 13:30:50 -07:00
Neil Fraser
a9fdf7844a
Fix ordering of requires
...
Search and replace of a name strikes again.
2019-06-07 10:32:57 -07:00