CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-09 01:50:11 +01:00
Code Issues Packages Projects Releases Wiki Activity
6,654 Commits 110 Branches 106 Tags
9046ce165b0577db9ff5f0c70e2ed27037a67c90
Commit Graph

164 Commits

Author SHA1 Message Date
Christopher Allen
4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343) 
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
 2021-08-11 18:50:45 +01:00
Aaron Dodson
0e6258ca1a Migrated to inline exports 2021-07-21 08:17:13 -07:00
Aaron Dodson
da960d5973 Convert private static functions to module-internal functions in core/connection.js 2021-07-20 10:49:21 -07:00
Aaron Dodson
bdd0353549 clang-format core/connection.js 2021-07-16 14:16:06 -07:00
Aaron Dodson
210fcea198 Migrate core/connection.js to named requires 2021-07-16 14:13:40 -07:00
Aaron Dodson
fc62fed33c Migrate core/connection.js to goog.module 2021-07-16 13:55:08 -07:00
Aaron Dodson
fa158d143e Migrate core/connection.js to ES6 const/let 2021-07-16 13:48:33 -07:00
Beka Westberg
13bb9f5bf6 Refactor connect logic (#4880) 
* Refactor connect logic.

* Fixup from rebase

* Fix build

* PR Comments
 2021-06-18 09:53:43 -07:00
Neil Fraser
cff7b359f4 Make comments more consistent. 2021-06-09 11:41:42 -07:00
Neil Fraser
e661c92a36 More JSDoc improvements 2021-05-27 21:30:26 -07:00
Neil Fraser
d919b0af21 Update JSDoc from Array.<> to Array<> 
Same with Object.
 2021-05-27 21:30:26 -07:00
Beka Westberg
5ffd43824f Change lastConnectionInRow to getPlaceForOrphanedOutput - Take 2 (#4851) 
* Change lastConnectionInRow to getPlaceForOrphanedOutput

* PR comments
 2021-05-26 09:16:33 -07:00
Sam El-Husseini
f2f878db8c Fix multiple strict require warnings (#4793) 2021-04-21 16:46:04 -07:00
Sam El-Husseini
63d26dc186 Add extra requires check (#4677) 
* Add extra requires check
 2021-03-05 09:50:51 -08:00
Rachel Fenichel
7f8c875b29 Fix lint 2021-03-04 10:23:20 -08:00
Rachel Fenichel
750b62030b First pass at creating connectionTypes and inputTYpes 2021-03-04 10:22:24 -08:00
Sam El-Husseini
ab8a11784d Fix event related missing requires (#4656) 
* Fix event related missing requires
 2021-02-25 14:28:11 -08:00
Rachel Fenichel
c9be2402bd More missing requires 2021-01-12 12:38:21 -08:00
Sam El-Husseini
fba35d342c Add missing require Blockly.constants (#4366) 2020-10-12 17:56:42 -04:00
alschmiedt
22d598484f Update blockToDom types to include document fragments (#4280) 2020-09-16 10:51:09 -07:00
Beka Westberg
c732484180 Add programmatically setting shadows Take 2 (#4215) 
* Add programmatically setting shadows
 2020-09-08 08:50:01 -07:00
Rachel Fenichel
815c8b8919 More deprecation 2020-07-16 17:49:51 -06:00
Rachel Fenichel
602d1b6d63 Use new deprecation warning helper 2020-07-16 17:46:49 -06:00
Rachel Fenichel
3322834a9b Add deprecation warnings and tests 2020-07-16 17:40:13 -06:00
Rachel Fenichel
e47d33148e Review feedback 2020-07-16 17:40:13 -06:00
Rachel Fenichel
809148b435 Fix compiler errors 2020-07-16 17:40:13 -06:00
Rachel Fenichel
7288c66294 Rename connectionTypeChecker->connectionChecker 2020-07-16 17:40:13 -06:00
Rachel Fenichel
8ae3dc3d5e Cleanup 2020-07-16 17:40:13 -06:00
Rachel Fenichel
e24f3cef9b Add isDragging to canConnectWithReason and delete newly unused code paths. 2020-07-16 17:40:13 -06:00
Rachel Fenichel
e3c8d834cb Add todos and rebuild 2020-07-16 17:40:13 -06:00
Rachel Fenichel
450aed0aa2 More work on connection type checks 2020-07-16 17:40:12 -06:00
Rachel Fenichel
bb8348befd Move to a single canConnect function, and update tests 2020-07-16 17:40:12 -06:00
Rachel Fenichel
8c17e325b5 Update connection tests to directly use the type checker 2020-07-16 17:40:12 -06:00
Rachel Fenichel
c743a92bb9 Start work on connection type checker 2020-07-16 17:40:12 -06:00
Sam El-Husseini
c9563c1d24 Revert "Add programmatically setting shadows (#3902)" 
This reverts commit 3aa1963be8.
 2020-06-12 08:54:04 -07:00
alschmiedt
8585ef111c Remove @package (#3961) 2020-06-12 08:17:16 -07:00
Sam El-Husseini
1052f7548b Enable unusedPrivateMembers check (#3924) 
* Add unusedPrivateMembers check
 2020-05-28 17:44:16 -07:00
Beka Westberg
3aa1963be8 Add programmatically setting shadows (#3902) 
* Add programmatically setting shadows
 2020-05-21 11:44:08 -07:00
Sam El-Husseini
317834ff59 Add accessibility interfaces and fix navigation types (#3908) 
* Add accessibility interfaces and fix navigation types
 2020-05-21 11:18:10 -07:00
Sam El-Husseini
fd916fdb9b Bounding Box interface (#3906) 
* Add an interface describing a bounding box registered on the workspace

* Clear the bounding box array

* PR comments

* Update chromedriver
 2020-05-19 18:06:11 -07:00
Monica Kozbial
a9223b0b22 Typo fixes. (#3769) 2020-03-25 15:47:27 -07:00
Neil Fraser
4e2f8e6e02 Use SPDX licences. 
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
 2020-02-11 13:27:20 -08:00
Neil Fraser
123f436e04 Add parens around inline assignments (#3381) 2019-10-31 15:17:35 -07:00
Sam El-Husseini
7d174727b0 Fix warnings for code used by blocks (#3362) 2019-10-30 08:11:18 -07:00
Sam El-Husseini
52bef4463c Fix warnings related to connections. (#3306) 
* Fix warnings related to connections.
 2019-10-23 17:56:52 -04:00
Sam El-Husseini
664cc3d6cd Fix warnings related to number of arguments passed. (#3270) 2019-10-17 11:47:30 -05:00
Sam El-Husseini
526528354f Fix 10 warnings related to visibility (#3275) 2019-10-17 11:46:57 -05:00
alschmiedt
cf04a9529b Fix compilier warnings for keyboard nav (#3196) 
* Fix compilier warnings for keyboard nav
 2019-10-08 11:34:39 -07:00
Rachel Fenichel
608ce7b93c Merge pull request #3133 from BeksOmega/fixes/ConnectionTracking 
Connection Tracking Pt 3: Changed connections to use 'tracked_' property
 2019-10-07 11:05:10 -07:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127) 
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
 2019-10-02 14:46:56 -07:00