Review feedback

This commit is contained in:
Rachel Fenichel
2020-07-16 14:36:39 -06:00
parent 809148b435
commit e47d33148e
3 changed files with 8 additions and 4 deletions

View File

@@ -16,8 +16,8 @@ goog.require('Blockly.Events');
goog.require('Blockly.Events.BlockMove');
goog.require('Blockly.Xml');
goog.requireType('Blockly.IConnectionChecker');
goog.requireType('Blockly.IASTNodeLocationWithBlock');
goog.requireType('Blockly.IConnectionChecker');
/**

View File

@@ -13,8 +13,9 @@
goog.provide('Blockly.ConnectionChecker');
goog.requireType('Blockly.IConnectionChecker');
goog.requireType('Blockly.Connection');
goog.requireType('Blockly.IConnectionChecker');
/**
* Class for connection type checking logic.
@@ -45,7 +46,8 @@ Blockly.ConnectionChecker.prototype.canConnect = function(one, two,
* connection, and return an error code if there are problems.
* @param {Blockly.Connection} one Connection to check compatibility with.
* @param {Blockly.Connection} two Connection to check compatibility with.
* @param {boolean} isDragging [description]
* @param {boolean} isDragging True if the connection is being made by dragging
* a block.
* @return {number} Blockly.Connection.CAN_CONNECT if the connection is legal,
* an error code otherwise.
* @public

View File

@@ -15,6 +15,7 @@ goog.provide('Blockly.IConnectionChecker');
goog.requireType('Blockly.Connection');
/**
* Class for connection type checking logic.
* @interface
@@ -38,7 +39,8 @@ Blockly.IConnectionChecker.prototype.canConnect;
* connection, and return an error code if there are problems.
* @param {Blockly.Connection} one Connection to check compatibility with.
* @param {Blockly.Connection} two Connection to check compatibility with.
* @param {boolean} isDragging [description]
* @param {boolean} isDragging True if the connection is being made by dragging
* a block.
* @return {number} Blockly.Connection.CAN_CONNECT if the connection is legal,
* an error code otherwise.
* @public