* chore: move comments
* chore: remove underscores from private property names
* chore: remove underscores from properties and methods in insertion marker manager
* chore: format
* chore: track closestConnection and localConnection as a single object
* chore: format
* chore: add comments and simplify shouldUpdatePreviews
* chore(docs): add jsdoc for new params
* chore: use destructuring assignments
* chore: improve readability
* chore: address review feedback
* chore: respond to review feedback
* chore: fix types in shouldDelete
* chore: make wouldDeleteBlock a property
* chore: format
* feat(build): Make build tasks invoke their prerequisites
- Divide gulp targets into three kinds: main sequence,
manually invokable, and script-only. The first two categories
automatically invoke their prerequisites.
- Give (most of) the affected gulp targets shorter and more memorable
names that could become their npm script names in future.
* feat(build): Make package tasks invoke their prerequisites
Have the package task invoke the cleanBuildDir (as well as
cleanPackageDir) and build tasks. Remove the checkBuildDir
task as it is now redundant since a fresh build is done every
time.
* feat(build): Make git tasks invoke their prerequisites
* feat(build): Make cleanup, license [sic] tasks invoke their prerequisites
Turns out they don't have any, so this commit just classifies
their gulp targets according to the established scheme.
* feat(build): Make appengine tasks invoke their prerequisites
In this case prepareDeployDir will eventually depend on package
but does not for now.
* feat(build): Have npm scripts run npm ci first where applicable
Have any npm script that have external effects (e.g. publishing an
npm package, pushing a new version to appengine, or updating GitHub
Pages) start by running npm ci to ensure that all dependencies are
up-to-date with respect to package-lock.json.
(This is done by npm and not a gulp script because gulp itself
might need updating. So might npm, but that is less likely to
make any difference to what gets published/pushed.)
* chore(build): have tests use package target
Have the tests just run the package target (with debug flags)
since that runs the the build target automatically.
* feat(tests): Write Closure Compiler output directly to dist/
Since they are already UMD-wrapped, have Closure Compiler write
output chunks directly to RELEASE_DIR, i.e. dist/.
* chore(tests): Use freshly-build files in compressed mode.
Use the freshly-built build/*_compresssed.js files when bootstrapping
in compressed mode, rather than using the checked-in files in the
repository root.
This helps ensure that compressed and uncompressed mode will be
testing (as closely as possible) the same code.
Obsoletes #6218 (though the issues discussed there have not actually
yet been addressed in this branch).
* chore(build): Write intermediate langfiles to build/msg
Write the results of create_messages.py to build/msg instead of
build/msg/js.
* fix(build): Use build/msg/en.js instead of msg/messages.js in tests
This has no direct effect but fixes a long-standing misdesign
where we are testing against the input to, rather than the output
of, the language file processing pipeline.
* feat(demos): Use freshly-built files
Use the freshly-built dist/*_compresssed.js and build/msg/* files
rather than using the checked-in files in the repository root.
This helps ensure that these demos are using the most recent
version of Blockly (even in the develop branch).
* fix(build): Update appengine deployment to include built files
Modify the prepareDemos task as follows:
- Use the git index instead of HEAD, so that most local changes
will be applied (without copying whatever .gitignored cruft
might be in the local directory).
- Run clean and build and then copy build/msg and
dist/*_compressed.js* to the deploy directory.
This fixes the problem created by the previous commit, wherein the
demos relied on built files that were not being deployed to
appengine.
* fix(build): Update GitHub Pages deployment to include built files
Modify the updateGithubPages task to run clean and build and
then git add build/msg dist/*_compressed.js*, so that they will
be included in the deployed pages.
This fixes the problem created by the previous^2 commit,
wherein the demos relied on built files that were not being
deployed to GitHub Pages.
* chore(build): Remove build products from repository
Remove *_compressed.js* and msg/js/* from the blockly repository.
Also remove the now-obsolete checkinBuilt gulp task.
* chore(build): Apply relevant changes to test_tasks.js
Apply changes made to run_all_tests.sh and check_metadata.sh to
the corresponding parts of their JS replacements in
test_tasks.js.
* chore(build): Make updates suggested in PR #6475
- Remove `clean:builddir` and `clean:releasedir` - `clean`
is sufficient.
- Remove duplicate `require` from `appengine_tasks.js`.
* feat(build): Use shorter npm script names
Since scripts that run build tasks now automatically run their
prerequisite tasks, the previous naming scheme of task `build`
running all the `build:subtask`s no longe really makes very
much sense.
Additionally, following a chat discussion, there seems to be a
rough consensus to use "messages" to refer to the .json input
files, and "langfiles" to the generated .js output files.
Consequently, simplify npm script names by renaming as follows:
- "generate:langfiles" -> "messages"
- "build:langfiles" -> "langfiles"
- "build:js" -> "tsc"
- "build:deps" -> "deps"
- "build:compiled" -> "minify"
- "build:compressed": delete this synonym for "build:compiled",
("minify" was chosen as agnostic to Closure Compiler vs. WebPack.)
* chores(build): Add deprecation notice for old scripts
To reduce potential confusion/frustration, restore the previous
npm scripts but have them display a deprecation notice instead
(note that npm prints the script contents before running it, so
echo is not needed).
* docs(build): Add comments distinguishing 'messages' from 'langfiles'
* chore: remove underscores from properties and methods in comment.ts
* chore: remove some underscores from icon-related classes
* chore: cleanup
* chore: respond to PR feedback
* chore: catch one more bit of PR feedback
* chore: restructure constructor to improve annotations
* chore: clean up scrollbar disposal
* chore: remove underscores from private properties and methods in scrollbar
* chore: clean up comment
* fix: expand the IParameterModel interface
* fix: remove support for return types from the concrete procedure model
* feat: add an interface for the procedure map, and add getting procedures
* fix: add procedure map to workspace
* chore: format
* fix: add name parameter to procedure model to match parameter model
* chore: format
* chore: fix comments
* chore: add tests for the backing variable of parameter models
* chore: update existing procedure map tests
* chore: update block update tests to use refactored API
* chore: update tests to actually use fluent API
* chore: format
* chore: fix tests
* chore: reorganize tests
* chore: format
* chore: add comment
* chore: added generator type to `core/field_dropdown.ts` and updated affected files
* chore: added type to ARROW_CHAR in `core/field_dropdown.ts`
* chore: cleaned up misc 'AnyDuringMigration' cases and related comments
* fix: misc adjustments from PR feedback
* Fix: simplified `getOptions`
* fix: removed outdated arrow and cleaned up formatting
* fix: cleanup format after rebase
* fix: feedback on procedure model implementations
* chore: format
* chore: add tests for the backing variable of parameter models
* chore: update existing procedure map tests
* chore: update block update tests to use refactored API
* chore: update tests to actually use fluent API
* chore: format
* chore: fix tests
* chore: reorganize tests
* chore: format
* chore: add comment
* fix: make getSourceBlock nullable again
* chore: format
* chore: move to a specific error
* chore: also update procedures with new error
* chore: format
* feat: implement basic observable procedure model
* feat: implement basic observable procedure model
* feat: implement basic observable parameter model
* feat: implement basic observable procedure map
* chore: format
* chore: refactor parameter model
* chore: update the observable procedure model to match interface
* chore: update the observable parameter model to match interface
* chore: update the observable procedure map
* chore: update concrete implementations to use this return type
* chore: format
* chore: remove legacy module IDs
* chore: fix typo
* feat: add interface definitions for procedure stuff
* fix: signature of insertParameter
* fix: remove declareModuleId
* fix: remove variable-ness from the parameter interface
* chore: types -> type
* chore: PR comments
* fix: update interfaces to use this return type
* chore: format
* Remove usages of utils.dom.add/removeClass from Blockly Factory
* Use template strings for error messages.
(Random stuff found while working on something larger.)
* chore: rename properties to remove underscores in zoom_controls.ts
* chore: remove underscores from private methods in zoom_controls.ts
* chore: fix underscores in private property names in ws_svg
* chore: format
* chore: clean up block_drag_surface.ts
* chore: remove underscores in property names in bubble.ts
* chore: remove underscores from method names in bubble.ts
* chore: format, and remove one cast
* chore: cleaned up several type cases in core/field.ts and impacted files
* chore: updated instances of `sourceBlock_!` to `getSourceBlock()`
* chore: updated instances of `fieldGroup_!` to `getSvgRoot()`
* chore: updated nullable variables in `field.ts` to use internal functions
* chore: updated getSourceBlock and getSvgRoot to handle nullability
* chore: updated comments to reference throwing an error
* fix: reverted `getSvgRoot` to `fieldGroup_` in null-accepting areas
* fix: updated `getSvgRoot` to allow null and added null handling methods
* fix: moved click target error handling to their specific cases
* fix: updated drawer.ts to handle cast svg group to defined
* refactor: Revert the Mutator/Icon constructor API changes with a deprecation warning.
* fix: Update the block definitions to use the new Mutator constructor.
* chore: regen msg dts files
* fix: package tasks not packaging msg.d.ts files
* fix: add setLocale to blockly.ts
* chore: format
* chore: move setLocale
* chore: add comment about setLocale not being useful when used with script tags
* chore: format
* fix: disposing of a workspace that has overwritten shadows
* fix: try slightly different placement to fix tests
* fix: add disposing parameter to guaruntee consistent behavior
* chore: wrap properties in a isDeadOrDying method
* chore: make disposing private
* chore: remove radix from parseInt
Previously any number starting with '0' would be parsed as octal if the radix was left blank. But this was changed years ago. It is no longer needed to specify a radix.
* chore: 'ID' is identification
'id' is a part of Freud's brain.
* Use Unicode characters instead of codes
This is in line with the current style guide.
* Simplify Blockly.utils.dom methods.
classList add/remove/has supports SVG elements in all browsers Blockly supports (i.e. not IE).
* refactor: Remove uses of AnyDuringMigration from workspace_comment.ts
* refactor: Remove uses of AnyDuringMigration from separator.ts.
* refactor: Remove uses of AnyDuringMigration from category.ts.
* refactor: Remove uses of AnyDuringMigration from rendered_connection.ts.
* refactor: Removed uses of AnyDuringMigration from flyout_metrics_manager.ts.
* refactor: Remove uses of AnyDuringMigration from dom.ts.
core/blockly.js was removed from the ts/migration branch in PR #6261,
but for some reason when ts/migration was merged into develop via
a two step process something went wrong:
* as expected, blockly.js got renamed to blockly.ts in PR #6297, but
* for some reason it got re-added under its original name in PR #6299.
Since the file should not exist, is not used, and has proven to
cause confusion (to me at least!), delete it again, hopefully for
good this time.
