Commit Graph

4188 Commits

Author SHA1 Message Date
Monica Kozbial
a14ac351b5 Adding checks for whether to add elem spacer on row ends (#3060)
* Adding checks for whether elem spacer shouldbe added to start and end of row.

* Fix eslint and add package visibility.
2019-09-20 14:20:14 -07:00
Beka Westberg
e053084621 Changed dropdown field to use new configuration. (#3061) 2019-09-20 13:35:13 -07:00
Monica Kozbial
a8af9fea21 Move populate for topRow and bottomRow to info (#3057)
* Move populate for topRow and bottomRow from measurable definition to info.

* Fix local variable and circular dependency.
2019-09-20 13:24:46 -07:00
Beka Westberg
9e5df6216a Fixed comment ownership. (#2923)
* Moved comment icons to use a model-based system. The block holds the model of the comment, and the comment icon holds a reference to it.
* Reorganized the setVisible function.
* Changed how xml.js serializes and deserializes comments.
2019-09-20 13:16:07 -07:00
Neil Fraser
0726e4a909 Removed unreachable functions from Blockly.Component 2019-09-20 10:36:06 -07:00
Neil Fraser
02fc5bf19c Remove empty span from toolbox.
Every row started with this useless tag:
<span role=“presentation”></span>
2019-09-20 10:36:06 -07:00
Neil Fraser
fb17b0276d Remove unused CSS classes. 2019-09-20 10:36:06 -07:00
Neil Fraser
28953d8ea0 Simplify Blockly.utils.IdGenerator
Also drop unused menu highlight hook.
2019-09-20 10:36:06 -07:00
Neil Fraser
be24605b27 Strip 200 lines of unreachable code
There’s a lot more junk in here, this is just a quick first pass.
2019-09-20 10:36:06 -07:00
Neil Fraser
823c1c98a8 Make toolbox an optional module.
This drops the compiled size by 25 kb if there are no categories.  Which also indicates that the toolbox itself suffers from really bad bloat.  The toolbox should not represent 1/6th of our codebase.
2019-09-20 10:36:06 -07:00
alschmiedt
8e22e45bca Fix inserting into middle of stack from flyout (#3058) 2019-09-20 09:00:44 -07:00
Sam El-Husseini
cb564053b3 Merge toolbox navigation (#3054)
* Merge both types of keyboard navigation (with and without accessibility mode).
2019-09-19 16:36:39 -07:00
Beka Westberg
1c3db256fa Added angle field config (#3038)
* Added angle field configuration.
2019-09-19 16:15:20 -07:00
alschmiedt
6516363469 Change setLocation to setCurNode (#3051)
* Change setLocation to setCurNode
2019-09-19 15:15:14 -07:00
Neil Fraser
a1e3973499 Make block comments an optional module. (#3053)
Measured as a 5 KB *increase* in code size, but that's because some other commit just landed between my tests. It's like running down an up escalator.
2019-09-19 14:53:28 -07:00
Sam El-Husseini
57c8e3dded Rendering: Fix setting the path in RTL (#3047)
* Fix setting the RTL path.
2019-09-19 14:44:44 -07:00
alschmiedt
8003426316 Cleanup compile warnings (#3050)
* Cleanup jsdoc issues

* Cleanup compile warnings

* Fix jsdocs

* Removed unnecessary cast
2019-09-19 14:34:25 -07:00
alschmiedt
abb5ae6d23 Add key map demo (#3042)
* Merge with develop

* Update jsdocs
2019-09-19 13:02:02 -07:00
Neil Fraser
84a814cda1 Make mutator an optional module. (#3048) 2019-09-19 11:39:55 -07:00
Monica Kozbial
97268e665b Merge pull request #3037 from moniika/moniika-cursorDrawerOnRenderer
Creating cursordrawer in renderer.
2019-09-19 10:41:58 -07:00
kozbial
60e6b8c6df style and doc updates. 2019-09-19 10:38:23 -07:00
kozbial
c533a0d943 Setting cursor and marker directly in Workspace and adding check to setCursor/setDrawer. 2019-09-19 10:38:23 -07:00
kozbial
3d06e7eb33 Creating cursordrawer in renderer. 2019-09-19 10:38:23 -07:00
Beka Westberg
d82a0ae0b8 Fixed scrolling the trashcan flyout with mouse. (#3045) 2019-09-19 08:37:40 -07:00
translatewiki.net
585e860395 Localisation updates from https://translatewiki.net. 2019-09-19 11:33:38 +02:00
Sam El-Husseini
22cf08d16c Don't insert disabled blocks from the flyout. (#3046)
* Don't insert disabled blocks from the flyout.
2019-09-18 16:42:25 -07:00
Beka Westberg
a8a8c320d5 Changed multiline field to use new configuration (#3044)
* Changed multilineinput field to new configuration.
2019-09-18 16:30:17 -07:00
Beka Westberg
093467aed1 Added More Procedure Unit Tests (#2630)
* Added more procedure unit tests.

* Cleanup from rebase.

* Cleanup.
2019-09-18 16:14:06 -07:00
Neil Fraser
ec34698c53 Make trashcan and zoomcontrols optional modules. (#3043)
Saves 6 KB when compiled if there is no trashcan nor zoomcontrols.
2019-09-18 15:55:12 -07:00
Neil Fraser
ebdaf4dd46 Remove now unneeded requires from compile test. 2019-09-18 13:38:44 -07:00
Sam El-Husseini
c524980f31 Cache dynamic dropdown options (#3036)
* Cache dynamic dropdown options and only re-generate on initialization and render.
2019-09-18 13:05:25 -07:00
Sam El-Husseini
7d76cafd61 Apply the same patch to the gulp build script. 2019-09-18 13:00:44 -07:00
Neil Fraser
63dd911338 Use regular expressions to simplify removals. 2019-09-18 13:00:44 -07:00
Neil Fraser
0add3a5e3e Add require statements to all block files. 2019-09-18 13:00:44 -07:00
alschmiedt
8b3d48b148 Update demo (#3033)
* Update the cursor demo to use the basic cursor

* Change <br> to <br />
2019-09-18 12:01:50 -07:00
Sam El-Husseini
8fae0411f7 Check if a type exists before testing instanceof (#3031)
* Check if a type exists before instance of
2019-09-17 16:28:18 -07:00
Sam El-Husseini
99c624db34 Fix Blockly.utils.global when wrapped in a module. (#3035)
* Fix Blockly.utils.global when wrapped in a module.
2019-09-17 14:07:03 -07:00
alschmiedt
9004346f7d Remove moving on the workspace (#3029)
* Remove moving on the workspace
2019-09-17 10:58:34 -07:00
Neil Fraser
d9fd214850 Simplify build script (#3020)
* Remove unused imports and reorder.
* Compute default values during argument parsing, not at every end-point.
* Always rebuild JSON messages, since it just takes a split second.  Removes a complicated file-timestamp check.
* Describe what “old argument style” is, and treat it more strictly.
* Restore Python 3 compatibility (injecting Blockly version number only works on strings, not bytes).
2019-09-16 17:26:29 -07:00
Monica Kozbial
e551db41e0 Merge pull request #3017 from moniika/moniika-debug-render-checkmarks
Adding checkboxes for debug rendering options to playground.
2019-09-16 17:18:32 -07:00
kozbial
94dd4e609b htmlFor > for 2019-09-16 17:16:25 -07:00
Neil Fraser
51fedc6fdb Fix compiled test. (#3030) 2019-09-16 17:05:45 -07:00
kozbial
550c13739c Removing foreach usage. 2019-09-16 17:04:18 -07:00
Beka Westberg
92eea22628 Label Field Config (#2984)
* Added label field configuration.
2019-09-16 16:53:06 -07:00
Neil Fraser
bbd76368e2 Test commit 2019-09-16 16:20:51 -07:00
Neil Fraser
ff33d923a2 Fix compile test.
(partially)
LGTM in person by Sam.
2019-09-16 16:15:34 -07:00
Sam El-Husseini
5cb203167e Test commit 2019-09-16 16:14:56 -07:00
Sam El-Husseini
d9fcfdbc07 Blockly entry point (#3019)
* Move fields and renderers into their own entry point so folks are able to be more selective about which fields and renderers they include in their bundle.
2019-09-16 12:36:02 -07:00
alschmiedt
2c98ecaed6 Update APIs and Add New Cursor Look (#3009)
* Updates methods to be private in navigation.js

* Update cursor with new look
2019-09-16 12:33:43 -07:00
Rachel Fenichel
77185906d8 Renderers define which paths a block has. (#2981)
* Move render elements into a path object.
2019-09-16 12:13:32 -07:00