Neil Fraser
a385f3c2a6
Enable extraction of names from name DB.
...
Also gets rid of hacky name_realm contatination.
2021-05-27 21:30:26 -07:00
Neil Fraser
2f2252f588
Rename variableDB_ to nameDB_
...
There is significant confusion in names and comments with regards to variables and procedures. `Blockly.Generator.prototype.variableDB_` is a Blockly.Names database, not a variable map. This rename introduces a getter and setter so deprecated references still work. This commit also fixes some comments which are either outright wrong or misleading regarding variable and procedure names.
2021-05-27 21:30:26 -07:00
Beka Westberg
5ffd43824f
Change lastConnectionInRow to getPlaceForOrphanedOutput - Take 2 ( #4851 )
...
* Change lastConnectionInRow to getPlaceForOrphanedOutput
* PR comments
2021-05-26 09:16:33 -07:00
Beka Westberg
9fbf06c5df
PR Comments
2021-04-27 15:59:25 -07:00
Beka Westberg
43e95af14e
Fix getDefinition being too restrictive
2021-04-25 14:46:51 -07:00
Monica Kozbial
5139057664
Merge consecutive viewport change events ( #4792 )
2021-04-23 10:56:52 -07:00
Sam El-Husseini
d83279008b
Remove dark theme in favour of @blockly/theme-dark ( #4697 )
...
* Remove dark theme in favour of @blockly/theme-dark
2021-04-21 13:33:59 -07:00
Rachel Fenichel
e8d95c9137
Remove compile.sh
2021-04-13 14:28:54 -07:00
alschmiedt
91c060f872
Update metadata March 2021 ( #4738 )
2021-03-25 17:53:29 -07:00
Monica Kozbial
62dc2ff6fa
Include oldCoordinate and oldContents in ws comment event serialization ( #4718 )
...
* Include oldCoordinate and oldContent in ws comment event serialization
2021-03-22 08:41:31 -07:00
Monica Kozbial
7eabb8e8a3
Update inccorect jsdoc in mocha tests ( #4707 )
2021-03-19 16:33:41 -07:00
alschmiedt
9a93ca486f
Fix advanced compilation tests for Q1 2021 release ( #4709 )
2021-03-17 15:46:17 -07:00
alschmiedt
c6b8791ece
Update chrome driver version ( #4710 )
2021-03-17 12:56:10 -07:00
alschmiedt
d58c80db76
Refactor flyout and toolbox metrics ( #4648 )
2021-03-15 12:37:23 -07:00
alschmiedt
869e4eb366
Update flyout metrics to work with the new metrics manager ( #4684 )
2021-03-09 17:09:49 -08:00
Sam El-Husseini
17d2e72ab0
Fix circular dependencies in shortcut + contextmenu registries ( #4681 )
...
* Fix circular dependencies in shortcut and contextmenu registries
2021-03-08 13:35:11 -08:00
Rachel Fenichel
855185c6cf
Merge pull request #4682 from rachel-fenichel/toolbox_constants
...
Use Blockly.utils.toolbox.Position enum everywhere
2021-03-08 10:52:58 -08:00
Monica Kozbial
f837f1e44e
Add zoom support for single-direction-scroll ( #4653 )
...
* Add zoom support for single-direction scroll
2021-03-05 14:37:41 -08:00
Rachel Fenichel
f7e0d5f4ea
Use existing toolbox position enum
2021-03-05 14:16:43 -08:00
Rachel Fenichel
59084a043c
TOOLBOX_AT_TOP and friends -> constants.toolboxPosition.TOP, etc
2021-03-05 13:48:45 -08:00
Monica Kozbial
57749e6eb8
Updating bump logic to support single-direction scrollbars ( #4652 )
...
* Updating bump logic to support single-direction scrollbars
2021-03-01 12:20:12 -08:00
Rachel Fenichel
485e4cd505
Fix test
2021-02-26 11:25:10 -08:00
Rachel Fenichel
4e31deca2b
Align constants -> Blockly.constants.ALIGN enum
2021-02-26 11:12:53 -08:00
alschmiedt
7b30cc76a4
Adds tests for metrics manager ( #4635 )
2021-02-18 13:45:53 -08:00
alschmiedt
a8f28c6b11
Metrics refactor ( #4627 )
2021-02-10 16:19:56 -08:00
Beka Westberg
87f4799be7
Remove last FieldLabel call and fix adding dummy inputs to json ( #4601 )
...
* Change insertFieldAt to use registry
* Fix adding dummy input for non field_ prefixed fields
* Remove bad new keyword
* Add type cast
2021-02-05 16:03:32 -08:00
alschmiedt
26beff4b2c
Migrate our tests to use github actions ( #4614 )
2021-02-02 10:08:51 -08:00
Beka Westberg
75f118b4f9
Refactor interpolate_ into multiple functions & remove direct new Field call ( #4585 )
...
* Refactor interpolation
* Added docs
* Add tests
* Add test for dummy input after field not prefixed with field_
* Fix typings
* Pr comments
2021-01-22 12:44:50 -08:00
alschmiedt
a3adc42e8a
Remove keyboard navigation from core ( #4593 )
2021-01-19 11:50:51 -08:00
Monica Kozbial
540ab16842
Fix serialization of workspace comment events and add tests ( #4578 )
...
* Fix serialization of workspace comment events and add tests
2021-01-11 16:14:34 -08:00
alschmiedt
fe0f401977
Fix collapsing bug and add tests ( #4568 )
2021-01-11 09:05:59 -08:00
Fishuke
16979f7458
Fix misplaced percent sign in css, close iframe html tag ( #4560 )
2021-01-05 11:09:37 -08:00
alschmiedt
be317617f9
Updates the metadata information ( #4550 )
2020-12-17 16:29:42 -08:00
alschmiedt
1043257f87
Fix ios12 bug ( #4517 )
...
* Changes mousedown to click event
2020-12-11 09:47:35 -08:00
Monica Kozbial
b5e045fd2b
Unskip test that is now passing ( #4493 )
2020-12-03 11:04:18 -08:00
alschmiedt
520aa600a6
Remove deprecated field functions ( #4489 )
2020-12-02 14:54:28 -08:00
Monica Kozbial
5153a32424
Remove debugging console log from test ( #4482 )
2020-11-30 14:22:43 -08:00
alschmiedt
97117bdb12
Update method names in shortcut registry ( #4479 )
2020-11-30 10:52:09 -08:00
Maribeth Bottorff
b5c77137bd
factor out getX and getY methods for flyouts ( #4463 )
2020-11-19 10:12:06 -08:00
Monica Kozbial
7a048bdb47
Add tests to logic ternary block ( #4427 )
...
* Add tests to logic ternary block
* Fix lint
2020-11-18 14:21:56 -08:00
Sam El-Husseini
67a6bfd0cf
Fix travis
2020-11-17 14:15:51 -08:00
Monica Kozbial
dd0d5aee53
Adding procedure tests and handling procedures instantiated without name ( #4428 )
...
* Expand procedure tests and fix bug with default ids
* Add tests
* Remove xml_procedures_test.js and add non-overlapping test cases into procedures_test.js
2020-11-06 11:48:48 -08:00
Monica Kozbial
8361268c63
Refactor field_variable_tests to use dev-tools ( #4417 )
...
* Refactor field_variable_tests to use dev-tools
2020-11-06 11:35:00 -08:00
Monica Kozbial
637497148d
Renaming ui event properties and updating documentation for consistency ( #4432 )
...
* Renaming properties and updating documentation for consistency
* Update more properties
* fix tests
2020-11-05 11:40:17 -08:00
Monica Kozbial
40ef586260
Refactoring Ui events in core ( #4418 )
...
* Ui events base (#4370 )
* Add constants for new ui event types
* Add property to indicate an event as UI event
* Click events (#4372 )
* Creating new ui base class.
* Refactor theme event (#4391 )
* Add themeName property to theme event
* Refactor marker move events. (#4389 )
* Refactor trashcan open event (#4392 )
* Refactor selected event (#4387 )
* Refactor toolbox item change event (#4394 )
* Refactor bubble open events (#4390 )
* Refactor block drag event (#4388 )
* Viewport events (#4395 )
* Fix event filtering for ui events (#4401 )
* Move events to new directory and rename Ui events base (#4400 )
* Move events to new directory and rename Ui events base
* Add missing fromJson implementation for click event (#4410 )
* Adding serialization tests for events
* Zoom controls event (#4407 )
* Refactor zoom event
* Rename IS_UI_EVENT to isUiEvent
2020-11-04 14:43:54 -08:00
Monica Kozbial
9bcfa60e86
Add missing cleanup to multiline field test ( #4416 )
2020-11-02 16:37:17 -08:00
alschmiedt
f1498e7f07
Keyboard shortcuts ( #4421 )
...
* Adds shortcut registry and removes action and key map (#4398 )
* Adds Shortcut tests and refactored navigation tests (#4412 )
* Adds shortcut items (#4408 )
* Add shortcuts for navigation (#4409 )
* Add final keyboard shortcut cleanup (#4413 )
2020-11-02 13:30:05 -08:00
alschmiedt
7eb9c498e6
Test Blockly.onKeyDown method ( #4373 )
2020-10-16 11:26:32 -07:00
Halit Anil Donmez
9bafa7e40d
do value update if the value is valid again ( #4351 )
...
* do value update if the value is valid again
* update the logic at set value
* fix tests
* update logging
2020-10-07 11:05:02 -07:00
Monica Kozbial
3b1643f221
Refactor FieldImage tests to use dev-tools helpers ( #4315 )
...
* Refactor FieldImage tests to use dev-tools helpers
2020-10-07 10:43:44 -07:00