Commit Graph

3949 Commits

Author SHA1 Message Date
Rachel Fenichel
a9b0b199e3 chore: clean up some underscores (#6492)
* chore: clean up block_drag_surface.ts

* chore: remove underscores in property names in bubble.ts

* chore: remove underscores from method names in bubble.ts

* chore: format, and remove one cast
2022-10-11 15:48:21 -07:00
Beka Westberg
ca3b9bd079 fix: move Theme to use a Partial type for BlockStyle (#6532)
* fix: move theme to use Partial type

* chore: remove useless error throwing

* chore: format

* chore: update validatedBlockStyle_ to use Partial
2022-10-11 15:40:56 -07:00
koenvanwijk
581e8acf4b fix: Connections can be highlighted multiple times (#6502)
* fix: Connections can be highlighted multiple times

* fix: remove spaces to fix clang-formating
2022-10-10 11:34:27 -07:00
Beka Westberg
a263587ca0 chore: rearrange serialization export to make APIExtractor happy (#6480)
* chore: rearrange serialization export to make APIExtractor happy

* chore: format
2022-10-05 13:43:07 -07:00
Neil Fraser
84f6dfef4f Fix: // isn't a legal comment in CSS (#6467) 2022-10-05 06:38:32 +02:00
YAMADA Yutaka
2a2cbb4722 fix: Modifying size update handling for multiline field in parent block. (#6461) 2022-10-03 11:48:57 -07:00
Beka Westberg
d3447ea565 fix!: Update deprecations for the new release. (#6470)
* chore: bump early deprecations to v10

* fixup

* fixup

* chore: remove deprecated properties

* chore: add missing @deprecated tags

* chore: format

* chore: format

* chore: fix import
2022-10-03 11:21:52 -07:00
Blake Thomas Williams
e0b60cbf8a chore: fixed tsdoc missing deprecation messages (#6460)
* chore: added missing deprecation messages for `core/renderers/common/block_rendering.ts`

* chore: added missing deprecation messages for `core/utils.ts`

* chore: updated format

* fix: reverted runAfterPageLoad to internal and updated messaging
2022-09-30 14:25:44 -07:00
Blake Thomas Williams
fa925e8c35 chore: cleaned up several type cases in core/field.ts and impacted files (#6363)
* chore: cleaned up several type cases in core/field.ts and impacted files

* chore: updated instances of `sourceBlock_!` to `getSourceBlock()`

* chore: updated instances of `fieldGroup_!` to `getSvgRoot()`

* chore: updated nullable variables in `field.ts` to use internal functions

* chore: updated getSourceBlock and getSvgRoot to handle nullability

* chore: updated comments to reference throwing an error

* fix: reverted `getSvgRoot` to `fieldGroup_` in null-accepting areas

* fix: updated `getSvgRoot` to allow null and added null handling methods

* fix: moved click target error handling to their specific cases

* fix: updated drawer.ts to handle cast svg group to defined
2022-09-30 08:53:19 -07:00
Rachel Fenichel
dd0d0f6bcf fix(tests): revert change in marker_svg to keep keyboard nav tests working (#6457) 2022-09-30 08:03:13 -07:00
Beka Westberg
8530e6d537 fix: adding and removing css classes that contained spaces (#6455)
* fix: adding CSS classes

* fix: removing css classes

* fix: add a test for multiple icon classes

* chore: format
2022-09-28 15:51:17 -07:00
Beka Westberg
f678531389 chore: remove AnyDuringMigration from events (#6382)
* chore: remove AnyDuringMigration from events

* chore: format

* chore: lint

* chore: fix tests

* fix: correct types for JSON properties

* chore: fix tests

* refactor: replace exclamation markers with errors

* chore: fix build and tests

* chore: set event types as members, rather than in constructor

* chore: update comment

* chore: export new types

* chore: format

* chore: remove unnecessary override

* chore: change how we're overriding isBlank

* chore: remove unnecessary ?

* chore: remove non-null assertion in block move event

* chore: format

* chore: revert changes to isNull

* chore: format
2022-09-27 15:08:05 -07:00
Beka Westberg
eb1b78663c fix: field defaults not being defined correctly (#6453) 2022-09-27 14:53:44 -07:00
Aaron Dodson
ab03c65f9f fix: Fix blocks with mutators. (#6440)
* refactor: Revert the Mutator/Icon constructor API changes with a deprecation warning.

* fix: Update the block definitions to use the new Mutator constructor.
2022-09-27 13:42:52 -07:00
Beka Westberg
9c81e7591a fix: message types being incorrect (#6414)
* chore: regen msg dts files

* fix: package tasks not packaging msg.d.ts files

* fix: add setLocale to blockly.ts

* chore: format

* chore: move setLocale

* chore: add comment about setLocale not being useful when used with script tags

* chore: format
2022-09-26 14:02:57 -07:00
Beka Westberg
893787b285 fix: path object not checking theme props (#6451)
* fix: path object not checking theme props

* fix: error msgs
2022-09-26 13:58:57 -07:00
Beka Westberg
abad51fdb0 fix: theme types (#6423)
* chore: fix theme types

* chore: format
2022-09-26 12:52:46 -07:00
Beka Westberg
f2e408b6fa fix: disposing of a workspace that has overwritten shadows (#6424)
* fix: disposing of a workspace that has overwritten shadows

* fix: try slightly different placement to fix tests

* fix: add disposing parameter to guaruntee consistent behavior

* chore: wrap properties in a isDeadOrDying method

* chore: make disposing private
2022-09-26 12:37:36 -07:00
Neil Fraser
e5dcb766bd chore: Remove radix from parseInt, simplify Blockly.utils.dom methods, use Unicode characters. (#6441)
* chore: remove radix from parseInt

Previously any number starting with '0' would be parsed as octal if the radix was left blank.  But this was changed years ago.  It is no longer needed to specify a radix.

* chore: 'ID' is identification

'id' is a part of Freud's brain.

* Use Unicode characters instead of codes

This is in line with the current style guide.

* Simplify Blockly.utils.dom methods.

classList add/remove/has supports SVG elements in all browsers Blockly supports (i.e. not IE).
2022-09-22 06:59:24 -07:00
Aaron Dodson
c84febbe07 refactor: Remove more uses of AnyDuringMigration (#6439)
* refactor: Remove uses of AnyDuringMigration from workspace_comment.ts

* refactor: Remove uses of AnyDuringMigration from separator.ts.

* refactor: Remove uses of AnyDuringMigration from category.ts.

* refactor: Remove uses of AnyDuringMigration from rendered_connection.ts.

* refactor: Removed uses of AnyDuringMigration from flyout_metrics_manager.ts.

* refactor: Remove uses of AnyDuringMigration from dom.ts.
2022-09-21 12:28:35 -07:00
Rachel Fenichel
c2cbed1146 fix: some AnyDuringMigration (#6430)
* fix: remove some AnyDuringMigrations

* fix: some instances of AnyDuringMigration

* fix: some AnyDuringMigration

* chore: revert comment removal
2022-09-15 12:48:40 -07:00
Christopher Allen
c063d12abb chore: Re-remove core/blockly.js (#6422)
core/blockly.js was removed from the ts/migration branch in PR #6261,
but for some reason when ts/migration was merged into develop via
a two step process something went wrong:

* as expected, blockly.js got renamed to blockly.ts in PR #6297, but
* for some reason it got re-added under its original name in PR #6299.

Since the file should not exist, is not used, and has proven to
cause confusion (to me at least!), delete it again, hopefully for
good this time.
2022-09-14 18:11:14 +01:00
Neil Fraser
05b221b1d6 fix: Deep copy options used by dropdown fields (#6425)
This uncovered a broken test that was only passing because of a side effect of the dropdown option data getting modified.
2022-09-13 13:29:38 -07:00
Rachel Fenichel
e3fa43d861 feat: return element from menu.render (#6426)
* feat: return element from menu.render

* chore: format

* chore: add returns annotation
2022-09-13 13:29:18 -07:00
Rachel Fenichel
5f11f3449f fix: remove calls to removeClass and hasClass (#6413)
* fix: stop using dom.addClass in most cases

* chore: format

* fix: remove use of dom.addClass in toolbox

* chore: lint and format

* fix: add checks around non-constant class names

* fix: switch back to quoted access

* chore: format

* fix: remove calls to removeClass

* chore: format

* chore: remove unused deps

* fix: remove uses of hasClass

* chore: format and lint

* chore: format
2022-09-13 08:33:49 -07:00
Beka Westberg
26561947fb chore: remove AnyDuringMigration from the other renderers (#6409)
* chore: remove AnyDuringMigration from geras renderer

* chore: more removing AnyDuringMigration from renderers

* chore: remove AnyDuringMigration from constants

* chore: format

* chore: work on PR comments

* chore: fix typo and resulting build issues
2022-09-12 15:01:01 -07:00
Beka Westberg
b5cd839000 chore: remove AnyDuringMigration from common renderer (#6402)
* chore: remove AnyDuringMigration from common renderer

* chore: remove AnyDuringMigration in common drawer

* chore: format

* chore: add dividers back

* chore: format
2022-09-11 13:06:41 -07:00
Beka Westberg
d754c6d278 chore: remove AnyDuringMigration from gesture code (#6401)
* chore: work on refactoring gesture code

* chore: reorganize throw order

* chore: format

* chore: PR comments

* chore: format
2022-09-09 16:29:06 -07:00
Christopher Allen
5d3ba79ab3 fix!(connection): Correctly handle multiple highlighted connections (#6416)
Modify RenderedConnection.prototype.highlight and .unhighlight to
store the highlight path on this rather than as a static property
on Connection (which is where it had been stored since this
functionality was originally created, previously to RenderedConnection
and Connection being split).
2022-09-09 18:00:59 +01:00
ktbytechibong
e58cf77b7f fix: TS errors on dependent projects with certain tsconfig settings (#6360) (#6361)
* fix: TS errors on dependent projects with certain tsconfig settings (#6360)

* Address PR comments
2022-09-06 13:19:56 -07:00
Maribeth Bottorff
ec72e8bb4d chore: add api extractor configuration and fix some associated problems (#6388)
* chore: add configuration for api extractor

* fix: remove extra param names

* chore: private to internal

* remove unrestricted

* chore: remove double backticks

* chore: remove fileoverview and export * as

* chore: return to returns

* chore: fix backslashes and angle brackets in tsdoc

* chore: final to sealed

* chore: ignore to internal

* chore: fix link tags

* chore: add api-extractor configuration

* chore: add unrecognized tag names

* chore: remove tsdoc-metadata

* fix: correct index.d.ts

* chore: fix connection link
2022-09-01 11:39:05 -07:00
Rachel Fenichel
55ea12bd21 fix: stop using is3dSupported (#6400)
* fix: remove prefix checks from is3dSupported

* fix: stop using is3dSupported

* chore: mark is3dSupported deprecated

* chore: fix lint
2022-08-31 12:59:16 -04:00
Beka Westberg
21237c9362 chore: remove AnyDuringMigration from the insertion marker manager (#6398)
* chore: remove AnyDuringMigration from the insertion marker manager

* chore: fix final issues

* chore: format
2022-08-31 09:27:23 -07:00
Beka Westberg
79051a69db fix: context menu not working (#6399) 2022-08-31 08:00:45 -07:00
Rachel Fenichel
9775b5138b fix: deprecate functions in object.ts (#6387)
* fix: deprecate functions in object.ts

* chore: update deprecation dates and formats

* chore: redo deprecation dates again
2022-08-30 19:20:24 -04:00
Rachel Fenichel
a785ab8d9c fix: remove some IE-specific code in dom and style (#6396)
* fix: remove some IE-specific code in dom and style

* fix: delete unnecessary getStyle function
2022-08-30 15:49:06 -04:00
Rachel Fenichel
856e74d9cf fix!: remove unused functions in style.ts (#6386) 2022-08-26 16:03:16 -04:00
Aaron Dodson
3bc42c5c3f refactor!: Removed backwards compatibility for getDeveloperVars(). (#6385) 2022-08-25 13:32:45 -07:00
Aaron Dodson
3a36ed5116 refactor: Remove more uses of AnyDuringMigration. (#6383)
* refactor: Remove uses of AnyDuringMigration from flyout_base.ts.

* refactor: Remove uses of AnyDuringMigration from flyout_metrics_manager.ts.

* refactor: Remove uses of AnyDuringMigration from variables_dynamic.ts.

* refactor: Remove uses of AnyDuringMigration from procedures.ts.

* refactor: Remove uses of AnyDuringMigration from generator.ts.

* refactor: Remove some uses of AnyDuringMigration from menu.ts.

* refactor: Remove uses of AnyDuringMigration from mutator.ts.

* refactor: Remove uses of AnyDuringMigration from variables.ts.

* refactor: Remove uses of AnyDuringMigration from array.ts.

* refactor: Remove uses of AnyDuringMigration from aria.ts.

* refactor: Remove uses of AnyDuringMigration in basic_cursor.ts.

* refactor: Remove uses of AnyDuringMigration in dropdowndiv.ts.

* refactor: Remove uses of AnyDuringMigration in utils.ts.

* refactor: Remove uses of AnyDuringMigration from menuitem.ts.

* refactor: Remove uses of AnyDuringMigration from idgenerator.ts.

* refactor: Remove uses of AnyDuringMigration in block_animations.ts.

* refactor: Initialize definitions and functionNames in generator.ts by default.
2022-08-24 16:06:38 -07:00
Rachel Fenichel
e50ad59ffe chore: remove underscores from private properties in grid.ts (#6375)
* chore: remove underscores from private properties in grid.ts

* chore: remove unused property
2022-08-24 16:42:49 -04:00
Maribeth Bottorff
60bc01acc8 fix: make eventUtils throw if event type not registered (#6381)
* chore: update lint rules

* fix: have eventUtils.get throw if event isn't found

* chore: remove nonnull assertion from eventUtils.get and format
2022-08-24 13:41:32 -07:00
Aaron Dodson
980fe138e7 refactor: Mark optional parameters as optional. (#6380)
* refactor: Mark optional params as optional.

* refactor: Slightly narrow the typing of rendererOverrides.
2022-08-24 13:19:37 -07:00
Aaron Dodson
1f6481e527 chore: Removed commented-out side-effect-only imports. (#6379) 2022-08-24 11:28:09 -07:00
Aaron Dodson
57a5d0d49c refactor: Remove more uses of AnyDuringMigration (#6378)
* refactor: Remove uses of AnyDuringMigration from flyout_vertical.ts.

* refactor: Remove uses of AnyDuringMigration in flyout_horizontal.ts.

* refactor: Remove uses of AnyDuringMigration from zoom_controls.ts.

* refactor: Remove uses of AnyDuringMigration from comment.ts.

* refactor: Remove uses of AnyDuringMigration from dialog.ts.

* refactor: Remove uses of AnyDuringMigration from icon.ts.

* refactor: Remove uses of AnyDuringMigration from scrollbar_pair.ts.

* refactor: Remove uses of AnyDuringMigration from workspace_audio.ts.

* refactor: Remove uses of AnyDuringMigration from workspace_drag_surface_svg.ts.
2022-08-23 15:36:52 -07:00
Beka Westberg
7698c072d3 chore: remove AnyDuringMigration from dropdown and widget divs (#6377)
* chore: remove AnyDuringMigration from dropdown div

* chore: remove AnyDuringMigration from widget div

* chore: format
2022-08-23 15:26:10 -07:00
Maribeth Bottorff
037eb59b89 chore: Lint TsDoc. (#6353)
* chore: add linting for tsdoc

* chore: don't require types on return

* chore: remove redundant fileoverview from ts

* chore: change return to returns and add some newlines

* chore: remove license tag

* chore: don't require params/return docs

* chore: remove spurious struct tags

* Revert "chore: change return to returns and add some newlines"

This reverts commit d6d8656a45.

* chore: don't auto-add param names

* chore: disable require-param bc it breaks on this

* return to returns and add line breaks

* chore: configure additional jsdoc rules

* chore: run format

* Revert "chore: remove license tag"

This reverts commit 173455588a.

* chore: allow license tag format

* chore: only require jsdoc on exported items

* chore: add missing jsdoc or silence where needed

* chore: run format

* chore: lint fixes
2022-08-23 14:27:22 -07:00
Beka Westberg
bb37d1b7aa chore: remove instances of AnyDuringMigration in icons code (#6376)
* chore: remove AnyDuringMigration from icon

* chore: remove AnyDuringMigration from comment

* chore: remove AnyDuringMigration in warning

* chore: remove anyDuringMigration from mutator

* chore: format
2022-08-23 14:23:40 -07:00
Beka Westberg
7f6df7d562 chore: format css (#6373)
* chore: format css

* chore: convert css to templates

* chore: disable clang-formatting geras css

* chore: clang format
2022-08-23 11:18:33 -07:00
Beka Westberg
b1b4aa06c3 chore: remove alt dynamic shape definition (#6374)
* chore: remove alt dynamic shape definition

* chore: format
2022-08-23 08:26:17 -07:00
Aaron Dodson
76b1e023e3 chore: Fix no-inferrable-types lint rule violations. (#6372) 2022-08-22 14:42:41 -07:00