* chore: remove radix from parseInt
Previously any number starting with '0' would be parsed as octal if the radix was left blank. But this was changed years ago. It is no longer needed to specify a radix.
* chore: 'ID' is identification
'id' is a part of Freud's brain.
* Use Unicode characters instead of codes
This is in line with the current style guide.
* Simplify Blockly.utils.dom methods.
classList add/remove/has supports SVG elements in all browsers Blockly supports (i.e. not IE).
* refactor: Remove uses of AnyDuringMigration from workspace_comment.ts
* refactor: Remove uses of AnyDuringMigration from separator.ts.
* refactor: Remove uses of AnyDuringMigration from category.ts.
* refactor: Remove uses of AnyDuringMigration from rendered_connection.ts.
* refactor: Removed uses of AnyDuringMigration from flyout_metrics_manager.ts.
* refactor: Remove uses of AnyDuringMigration from dom.ts.
core/blockly.js was removed from the ts/migration branch in PR #6261,
but for some reason when ts/migration was merged into develop via
a two step process something went wrong:
* as expected, blockly.js got renamed to blockly.ts in PR #6297, but
* for some reason it got re-added under its original name in PR #6299.
Since the file should not exist, is not used, and has proven to
cause confusion (to me at least!), delete it again, hopefully for
good this time.
* fix: stop using dom.addClass in most cases
* chore: format
* fix: remove use of dom.addClass in toolbox
* chore: lint and format
* fix: add checks around non-constant class names
* fix: switch back to quoted access
* chore: format
* fix: remove calls to removeClass
* chore: format
* chore: remove unused deps
* fix: remove uses of hasClass
* chore: format and lint
* chore: format
* chore: remove AnyDuringMigration from geras renderer
* chore: more removing AnyDuringMigration from renderers
* chore: remove AnyDuringMigration from constants
* chore: format
* chore: work on PR comments
* chore: fix typo and resulting build issues
* chore: remove AnyDuringMigration from common renderer
* chore: remove AnyDuringMigration in common drawer
* chore: format
* chore: add dividers back
* chore: format
Modify RenderedConnection.prototype.highlight and .unhighlight to
store the highlight path on this rather than as a static property
on Connection (which is where it had been stored since this
functionality was originally created, previously to RenderedConnection
and Connection being split).
* refactor: Remove uses of AnyDuringMigration from flyout_base.ts.
* refactor: Remove uses of AnyDuringMigration from flyout_metrics_manager.ts.
* refactor: Remove uses of AnyDuringMigration from variables_dynamic.ts.
* refactor: Remove uses of AnyDuringMigration from procedures.ts.
* refactor: Remove uses of AnyDuringMigration from generator.ts.
* refactor: Remove some uses of AnyDuringMigration from menu.ts.
* refactor: Remove uses of AnyDuringMigration from mutator.ts.
* refactor: Remove uses of AnyDuringMigration from variables.ts.
* refactor: Remove uses of AnyDuringMigration from array.ts.
* refactor: Remove uses of AnyDuringMigration from aria.ts.
* refactor: Remove uses of AnyDuringMigration in basic_cursor.ts.
* refactor: Remove uses of AnyDuringMigration in dropdowndiv.ts.
* refactor: Remove uses of AnyDuringMigration in utils.ts.
* refactor: Remove uses of AnyDuringMigration from menuitem.ts.
* refactor: Remove uses of AnyDuringMigration from idgenerator.ts.
* refactor: Remove uses of AnyDuringMigration in block_animations.ts.
* refactor: Initialize definitions and functionNames in generator.ts by default.
* refactor: Remove uses of AnyDuringMigration from flyout_vertical.ts.
* refactor: Remove uses of AnyDuringMigration in flyout_horizontal.ts.
* refactor: Remove uses of AnyDuringMigration from zoom_controls.ts.
* refactor: Remove uses of AnyDuringMigration from comment.ts.
* refactor: Remove uses of AnyDuringMigration from dialog.ts.
* refactor: Remove uses of AnyDuringMigration from icon.ts.
* refactor: Remove uses of AnyDuringMigration from scrollbar_pair.ts.
* refactor: Remove uses of AnyDuringMigration from workspace_audio.ts.
* refactor: Remove uses of AnyDuringMigration from workspace_drag_surface_svg.ts.
* chore: add linting for tsdoc
* chore: don't require types on return
* chore: remove redundant fileoverview from ts
* chore: change return to returns and add some newlines
* chore: remove license tag
* chore: don't require params/return docs
* chore: remove spurious struct tags
* Revert "chore: change return to returns and add some newlines"
This reverts commit d6d8656a45.
* chore: don't auto-add param names
* chore: disable require-param bc it breaks on this
* return to returns and add line breaks
* chore: configure additional jsdoc rules
* chore: run format
* Revert "chore: remove license tag"
This reverts commit 173455588a.
* chore: allow license tag format
* chore: only require jsdoc on exported items
* chore: add missing jsdoc or silence where needed
* chore: run format
* chore: lint fixes
* chore(build): Add inline sources to sourcemaps
* chore(build): Don't package sources
Since the sources are now inline in the sourcemaps, they no longer
need to be package separately.
PR #6244 made a change to have the npm run prepare script
(automatically invoked by npm install after package installation)
not bother running the buildJavaScriptAndDeps gulp task when run
from a GitHub action (since our build action will do npm test
straight afterwards, which runs this task already).
Unfortunately, due my misunderstanding of how gulp tasks work
the revised version generated a "Did you forget to signal async
completion?" error from gulp.
Fix this by adding a done parameter and passing the provided
callback to buildJavaScriptAndDeps. This also allows a
simplification of the the don't-run case by simply calling
done and then returning.
