Neil Fraser
939bbd072b
Lint
2019-08-02 11:00:40 -07:00
Neil Fraser
e77a9b7e81
Change parseFloat() to Number()
...
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number. An audit of each case shows nowhere that parseFloat()’s features are needed.
2019-08-01 11:36:58 -07:00
Neil Fraser
11f6c5a631
Fix angle picker when 'Infinity' is typed in.
...
Previously 'NaN' would be generated, which is not a legal value.
2019-08-01 11:36:58 -07:00
Roy van Schaijk
bcadd836b2
Make the TabList exclude hidden fields ( #2764 )
...
* Make the TabList exclude hidden fields
* Stop using private variable
2019-08-01 11:14:52 -07:00
Monica Kozbial
9cc0cb6881
Merge pull request #2760 from moniika/moniika-update-centerline
...
Fix bottom row element centerlines
2019-08-01 10:47:46 -07:00
alschmiedt
1ba6bb887d
Fixes undo ( #2766 )
2019-08-01 10:05:56 -07:00
kozbial
e2f12f8262
Fixing edge case for centerline computation for bottom row elements.
2019-07-31 20:12:51 -07:00
Rachel Fenichel
5294d0ab71
Merge pull request #2753 from rachel-fenichel/remove_console_spam
...
Remove logs from rendering
2019-07-31 15:55:03 -07:00
Rachel Fenichel
41c686e733
Use constants
2019-07-31 13:17:20 -07:00
Rachel Fenichel
37250f4ce4
Fix connection highlight rendering
2019-07-31 12:42:34 -07:00
Rachel Fenichel
bcdd691796
Make updating the connection locations called the same way for both renderers
2019-07-31 11:45:32 -07:00
Rachel Fenichel
113c24509b
Remove logs from rendering
2019-07-31 11:14:24 -07:00
Rachel Fenichel
16f0992764
Enable operator-linebreak rule
2019-07-31 09:45:27 -07:00
Rachel Fenichel
b4109d7c43
Add no-multi-spaces rule
2019-07-31 09:33:54 -07:00
alschmiedt
9466c6b7df
Move marker creation to the workspace ( #2742 )
...
* Move marker creation to the workspace
2019-07-31 09:04:53 -07:00
alschmiedt
62f4871e45
Fixes copy paste to work with the marker ( #2740 )
...
* Fixes copy paste to work with the marker
2019-07-31 07:49:02 -07:00
Neil Fraser
45e5fb4157
More JSDoc and lint corrections
2019-07-30 17:00:40 -07:00
Neil Fraser
6aedfab4d1
Misc JSDoc fixes. ( #2747 )
2019-07-30 16:28:48 -07:00
Rachel Fenichel
47574c670d
Merge pull request #2745 from rachel-fenichel/render/constants
...
Position notches
2019-07-30 14:05:39 -07:00
Beka Westberg
c43e001634
Fixed DropDownDiv Rendering On Small Workspaces ( #2641 )
...
* Fixed dropdown div rendering when the workspace is too small.
2019-07-30 13:29:52 -07:00
Rachel Fenichel
94fe97d9fd
position notches
2019-07-30 11:38:18 -07:00
Sam El-Husseini
57868e7e83
Remove all calls to goog.math ( #2739 )
...
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Sam El-Husseini
5ce8c68833
Fix node build and add node tests ( #2736 )
...
* Fix node build and add node tests
2019-07-30 11:13:52 -07:00
alschmiedt
8ef540a8dc
Used moveBy in moveTo ( #2741 )
2019-07-30 10:50:59 -07:00
Sam El-Husseini
4622c95629
Fix screenToWsCoordinates jsdoc ( #2737 )
...
Fix typos in jsdoc
2019-07-30 10:08:52 -07:00
Rachel Fenichel
d6acc66c4d
Merge pull request #2732 from rachel-fenichel/render/constants
...
More work to move constants into objects
2019-07-29 16:12:21 -07:00
Rachel Fenichel
b74fe2a6cc
lint
2019-07-29 16:09:03 -07:00
Rachel Fenichel
fd398ce75a
Review cleanup
2019-07-29 16:04:44 -07:00
Sam El-Husseini
4c626e7b76
Fix setOnClickHandler jsdoc casing ( #2730 )
2019-07-29 15:29:06 -07:00
Rachel Fenichel
bed30dfa68
Cleanup
2019-07-29 15:26:53 -07:00
Rachel Fenichel
97c8275bdf
Merge pull request #2731 from BeksOmega/fixes/FlyoutDragging
...
Fixed flyout scrollbars not being updated when the flyout was dragged.
2019-07-29 15:17:37 -07:00
Rachel Fenichel
9ce8282568
Remove references to distance45outside
2019-07-29 14:58:51 -07:00
Beka Westberg
b45492c4b3
Fixed flyout scrollbars not being updated when the flyout was dragged.
2019-07-29 13:39:06 -07:00
Sam El-Husseini
0c75664b06
Fix IE flyout button callback ( #2719 )
2019-07-29 10:58:38 -07:00
Rachel Fenichel
36b4b18492
Quarantine highlights.
2019-07-26 17:33:10 -07:00
Rachel Fenichel
64cc3c5de6
Reduce number of direct references to the constants file
2019-07-26 16:41:06 -07:00
Ashwin Ramaswami
980412e723
Properly handle cases when sound.play() does not return a promise ( #2614 )
...
* Properly handle cases when sound.play() does not return a promise
2019-07-26 16:40:39 -07:00
Rachel Fenichel
dbea4615e8
More corner work
2019-07-26 16:10:03 -07:00
Rachel Fenichel
b54ec1e2db
Corners and notches
2019-07-26 15:17:25 -07:00
Rachel Fenichel
08982ce55e
Merge pull request #2668 from BeksOmega/fixes/DeprecateSetText
...
Deprecated Field.setText
2019-07-26 13:02:35 -07:00
Beka Westberg
3d813803ca
updateVariableName -> refreshVariableName
2019-07-26 12:55:43 -07:00
Rachel Fenichel
20bec74282
Move all references to PUZZLE_TAB.height and width into measurables
2019-07-25 15:42:27 -07:00
kozbial
5a5d0b698a
Using centerline for debug rendering.
2019-07-25 14:13:34 -07:00
Monica Kozbial
15ca31650f
Merge pull request #2709 from moniika/moniika-render-debug-top-bottom
...
Updating debug rendering for top and bottom block rows.
2019-07-25 13:32:24 -07:00
kozbial
c858153ea0
Updating indentation.
2019-07-25 12:37:01 -07:00
Sam El-Husseini
c1b49a1da7
Fix some jsdoc types ( #2701 )
...
* Fix JSDoc regarding type inconsistencies. Make image field src required and update image field tests.
2019-07-25 12:24:36 -07:00
kozbial
01f24a81db
Adding line wrap to drawSpacerElem function definition.
2019-07-25 11:42:48 -07:00
Rachel Fenichel
94bc23ff7e
Merge pull request #2713 from rachel-fenichel/render/constants
...
Move puzzle tab and start hat information into objects
2019-07-25 11:33:41 -07:00
Neil Fraser
84f5afd0e3
Typo: enutral -> neutral
2019-07-25 11:32:02 -07:00
Rachel Fenichel
b9f6c27b32
More cleanup
2019-07-25 11:18:50 -07:00