Commit Graph

3623 Commits

Author SHA1 Message Date
Erik Pasternak bacfae24dd Properly set the display style on blocks when connections are unhidden
We weren't always setting the display style on blocks when the hidden
state changed on a connection. This meant that sometimes unhiding a
connection would cause the attached block to be invisible.

This moves the display style code into the setHidden so it is never
skipped.
2019-07-18 14:08:53 -07:00
alschmiedt fc45d1aa12 Merge pull request #2664 from google/revert-2607-input_number
Revert "Adds type to FieldNumber editor"
2019-07-18 13:09:48 -07:00
alschmiedt 8f880d55c3 Revert "Adds type to FieldNumber editor" 2019-07-18 13:02:53 -07:00
Beka Westberg 2464e3af46 Added setting a colour fields options through JSON. (#2655) 2019-07-18 12:23:31 -07:00
Beka Westberg f873ddb1c6 Added Field Tooltip Support to the JSON (#2657)
* Added support for setting a field's tooltip via JSON.

* Added a test block to the playground.
2019-07-18 12:21:37 -07:00
translatewiki.net dc8922bebc Localisation updates from https://translatewiki.net. 2019-07-18 16:18:10 +02:00
Rachel Fenichel 6e84ac462a Merge pull request #2653 from alschmiedt/compile_broken
Remove @packages annotation from public methods
2019-07-17 12:57:10 -07:00
Abby fe4bff70da Add @public annotation 2019-07-17 11:52:14 -07:00
Abby 0f4a417052 Remove @packages annotation from public methods 2019-07-17 11:38:08 -07:00
Rachel Fenichel ac3c066fa9 Merge pull request #2647 from rachel-fenichel/tests/screenshot_test_cases
Add test case files for screenshot testing
2019-07-16 13:32:07 -07:00
Rachel Fenichel 6731c70f47 Add test case files for screenshot testing 2019-07-16 13:13:11 -07:00
Neil Fraser 92c4d6d3a3 Fix colour injection vulnerability.
The new validators already solve this problem, but as a second layer of defence, the generators should also be secured.  Issue #2637
2019-07-15 16:03:55 -07:00
Rachel Fenichel ff9da74571 Merge pull request #2643 from rachel-fenichel/rebuild_07_15_19
Rebuild
2019-07-15 14:57:29 -07:00
Rachel Fenichel 03776a6bfd Rebuild 2019-07-15 14:53:01 -07:00
Rachel Fenichel 79be89facc Merge pull request #2638 from rachel-fenichel/dependency_check
Update dependencies
2019-07-15 14:46:56 -07:00
Neil Fraser 2d3b514425 Ensure last variable category is last variable added.
Resolves #2050.
2019-07-15 14:37:27 -07:00
Neil Fraser 2ac3447383 Create null objects properly.
new Object(null) doesn’t do anything, that’s just broken.
And the for loop with keys is silly.
2019-07-15 14:37:27 -07:00
Neil Fraser bbb6e03801 Don’t save IDs of shadow blocks. 2019-07-15 14:37:27 -07:00
Neil Fraser 0e82677f27 Create stub for Node contstants.
Ironic that Node doesn’t have Node.  Not tested.
Fix two missing dependencies.
2019-07-15 14:37:27 -07:00
Neil Fraser 31a9c02362 Stop generating dynamic XML from text.
Removes last goog.string reference.
2019-07-15 14:37:27 -07:00
Neil Fraser 829dcc207c Make type and variabletype attributes optional
If a variable doesn’t have a type, then don’t add these empty attributes in the XML.
2019-07-15 14:37:27 -07:00
Rachel Fenichel 4915fdfe12 Update dependencies 2019-07-15 10:48:36 -07:00
RoboErikG 8abba6ae10 Remove edit handler that is just eating events (#2634)
This handler should be unnecessary on most versions of Android, and it's currently just swallowing events that would be handled by default. Removing it to let the system take the default action.
2019-07-12 13:29:46 -07:00
Neil Fraser 5bb98bc998 Routine recompile
Closure changed, everything broke.  Again.

Verbal LGTM from @alschmiedt
2019-07-12 12:36:10 -07:00
Neil Fraser 3647b6e38e Add XSD to validate Blockly’s XML (#2633)
* Add XSD to validate Blockly’s XML

This XSD might be used in tests or other tooling.
2019-07-12 12:05:55 -07:00
Tiago Quelhas 588840875e Replace --dependency_mode=STRICT with PRUNE. (#2631)
STRICT is a deprecated alias for PRUNE.
2019-07-11 17:57:54 -07:00
Monica Kozbial c19c55db65 Merge pull request #2629 from moniika/moniika-collapsed-insertion-marker
Added setCollapsed to insertion marker block creation.
2019-07-11 12:56:00 -07:00
kozbial da26594307 Added setCollapsed to insertion marker block creation. 2019-07-11 10:25:21 -07:00
Beka Westberg b7e6d3704a Fixed Procedure Argument Escaping (#2626)
* Refactored procedure decompose to build XML node by node. Fixed argument name escaping.

* Fixed review comments.
2019-07-10 16:58:25 -07:00
Rachel Fenichel 0af94c4880 Merge pull request #2623 from rachel-fenichel/remove_accessible
Remove accessibility demo from Blockly repo
2019-07-10 13:35:55 -07:00
Rachel Fenichel b602240c8b Fix comment 2019-07-10 12:40:46 -07:00
alschmiedt 6e9761b249 Merge pull request #2618 from alschmiedt/dynamic_variable_error
Fixes bug with using dynamic variable in toolbox
2019-07-09 16:29:11 -07:00
Rachel Fenichel 074d7f7443 Merge pull request #2594 from BeksOmega/demos/CustomFields
Added custom fields demo.
2019-07-09 16:25:16 -07:00
Beka Westberg c053130da3 Fixed Procedure Decomposition Not Working with >1 Arguments (#2622)
* Fixed procedure decomposition not working with >1 arguments.

* Fixed typo causing #2612.
2019-07-09 16:06:58 -07:00
Rachel Fenichel deb675f82d Remove accessibility code from build process 2019-07-09 16:00:43 -07:00
Rachel Fenichel 9db73a69dc Delete accessibility demo code 2019-07-09 16:00:27 -07:00
alschmiedt 35341959d3 Fixes eslint error 2019-07-09 11:28:36 -07:00
alschmiedt f30d79fbc8 Fixes bug with using dynamic variable in toolbox 2019-07-09 11:02:02 -07:00
Beka Westberg 39e414c2bf Rebuild. 2019-07-09 10:25:40 -07:00
Beka Westberg f837b7ca04 Moved SVG creation into a separate function. 2019-07-09 10:21:22 -07:00
Beka Westberg 69ea81fba8 Changed modifier validator turtle field example. 2019-07-09 10:21:22 -07:00
Beka Westberg fa57ab23e5 Adding XML example. 2019-07-09 10:21:22 -07:00
Beka Westberg b74254662e Added custom fields demo. 2019-07-09 10:21:22 -07:00
Neil Fraser e06d4e648c Rename BlockAnimation > blockAnimation
Issue 2102.  And do a full recompile due to changed the dependency name.
2019-07-08 17:31:38 -07:00
Neil Fraser d1fb3f0480 Fix typo in Blockly Factory. 2019-07-08 13:29:43 -07:00
Neil Fraser dd6cb19f5d Backward compatibility check for ‘variableType’ 2019-07-08 13:29:43 -07:00
Neil Fraser 52b6ce18a5 Fix unit tests 2019-07-08 13:29:43 -07:00
Neil Fraser 20d4a27f0a Add namespacing to XML
Fixes #1978.
2019-07-08 13:29:43 -07:00
Neil Fraser 74be35e23d Rename Blockly.Xml.utils to Blockly.utils.xml 2019-07-08 13:29:43 -07:00
translatewiki.net 880dc4cbef Localisation updates from https://translatewiki.net. 2019-07-08 20:00:49 +02:00