Commit Graph

3929 Commits

Author SHA1 Message Date
Rachel Fenichel
c2cbed1146 fix: some AnyDuringMigration (#6430)
* fix: remove some AnyDuringMigrations

* fix: some instances of AnyDuringMigration

* fix: some AnyDuringMigration

* chore: revert comment removal
2022-09-15 12:48:40 -07:00
Christopher Allen
c063d12abb chore: Re-remove core/blockly.js (#6422)
core/blockly.js was removed from the ts/migration branch in PR #6261,
but for some reason when ts/migration was merged into develop via
a two step process something went wrong:

* as expected, blockly.js got renamed to blockly.ts in PR #6297, but
* for some reason it got re-added under its original name in PR #6299.

Since the file should not exist, is not used, and has proven to
cause confusion (to me at least!), delete it again, hopefully for
good this time.
2022-09-14 18:11:14 +01:00
Neil Fraser
05b221b1d6 fix: Deep copy options used by dropdown fields (#6425)
This uncovered a broken test that was only passing because of a side effect of the dropdown option data getting modified.
2022-09-13 13:29:38 -07:00
Rachel Fenichel
e3fa43d861 feat: return element from menu.render (#6426)
* feat: return element from menu.render

* chore: format

* chore: add returns annotation
2022-09-13 13:29:18 -07:00
Rachel Fenichel
5f11f3449f fix: remove calls to removeClass and hasClass (#6413)
* fix: stop using dom.addClass in most cases

* chore: format

* fix: remove use of dom.addClass in toolbox

* chore: lint and format

* fix: add checks around non-constant class names

* fix: switch back to quoted access

* chore: format

* fix: remove calls to removeClass

* chore: format

* chore: remove unused deps

* fix: remove uses of hasClass

* chore: format and lint

* chore: format
2022-09-13 08:33:49 -07:00
Beka Westberg
26561947fb chore: remove AnyDuringMigration from the other renderers (#6409)
* chore: remove AnyDuringMigration from geras renderer

* chore: more removing AnyDuringMigration from renderers

* chore: remove AnyDuringMigration from constants

* chore: format

* chore: work on PR comments

* chore: fix typo and resulting build issues
2022-09-12 15:01:01 -07:00
Beka Westberg
b5cd839000 chore: remove AnyDuringMigration from common renderer (#6402)
* chore: remove AnyDuringMigration from common renderer

* chore: remove AnyDuringMigration in common drawer

* chore: format

* chore: add dividers back

* chore: format
2022-09-11 13:06:41 -07:00
Beka Westberg
d754c6d278 chore: remove AnyDuringMigration from gesture code (#6401)
* chore: work on refactoring gesture code

* chore: reorganize throw order

* chore: format

* chore: PR comments

* chore: format
2022-09-09 16:29:06 -07:00
Christopher Allen
5d3ba79ab3 fix!(connection): Correctly handle multiple highlighted connections (#6416)
Modify RenderedConnection.prototype.highlight and .unhighlight to
store the highlight path on this rather than as a static property
on Connection (which is where it had been stored since this
functionality was originally created, previously to RenderedConnection
and Connection being split).
2022-09-09 18:00:59 +01:00
ktbytechibong
e58cf77b7f fix: TS errors on dependent projects with certain tsconfig settings (#6360) (#6361)
* fix: TS errors on dependent projects with certain tsconfig settings (#6360)

* Address PR comments
2022-09-06 13:19:56 -07:00
Maribeth Bottorff
ec72e8bb4d chore: add api extractor configuration and fix some associated problems (#6388)
* chore: add configuration for api extractor

* fix: remove extra param names

* chore: private to internal

* remove unrestricted

* chore: remove double backticks

* chore: remove fileoverview and export * as

* chore: return to returns

* chore: fix backslashes and angle brackets in tsdoc

* chore: final to sealed

* chore: ignore to internal

* chore: fix link tags

* chore: add api-extractor configuration

* chore: add unrecognized tag names

* chore: remove tsdoc-metadata

* fix: correct index.d.ts

* chore: fix connection link
2022-09-01 11:39:05 -07:00
Rachel Fenichel
55ea12bd21 fix: stop using is3dSupported (#6400)
* fix: remove prefix checks from is3dSupported

* fix: stop using is3dSupported

* chore: mark is3dSupported deprecated

* chore: fix lint
2022-08-31 12:59:16 -04:00
Beka Westberg
21237c9362 chore: remove AnyDuringMigration from the insertion marker manager (#6398)
* chore: remove AnyDuringMigration from the insertion marker manager

* chore: fix final issues

* chore: format
2022-08-31 09:27:23 -07:00
Beka Westberg
79051a69db fix: context menu not working (#6399) 2022-08-31 08:00:45 -07:00
Rachel Fenichel
9775b5138b fix: deprecate functions in object.ts (#6387)
* fix: deprecate functions in object.ts

* chore: update deprecation dates and formats

* chore: redo deprecation dates again
2022-08-30 19:20:24 -04:00
Rachel Fenichel
a785ab8d9c fix: remove some IE-specific code in dom and style (#6396)
* fix: remove some IE-specific code in dom and style

* fix: delete unnecessary getStyle function
2022-08-30 15:49:06 -04:00
Rachel Fenichel
856e74d9cf fix!: remove unused functions in style.ts (#6386) 2022-08-26 16:03:16 -04:00
Aaron Dodson
3bc42c5c3f refactor!: Removed backwards compatibility for getDeveloperVars(). (#6385) 2022-08-25 13:32:45 -07:00
Aaron Dodson
3a36ed5116 refactor: Remove more uses of AnyDuringMigration. (#6383)
* refactor: Remove uses of AnyDuringMigration from flyout_base.ts.

* refactor: Remove uses of AnyDuringMigration from flyout_metrics_manager.ts.

* refactor: Remove uses of AnyDuringMigration from variables_dynamic.ts.

* refactor: Remove uses of AnyDuringMigration from procedures.ts.

* refactor: Remove uses of AnyDuringMigration from generator.ts.

* refactor: Remove some uses of AnyDuringMigration from menu.ts.

* refactor: Remove uses of AnyDuringMigration from mutator.ts.

* refactor: Remove uses of AnyDuringMigration from variables.ts.

* refactor: Remove uses of AnyDuringMigration from array.ts.

* refactor: Remove uses of AnyDuringMigration from aria.ts.

* refactor: Remove uses of AnyDuringMigration in basic_cursor.ts.

* refactor: Remove uses of AnyDuringMigration in dropdowndiv.ts.

* refactor: Remove uses of AnyDuringMigration in utils.ts.

* refactor: Remove uses of AnyDuringMigration from menuitem.ts.

* refactor: Remove uses of AnyDuringMigration from idgenerator.ts.

* refactor: Remove uses of AnyDuringMigration in block_animations.ts.

* refactor: Initialize definitions and functionNames in generator.ts by default.
2022-08-24 16:06:38 -07:00
Rachel Fenichel
e50ad59ffe chore: remove underscores from private properties in grid.ts (#6375)
* chore: remove underscores from private properties in grid.ts

* chore: remove unused property
2022-08-24 16:42:49 -04:00
Maribeth Bottorff
60bc01acc8 fix: make eventUtils throw if event type not registered (#6381)
* chore: update lint rules

* fix: have eventUtils.get throw if event isn't found

* chore: remove nonnull assertion from eventUtils.get and format
2022-08-24 13:41:32 -07:00
Aaron Dodson
980fe138e7 refactor: Mark optional parameters as optional. (#6380)
* refactor: Mark optional params as optional.

* refactor: Slightly narrow the typing of rendererOverrides.
2022-08-24 13:19:37 -07:00
Aaron Dodson
1f6481e527 chore: Removed commented-out side-effect-only imports. (#6379) 2022-08-24 11:28:09 -07:00
Aaron Dodson
57a5d0d49c refactor: Remove more uses of AnyDuringMigration (#6378)
* refactor: Remove uses of AnyDuringMigration from flyout_vertical.ts.

* refactor: Remove uses of AnyDuringMigration in flyout_horizontal.ts.

* refactor: Remove uses of AnyDuringMigration from zoom_controls.ts.

* refactor: Remove uses of AnyDuringMigration from comment.ts.

* refactor: Remove uses of AnyDuringMigration from dialog.ts.

* refactor: Remove uses of AnyDuringMigration from icon.ts.

* refactor: Remove uses of AnyDuringMigration from scrollbar_pair.ts.

* refactor: Remove uses of AnyDuringMigration from workspace_audio.ts.

* refactor: Remove uses of AnyDuringMigration from workspace_drag_surface_svg.ts.
2022-08-23 15:36:52 -07:00
Beka Westberg
7698c072d3 chore: remove AnyDuringMigration from dropdown and widget divs (#6377)
* chore: remove AnyDuringMigration from dropdown div

* chore: remove AnyDuringMigration from widget div

* chore: format
2022-08-23 15:26:10 -07:00
Maribeth Bottorff
037eb59b89 chore: Lint TsDoc. (#6353)
* chore: add linting for tsdoc

* chore: don't require types on return

* chore: remove redundant fileoverview from ts

* chore: change return to returns and add some newlines

* chore: remove license tag

* chore: don't require params/return docs

* chore: remove spurious struct tags

* Revert "chore: change return to returns and add some newlines"

This reverts commit d6d8656a45.

* chore: don't auto-add param names

* chore: disable require-param bc it breaks on this

* return to returns and add line breaks

* chore: configure additional jsdoc rules

* chore: run format

* Revert "chore: remove license tag"

This reverts commit 173455588a.

* chore: allow license tag format

* chore: only require jsdoc on exported items

* chore: add missing jsdoc or silence where needed

* chore: run format

* chore: lint fixes
2022-08-23 14:27:22 -07:00
Beka Westberg
bb37d1b7aa chore: remove instances of AnyDuringMigration in icons code (#6376)
* chore: remove AnyDuringMigration from icon

* chore: remove AnyDuringMigration from comment

* chore: remove AnyDuringMigration in warning

* chore: remove anyDuringMigration from mutator

* chore: format
2022-08-23 14:23:40 -07:00
Beka Westberg
7f6df7d562 chore: format css (#6373)
* chore: format css

* chore: convert css to templates

* chore: disable clang-formatting geras css

* chore: clang format
2022-08-23 11:18:33 -07:00
Beka Westberg
b1b4aa06c3 chore: remove alt dynamic shape definition (#6374)
* chore: remove alt dynamic shape definition

* chore: format
2022-08-23 08:26:17 -07:00
Aaron Dodson
76b1e023e3 chore: Fix no-inferrable-types lint rule violations. (#6372) 2022-08-22 14:42:41 -07:00
Aaron Dodson
43f54b1b06 chore: Fix or individually disable no-this-alias lint rule violations. (#6371) 2022-08-22 14:13:26 -07:00
Aaron Dodson
9454b7070c refactor: Remove uses of AnyDuringMigration from scrollbar.ts, workspace_svg.ts, contextmenu_registry.ts, and component_manager.ts (#6318)
* refactor: Remove uses of AnyDuringMigration from scrollbar.ts.

* refactor: Remove almost all uses of AnyDuringMigration from workspace_svg.ts.

* refactor: Remove uses of AnyDuringMigration from contextmenu_registry.ts.

* refactor: Remove uses of AnyDuringMigration from component_manager.ts.

* refactor: Use String() rather than toString().

* fix: Fix lint and build errors.
2022-08-22 11:04:11 -07:00
Rachel Fenichel
aff21b936c fix: remove unused or obsolete useragent checks (#6355) 2022-08-17 19:03:20 -04:00
Rachel Fenichel
ffe6d55d5f fix!: remove checks for IE and EdgeHTML in core (#6336)
* chore: remove uses of userAgent.IE

* chore!: remove export of userAgent.IE

* format: run format

* fix!: remove special-cases for EdgeHTML browser engine

* fix!: remove export of userAgent.EDGE

* chore: remove unused dependencies

* fix: touch events in non-touch firefox
2022-08-17 14:13:13 -04:00
Beka Westberg
e9920a54e0 feat!: allow blocks to receive their own delete events (#6337)
* feat!: allow blocks to receive their own delete events

* fix: move block tests back into main directory

* chore: add a test for disposing of callers

* chore: add test for delete being received

* chore: add comment about why we have to run the clock twice

* chore: fix whitespace

* chore: fix whitespace

* chore: fix imports in tests

* chore: bump mocha timeout

* chore: bump timeout again?

* chore: eliminate the possibility that tests are actually timing out

* chore: change timeout back

* chore: remove tests that might be the problematic ones

* chore: attempt enabling delete event test

* chore: enable lists tests

* chore: try ternary test as well

* chore: actually add block test files

* chore: enable remaining tests
2022-08-16 15:49:40 -07:00
Maribeth Bottorff
49f87fba79 chore: enable linting ts files (#6351)
* chore: initial setup for linting ts

* chore: Temporarily disable most of the rules causing problems

* chore: fix autofixable problems.

* chore: ignore the last few files and rules

* chore: fix remaining lint errors

* chore: fix more small lint

* chore: run original rules on js files, new ts rules on ts files

* chore: use jsdoc style return in js files

* chore: add lint fix script

* chore: fix prefer-spread lint

* chore: fix no-invalid-this rule

* chore: fix no-unused-vars

* chore: fix trashcan lint
2022-08-16 13:59:15 -07:00
Aaron Dodson
3f15f1ecb7 refactor: Use maps and sets instead of plain objects. (#6331)
* refactor: Convert objects to sets and maps

* refactor: Use maps instead of objects in workspace.ts.

* refactor: Use maps instead of objects in theme_manager.ts.

* refactor: Use maps instead of objects in block_svg.ts.

* refactor: Use sets instead of objects in variables.ts.

* refactor: Use maps instead of objects in marker_manager.ts.

* refactor: Use maps instead of objects in touch_gesture.ts.

* refactor: Use maps instead of objects in variable_map.ts.

* refactor: Use maps and sets instead of objects in path_object.ts.

* refactor: Use maps instead of objects in shortcut_registry.ts.

* refactor: Use a map instead of an object in workspace_audio.ts.

* refactor: Use better ivar names and enforce the singleton ShortcutRegistry object and type.

* refactor: Use public API in the shortcut registry test.

* refactor: Simplify implementation of getAllVariableNames().

* refactor: Remove unnecessary emptiness check in block_svg.ts.

* fix: clang-format variable_map.ts.
2022-08-12 09:18:43 -07:00
Beka Westberg
f07b06b6d5 refactor: add better types to field configs (#6317)
* fix: add config types in all fields

* fix: add interfaces to fromJson

* chore: cleanup from cherry-pick

* chore: add docs to exported properties

* chore: format

* chore: remove unnecessary test case

* fix: replacing message references in tooltip

* chore: fix format

* chore: rename interfaces to be more explicit

* chore: format

* fix: add proper visibility keywords

* chore: fix label field config name

* chore: formatting

* chore: remove unnecessarily renamed imports
2022-08-08 11:16:50 -07:00
Beka Westberg
8f4b49a771 feat: make isMutator public (#6316)
* feat: make isMutator public

* fix: move isFlyout and isMutator to getters

* chore: delete change detector test
2022-08-08 08:35:38 -07:00
Aaron Dodson
bef2ac41a0 refactor: Remove uses of AnyDuringMigration and fix types in BlocklyOptions/Options. (#6315) 2022-08-05 09:22:34 -07:00
Beka Westberg
4e37433787 refactor: remove AnyDuringMigration from input (#6310)
* fix: AnyDuringMigration for input

* refactor: fix type of getSourceBlock()
2022-08-05 08:25:59 -07:00
Beka Westberg
fd127f6b60 feat: updates accessors for getMainWorkspace and getSelected (#6313)
* feat: add static accessors to Blockly for getMainWorkspace and getSelected

* refactor: remove AnyDuringMigration in blockly.ts

* fix: fix constants import

* chore: add file extension to import

* chore: format
2022-08-04 15:58:09 -07:00
Beka Westberg
aacbe4db62 refactor: remove AnyDuringMigration from bubble dragger (#6305)
* fix: remove unnecessary disposing

* fix: add nullability union to drag surface

* chore: format

* fix: remove no-op dispose method
2022-08-04 15:50:15 -07:00
Beka Westberg
0240b3acd3 refactor: remove AnyDuringMigration from the block drag surface (#6302)
* fix: unnecessary nullability

* fix: rename SVG_ to svg_

* fix: add deprecation warning

* chore: format
2022-08-04 13:58:06 -07:00
Beka Westberg
c73b73c411 refactor: remove AnyDuringMigration from connection (#6309)
* fix: AnyDuringMigration in connection

* chore: remove unnecessary parens
2022-08-04 13:54:56 -07:00
Beka Westberg
48bdb07f33 refactor: remove AnyDuringMigration from the comment icon (#6308)
* fix: checking for null model text

* fix: use correct event type

* chore:format

* chore: use nullish coalescing
2022-08-04 13:54:24 -07:00
Beka Westberg
dc44c66057 refactor: remove AnyDuringMigration from browser events (#6303)
* fix: bind data

* fix: use correct event types

* fix: make event happy with us clueging properties onto it

* fix: change thisObject to type Object | null

* chore: format

* chore: call out event conversion wierdness

* chore: fix build by changing things to use MouseEvent

* chore: remove default value for object

* fix: unbind trying to get an element of an empty array

* chore: format

* fix: call out potentially unsafe element access.

* chore: add issue number to TODO

* fix: attempt to fix CI build error?
2022-08-04 10:35:02 -07:00
Aaron Dodson
f70f82327b refactor: Remove some uses of AnyDuringMigration (#6307)
* refactor: Remove uses of AnyDuringMigration from trashcan.ts.

* refactor: Remove uses of AnyDuringMigration in bubble.ts.

* refactor: Remove uses of AnyDuringMigration from connection_checker.ts.

* refactor: Remove uses of AnyDuringMigration from connection_db.ts.

* refactor: Remove uses of AnyDuringMigration in contextmenu_items.ts.

* refactor: Remove uses of AnyDuringMigration from grid.ts.

* refactor: Remove uses of AnyDuringMigration from i_drag_target.ts.

* refactor: Remove uses of AnyDuringMigration from i_ast_node_location_svg.ts.

* refactor: Remove uses of AnyDuringMigration from i_ast_node_location_with_block.ts.

* refactor: Remove uses of AnyDuringMigration from i_autohideable.ts.

* refactor: Remove uses of AnyDuringMigration from i_block_dragger.ts.

* refactor: Remove uses of AnyDuringMigration from i_bounded_element.ts.

* refactor: Remove uses of AnyDuringMigration from i_bubble.ts.

* refactor: Remove uses of AnyDuringMigration from i_collapsible_toolbox_item.ts.

* refactor: Remove uses of AnyDuringMigration from i_connection_checker.ts.

* refactor: Remove uses of AnyDuringMigration from i_contextmenu.ts.

* refactor: Remove uses of AnyDuringMigration in i_copyable.ts.

* refactor: Remove uses of AnyDuringMigration from i_deleteable.ts.

* refactor: Remove uses of AnyDuringMigration from i_delete_area.ts.

* refactor: Remove uses of AnyDuringMigration in i_flyout.ts.

* refactor: Remove uses of AnyDuringMigration in i_keyboard_accessible.ts.

* refactor: Remove uses of AnyDuringMigration in i_metrics_manager.ts.

* refactor: Remove uses of AnyDuringMigration from i_movable.ts.

* refactor: Remove uses of AnyDuringMigration in i_positionable.ts.

* refactor: Remove uses of AnyDuringMigration in i_selectable_toolbox_item.ts.

* refactor: Remove uses of AnyDuringMigration from i_selectable.ts.

* refactor: Remove uses of AnyDuringMigration in i_serializer.ts.

* refactor: Remove uses of AnyDuringMigration from i_styleable.ts.

* refactor: Remove uses of AnyDuringMigration in i_toolbox.ts.

* refactor: Make non-null checks explicit.
2022-08-04 10:09:24 -07:00
Beka Westberg
ee83f09753 chore: remove AnyDuringMigration from bump objects (#6306)
* fix: change return type to void

* chore: format
2022-08-04 08:31:12 -07:00
Beka Westberg
4535e84d3e chore: remove AnyDuringMigration from block animations (#6301)
* fix: disconnectGroup

* fix: cloneNode

* fix: final AnyDuringMigration cleanup

* chore: change cast to toString instead

* chore: format
2022-08-03 10:25:03 -07:00