Sam El-Husseini
dd9257e1b0
Field Text transformation methods ( #2930 )
...
* Add field text transform methods for converting from text to value and vice versa.
2019-08-30 17:00:31 -07:00
Sam El-Husseini
f23b659898
Remove this.text_ ( #2910 )
...
* Remove this.text_ and have every field handle its own properties.
2019-08-26 10:56:36 -07:00
Sam El-Husseini
b7097d1add
Field widgetdiv flicker ( #2911 )
...
* Stop field flickering when the text input is initially shown.
2019-08-26 08:53:55 -07:00
Sam El-Husseini
1d4cfb8dfa
Field angle keyboard navigation ( #2853 )
...
Field angle keyboard accessibility
2019-08-20 18:25:15 -07:00
Neil Fraser
096959fde9
Cleanup of last fortnight’s commits. ( #2865 )
...
No functional changes.
2019-08-19 14:07:48 -07:00
Sam El-Husseini
c99734b8f9
Add valuemin and valuemax aria properties for number fields ( #2850 )
2019-08-16 18:41:05 -07:00
Beka Westberg
0872d022e1
Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires.
2019-08-16 09:57:28 -07:00
Beka Westberg
cdc90f4059
Refactored field utilities.
2019-08-16 09:57:27 -07:00
Sam El-Husseini
f539dbe6f6
Add aria invalid for when a text input field is invalid ( #2839 )
2019-08-15 17:13:06 -07:00
Sam El-Husseini
f174f422ff
Set the border size on a text input to take into account scaling. ( #2837 )
2019-08-15 16:23:17 -07:00
Sam El-Husseini
36135ac62b
Fix RTL text field positioning bug by ensuring a reflow ( #2779 )
2019-08-07 10:54:36 -07:00
Rachel Fenichel
5deedc8f53
Merge pull request #2783 from rachel-fenichel/field_corrected_size
...
Remove getCorrectedSize for fields
2019-08-06 13:45:44 -07:00
Rachel Fenichel
3802a0c960
Remove getCorrectedSize for fields
2019-08-05 16:01:50 -07:00
Sam El-Husseini
9203517f3d
Center text field input when editing ( #2776 )
...
* Center text field input when editing
2019-08-05 11:23:47 -07:00
Neil Fraser
e77a9b7e81
Change parseFloat() to Number()
...
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number. An audit of each case shows nowhere that parseFloat()’s features are needed.
2019-08-01 11:36:58 -07:00
Neil Fraser
45e5fb4157
More JSDoc and lint corrections
2019-07-30 17:00:40 -07:00
Sam El-Husseini
57868e7e83
Remove all calls to goog.math ( #2739 )
...
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Rachel Fenichel
c3eb0ed3c4
Merge pull request #2690 from rachel-fenichel/border_rect_default_height
...
Define BORDER_RECT_DEFAULT_HEIGHT constant
2019-07-23 16:21:10 -07:00
Rachel Fenichel
24866deae9
Use BORDER_RECT_DEFAULT_HEIGHT constant
2019-07-23 13:38:28 -07:00
Rachel Fenichel
71ef4b86b8
Merge pull request #2670 from BeksOmega/fixes/RemoveChangeListener
...
Removed Useless Text Input Workspace Change Listener.
2019-07-23 12:56:32 -07:00
Rachel Fenichel
fc4372dbc2
Add TODOs with github issue number
2019-07-22 16:29:44 -07:00
Beka Westberg
7e3344cf17
Removed useless text input workspace change listener.
2019-07-19 09:55:29 -07:00
Rachel Fenichel
f469a388ed
Add getCorrectedSize functions to fields
2019-07-17 11:00:20 -07:00
alschmiedt
55fc506782
Merge pull request #2577 from BeksOmega/fixes/doValueInvalid
...
Added Sending the Bad Value to doValueInvalid
2019-06-24 16:09:20 -07:00
Beka Westberg
3227223c82
Renamed _newValue param to _invalidValue.
2019-06-24 14:58:33 -07:00
Beka Westberg
27a6593d27
Removed Class Option Check from Text Input fromJson ( #2588 )
...
* Removed class option check from text input fromJson, as text input fields don't accept a class.
* Fixed syntax error.
2019-06-24 13:34:28 -07:00
Beka Westberg
4a0d5f5df0
Added sending the bad value to doValueInvalid.
2019-06-14 12:00:10 -07:00
Neil Fraser
b8cbd9e7df
Resolve 13 warnings
...
Reduce count from 632 to 619.
Eliminate copy-paste code duplication in Field.prototype.setValue
2019-06-12 10:59:33 -07:00
Beka Westberg
392119680e
Fixed misc PR comments.
2019-06-11 13:32:10 -07:00
Beka Westberg
81035c3bcb
Fixed unit tests.
2019-06-11 13:32:10 -07:00
Beka Westberg
303115953e
Moved to #2125 disposal. Cleaned up some doc.
2019-06-11 13:32:09 -07:00
Beka Westberg
217206911a
Fixed some formatting in text input.
2019-06-11 13:30:50 -07:00
Beka Westberg
0122f36450
Fixed field disposal, and reorganized editor creation.
2019-06-11 13:30:50 -07:00
Neil Fraser
a9fdf7844a
Fix ordering of requires
...
Search and replace of a name strikes again.
2019-06-07 10:32:57 -07:00
Neil Fraser
3dfac9a2ba
Alphabetize require statements.
...
Search and replace for userAgent didn’t take into account alphabetic ordering.
Also some line wraping.
2019-06-07 10:32:57 -07:00
Neil Fraser
566f182fa8
Move Blockly.userAgent to Blockly.utils.userAgent
2019-06-07 10:32:57 -07:00
Neil Fraser
d1a29739d8
Move utilities into own directory.
...
TODO: There are more functions which may be migrated into dom and string.
2019-06-07 10:32:57 -07:00
Neil Fraser
5bf7069a2f
Remove goog.math.Coordinate
2019-06-07 10:32:57 -07:00
Beka Westberg
f0d6fbd192
Reorganized field view initialization.
2019-05-31 10:38:18 -07:00
Beka Westberg
38f437a87e
Fixed angle fields not displaying 0 when given an empty string.
2019-05-25 17:36:27 -07:00
Neil Fraser
9f528922a7
Fix some dependencies
2019-05-24 15:45:05 -07:00
Beka Westberg
f16c9c0beb
Refactored field validation.
2019-05-24 14:23:42 -07:00
Beka Westberg
acd96aa2c5
Added Field Value Tests ( #2459 )
...
* Added field value tests.
* Fixed field image src param.
* Fixed falsy values with label fields.
* Fixed falsy values with text input fields.
* Fixed some angle field tests.
* Fixed other text input when editing tests.
* Fixed colour tests.
* Cleaned up some number and variable field tests.
* Added angle field > 360 degrees tests.
* Fixed variable validator tests.
* Split setValue tests into sub-suites.
* Fixed angle >360 tests
* Changed var declarations to property declarations.
2019-05-17 15:19:14 -07:00
Neil Fraser
28ad3a9bd3
Blockly.utils.userAgent moved to Blockly.userAgent
2019-05-10 16:56:26 -07:00
Neil Fraser
4062030731
Remove goog.userAgent dependency.
2019-05-10 14:03:21 -07:00
Beka Westberg
e8573bc0db
Added isSerializable function and SERIALIZABLE property to fields.
2019-04-21 08:28:37 -07:00
Neil Fraser
e9de083361
Fix @return JSDocs.
2019-03-29 15:24:37 -07:00
Rachel Fenichel
dfc74b8c4f
Use dropdownDiv for the angle field as well
2019-02-26 14:54:21 -08:00
alschmiedt
4bd21c5128
Added todo
2018-12-13 14:39:27 -08:00
alschmiedt
aae15f01f4
Groups events fired during field input change
2018-12-13 12:52:55 -08:00