Aaron Dodson
e0693a65d2
chore: Remove declareLegacyNamespace() from files in core ( #5525 )
...
* chore: Remove declareLegacyNamespace() from files in core
* fix: Update missing/errant re-exports in blockly.js
2021-09-23 14:48:52 -07:00
Rachel Fenichel
3adfaaf6d9
chore: named exports for block* files ( #5512 )
...
* chore: named export for block.js
* chore: named export for block_drag_surface.js
* chore: named export for block_dragger.js
* chore: named export for block_svg.js
* Fix import ordering
* chore: fix imports using requireType
* Remove extra require
2021-09-22 08:46:19 -07:00
Beka Westberg
e954193009
fix: project cereal cleanup ( #5398 )
...
* fix: make exception constructors package
* fix: rename blocks.load to blocks.append
* fix: inline docs
* fix: consistency in block serialization
* fix: remove unexported functions
* fix: interface requires
* fix: tag TODO with issue number
2021-09-20 13:08:35 -07:00
Beka Westberg
4f890d73a5
fix: redo disconnect from shadow bug
2021-09-20 13:08:35 -07:00
Beka Westberg
fd12dcf1e7
feat: add throwing errors for bad shadows ( #5330 )
...
* fix: add throwing errors for bad shadows
* tests: add tests for setShadowDom
2021-09-20 13:08:35 -07:00
Beka Westberg
1d4cbd1ab6
Add serializing shadows as JSOs for the JSO system ( #5246 )
...
* Move existing tests into new suite
* Add tests for setShadowState
* Add assertions for serialization
* Unskip serialization tests
* Add logic to handle shadows in both systems
* Uncomment tests
* fix: add access modifiers to new comment funcs
* fix: fixup types
* fix: remove addNextBlocks = true
* feat: add real child of shadow errors
* fix: types
2021-09-20 13:08:35 -07:00
Beka Westberg
91922aa571
Add throwing exceptions during deserialization ( #5200 )
...
* Add exception definitions
* Add tests for throwing errors during deserialization
* Add actually throwing exceptions
* Cleanup
* Cleanup
* Fix tests
* fix: PR Comments
2021-09-20 13:08:35 -07:00
Christopher Allen
4c40378b9a
Use goog.requireType when importing interfaces (etc.) ( #5343 )
...
* Use goog.requireType when importing I* interfaces
Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.
This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.
* Use goog.requireType when only using import for type specifications
Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.
* Remove spurious eslint-disable no-unused-vars
There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.
Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.
* Remove obsolete Closure Compiler error group
stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
Aaron Dodson
0e6258ca1a
Migrated to inline exports
2021-07-21 08:17:13 -07:00
Aaron Dodson
da960d5973
Convert private static functions to module-internal functions in core/connection.js
2021-07-20 10:49:21 -07:00
Aaron Dodson
bdd0353549
clang-format core/connection.js
2021-07-16 14:16:06 -07:00
Aaron Dodson
210fcea198
Migrate core/connection.js to named requires
2021-07-16 14:13:40 -07:00
Aaron Dodson
fc62fed33c
Migrate core/connection.js to goog.module
2021-07-16 13:55:08 -07:00
Aaron Dodson
fa158d143e
Migrate core/connection.js to ES6 const/let
2021-07-16 13:48:33 -07:00
Beka Westberg
13bb9f5bf6
Refactor connect logic ( #4880 )
...
* Refactor connect logic.
* Fixup from rebase
* Fix build
* PR Comments
2021-06-18 09:53:43 -07:00
Neil Fraser
cff7b359f4
Make comments more consistent.
2021-06-09 11:41:42 -07:00
Neil Fraser
e661c92a36
More JSDoc improvements
2021-05-27 21:30:26 -07:00
Neil Fraser
d919b0af21
Update JSDoc from Array.<> to Array<>
...
Same with Object.
2021-05-27 21:30:26 -07:00
Beka Westberg
5ffd43824f
Change lastConnectionInRow to getPlaceForOrphanedOutput - Take 2 ( #4851 )
...
* Change lastConnectionInRow to getPlaceForOrphanedOutput
* PR comments
2021-05-26 09:16:33 -07:00
Sam El-Husseini
f2f878db8c
Fix multiple strict require warnings ( #4793 )
2021-04-21 16:46:04 -07:00
Sam El-Husseini
63d26dc186
Add extra requires check ( #4677 )
...
* Add extra requires check
2021-03-05 09:50:51 -08:00
Rachel Fenichel
7f8c875b29
Fix lint
2021-03-04 10:23:20 -08:00
Rachel Fenichel
750b62030b
First pass at creating connectionTypes and inputTYpes
2021-03-04 10:22:24 -08:00
Sam El-Husseini
ab8a11784d
Fix event related missing requires ( #4656 )
...
* Fix event related missing requires
2021-02-25 14:28:11 -08:00
Rachel Fenichel
c9be2402bd
More missing requires
2021-01-12 12:38:21 -08:00
Sam El-Husseini
fba35d342c
Add missing require Blockly.constants ( #4366 )
2020-10-12 17:56:42 -04:00
alschmiedt
22d598484f
Update blockToDom types to include document fragments ( #4280 )
2020-09-16 10:51:09 -07:00
Beka Westberg
c732484180
Add programmatically setting shadows Take 2 ( #4215 )
...
* Add programmatically setting shadows
2020-09-08 08:50:01 -07:00
Rachel Fenichel
815c8b8919
More deprecation
2020-07-16 17:49:51 -06:00
Rachel Fenichel
602d1b6d63
Use new deprecation warning helper
2020-07-16 17:46:49 -06:00
Rachel Fenichel
3322834a9b
Add deprecation warnings and tests
2020-07-16 17:40:13 -06:00
Rachel Fenichel
e47d33148e
Review feedback
2020-07-16 17:40:13 -06:00
Rachel Fenichel
809148b435
Fix compiler errors
2020-07-16 17:40:13 -06:00
Rachel Fenichel
7288c66294
Rename connectionTypeChecker->connectionChecker
2020-07-16 17:40:13 -06:00
Rachel Fenichel
8ae3dc3d5e
Cleanup
2020-07-16 17:40:13 -06:00
Rachel Fenichel
e24f3cef9b
Add isDragging to canConnectWithReason and delete newly unused code paths.
2020-07-16 17:40:13 -06:00
Rachel Fenichel
e3c8d834cb
Add todos and rebuild
2020-07-16 17:40:13 -06:00
Rachel Fenichel
450aed0aa2
More work on connection type checks
2020-07-16 17:40:12 -06:00
Rachel Fenichel
bb8348befd
Move to a single canConnect function, and update tests
2020-07-16 17:40:12 -06:00
Rachel Fenichel
8c17e325b5
Update connection tests to directly use the type checker
2020-07-16 17:40:12 -06:00
Rachel Fenichel
c743a92bb9
Start work on connection type checker
2020-07-16 17:40:12 -06:00
Sam El-Husseini
c9563c1d24
Revert "Add programmatically setting shadows ( #3902 )"
...
This reverts commit 3aa1963be8 .
2020-06-12 08:54:04 -07:00
alschmiedt
8585ef111c
Remove @package ( #3961 )
2020-06-12 08:17:16 -07:00
Sam El-Husseini
1052f7548b
Enable unusedPrivateMembers check ( #3924 )
...
* Add unusedPrivateMembers check
2020-05-28 17:44:16 -07:00
Beka Westberg
3aa1963be8
Add programmatically setting shadows ( #3902 )
...
* Add programmatically setting shadows
2020-05-21 11:44:08 -07:00
Sam El-Husseini
317834ff59
Add accessibility interfaces and fix navigation types ( #3908 )
...
* Add accessibility interfaces and fix navigation types
2020-05-21 11:18:10 -07:00
Sam El-Husseini
fd916fdb9b
Bounding Box interface ( #3906 )
...
* Add an interface describing a bounding box registered on the workspace
* Clear the bounding box array
* PR comments
* Update chromedriver
2020-05-19 18:06:11 -07:00
Monica Kozbial
a9223b0b22
Typo fixes. ( #3769 )
2020-03-25 15:47:27 -07:00
Neil Fraser
4e2f8e6e02
Use SPDX licences.
...
This is a followup to #3127 .
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Neil Fraser
123f436e04
Add parens around inline assignments ( #3381 )
2019-10-31 15:17:35 -07:00