Neil Fraser
e642a77f5d
Use conventional prefix/suffix for function calls.
...
Previously a function call with no return value generated:
prefix();
suffix();
function();
The intent was so the prefix and suffix calls in the function body wouldn’t overlap with the prefix and suffix calls of the function call. However, this is doomed to be inconsistent with a function call with a return value:
prefix();
print(function());
suffix();
Thus since overlaping must exist, both types of function calls should have consistent suffix locations.
2019-05-17 15:04:39 -07:00
translatewiki.net
475d8eb71f
Localisation updates from https://translatewiki.net .
2019-05-17 12:11:24 +02:00
Neil Fraser
04e39c20f8
Fix indentation bug if no xfix exists in function
2019-05-14 17:19:31 -07:00
Neil Fraser
585866a1b6
Revisit function block for return.
...
Visit (with prefix and suffix) function block when executed. This commit adds a revisit at the end of the function body when evaluating the return value.
2019-05-14 17:19:31 -07:00
Neil Fraser
c0e14c3a7c
Add method to suppress prefix/suffix from blocks.
...
This allows generators to have more control over the placement of suffix. Needed for ‘if’ blocks and function calls which require their suffix code to be somewhere other than the end.
Also, add loop’s prefix to ‘break’ blocks, since the loop’s suffix will be the next statement hit.
Also, reuse procedures_callreturn generator for procedures_callnoreturn.
2019-05-14 17:19:31 -07:00
Neil Fraser
25adb40e66
Prefix and suffix edge cases for flow statements.
...
Call suffix code on break/continue before executing the break/continue.
Call prefix code for enclosing loop before executing continue.
2019-05-14 17:19:31 -07:00
Neil Fraser
0259f8bb48
Add extra suffix when generating if/return block.
...
Also fix loops in Lua.
2019-05-14 17:19:31 -07:00
Neil Fraser
ba18ae2159
Add STATEMENT_SUFFIX
...
Also remove need to manually indent INFINITE_LOOP_TRAP. This is a breaking change for Python users of this property. However, very few users of this property exist, given that the existing code breaks if the block ID has a $ in it (also fixed in this PR).
2019-05-14 17:19:31 -07:00
Rachel Fenichel
35cbed1584
Merge pull request #2457 from google/fraser-userAgent
...
Remove goog.userAgent dependency.
2019-05-13 14:47:31 -07:00
translatewiki.net
6d962e5f87
Localisation updates from https://translatewiki.net .
2019-05-13 14:27:56 +02:00
Neil Fraser
28ad3a9bd3
Blockly.utils.userAgent moved to Blockly.userAgent
2019-05-10 16:56:26 -07:00
Neil Fraser
25ddecab50
Undo workaround for IE10.
...
Due to no longer supporting IE10, we don’t need the code added here: 92f3880008
2019-05-10 16:39:32 -07:00
Neil Fraser
fa8c7f3884
Lint fix.
2019-05-10 14:30:31 -07:00
Neil Fraser
4062030731
Remove goog.userAgent dependency.
2019-05-10 14:03:21 -07:00
translatewiki.net
e2281e5a98
Localisation updates from https://translatewiki.net .
2019-05-09 16:52:24 +02:00
asunwoo98
e25734ff25
typo fix in createVariable documentation in variable.js ( #2443 )
2019-05-06 13:09:50 -07:00
Rachel Fenichel
4af436f748
Merge pull request #2427 from BeksOmega/fixes/InitView
...
Refactored field.init into field.initView and field.initModel
2019-05-06 09:20:50 -07:00
translatewiki.net
f065c78dee
Localisation updates from https://translatewiki.net .
2019-05-06 16:35:40 +02:00
Beka Westberg
354d402c49
Refactored field.init into field.initView and field.initModel
2019-05-03 07:12:46 -07:00
Rachel Fenichel
12a769b9c4
Merge pull request #2426 from rachel-fenichel/testing/run_mocha_tests
...
Add mocha tests to npm test
2019-05-02 15:32:09 -07:00
Rachel Fenichel
9e7becc262
Update comments
2019-05-02 15:31:54 -07:00
Navid Zandi
44501f17cc
Resolve field angle overlap render problem ( #2418 )
...
* Rebuild and update version numbers
* rebuild
* Update version number to 1.20190419.0
* Resolve field angle overlap render problem
* use block.getColourBorder() function
2019-05-02 13:38:48 -07:00
Neil Fraser
834fa64674
Use Element constants and ‘i’ variable.
...
I don’t care about whether we use the Element constants or the ubiquitously known 1 & 3 integers. But we had a mix.
Also, ’x’ is usually used for horizontal location, ‘i’ is an iterator.
No functional change.
2019-05-02 09:56:37 -07:00
Neil Fraser
6f433d7521
Don’t preserve IDs during cut/copy/paste or flyout
...
Previously, if the XML of a toolbox contained a block ID, the first creation of this block would inherit this ID. Thus two realtime collaborators could realistically end up with conflict. Likewise, cut and paste could generate similar conflict.
2019-05-02 09:56:37 -07:00
Neil Fraser
e06916e5e3
Factor out licence stripping
...
Matches code in Blockly Games.
No functional change.
2019-05-02 09:56:37 -07:00
Rachel Fenichel
5e56b4ad58
Merge pull request #2425 from BeksOmega/fixes/fromXml
...
Removed Explicitly Setting Variable Type to Two Single Quotes
2019-05-01 15:42:10 -07:00
Beka Westberg
3afcd23535
Removed explicitly setting variable type to two single quotes.
2019-05-01 14:31:20 -07:00
Rachel Fenichel
99dc9bb38f
Fix test (matching fix in jsunit tests)
2019-05-01 14:19:55 -07:00
Rachel Fenichel
e77efa6c13
Add mocha tests + parsing to npm test
2019-05-01 13:43:19 -07:00
Rachel Fenichel
5983c3c4b7
Merge pull request #2424 from rachel-fenichel/testing/webdriverio_upgrade
...
Update to webdriverio v5; fix resulting test breakages
2019-05-01 10:55:40 -07:00
Rachel Fenichel
00f84bb595
Add firefox addon explicitly
2019-05-01 10:50:14 -07:00
Rachel Fenichel
da2a89e177
Update to webdriverio v5; fix resulting test breakages
2019-04-30 14:38:33 -07:00
Neil Fraser
8d4a73e33d
Strip MIT’s licence out of compiled code.
...
Matches existing stripping of Google’s licence. Done with MIT’s permission. Resolves issue 2412.
2019-04-29 17:27:43 -07:00
Rachel Fenichel
67ee390ef9
Merge pull request #2413 from BeksOmega/feature/FieldUpdateColour
...
Added updateColour to Field
2019-04-29 17:00:58 -07:00
Beka Westberg
247aafae7e
Added updateColour to field.
2019-04-29 16:53:59 -07:00
Beka Westberg
79d75b9f3d
Fixed buttons being rendered as labels if they come after a label. ( #2410 )
2019-04-25 18:21:42 -07:00
Neil Fraser
c438188ab1
Delete two unused i18n scripts
...
These date back to before Blockly Games was separated from Blockly.
2019-04-25 17:13:49 -07:00
Rachel Fenichel
de6bf6e6ab
Merge pull request #2407 from BeksOmega/feature/FieldsXML
...
Added fromXml and toXml to Fields
2019-04-25 16:10:48 -07:00
Beka Westberg
123b5dc91e
Added fromXml and toXml to fields.
2019-04-25 16:00:09 -07:00
Beka Westberg
5c4c816a9b
Removed setVisible from the public API ( #2406 )
2019-04-24 16:07:47 -07:00
Beka Westberg
ce816b93bf
Added field_label_serializable. ( #2399 )
2019-04-24 10:43:09 -07:00
Rachel Fenichel
71d7809c8d
Set node version explicitly for travis; rebuild ( #2403 )
...
* Set node version explicitly for travis
* rebuild
* Tweak travis config
2019-04-23 16:33:39 -07:00
RoboErikG
d625d60c49
Add release and milestone information to Readme ( #2401 )
...
* Add release and milestone information to Readme
* Readme updates in response to comments
2019-04-23 14:36:37 -07:00
Jim Jiang
1b10d134a5
Add Block.setEnabled ( #2386 )
...
* Implement Block.setEnabled()
From issue #1593 . This commit:
- add setEnabled
- deprecate setDisabled
* Update setDisabled calls to setEnabled
Add setEnabled and deprecate setDisabled in
- core/block_svg
Update calls in
- blocks/loops
- blocks/procedures
- core/block_events
- core/events
- core/flyout_base
- core/xml
- tests/workplace_svg/procedure_svg_test
* Implement changes from comments from RoboErikG
- Implement isEnabled()
- Make this.disabled @private
- Make setDisabled(disabled) call setEnabled(!disabled)
- Update setEnabled to use isEnabled()
* Utilize isEnabled() and fix typos
Fix missing parentheses
Implement isEnabled() more widely
Fix lint and parentheses errors
* Change prevDisabledState to prevEnabledState
2019-04-23 08:49:07 -07:00
asunwoo98
aa4d885cba
Validate newValue parameter in setValue ( #2392 )
...
* Validate newValue parameter in setValue
* bugfix
* alternate fix
* test
* cleanup
2019-04-22 16:00:37 -07:00
Rachel Fenichel
a84e86f097
Merge pull request #2366 from alschmiedt/Documentation_Update
...
Documentation update
2019-04-22 14:45:38 -07:00
alschmiedt
1ca7d6a28b
Clarifies what statementToCode does
2019-04-22 14:20:05 -07:00
translatewiki.net
fc80d71f39
Localisation updates from https://translatewiki.net .
2019-04-22 22:04:07 +02:00
Beka Westberg
9a9c6612f8
Changed buttons and labels to respect <sep> elements in toolbox. ( #2395 )
2019-04-22 12:23:04 -07:00
Rachel Fenichel
bc49f29015
Merge pull request #2389 from BeksOmega/feature/SerializableFields
...
Added isSerializable and SERIALIZABLE to Field
2019-04-22 11:05:50 -07:00